[INFO] crate ldap 0.2.0 is already in cache [INFO] extracting crate ldap 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ldap/0.2.0 [INFO] extracting crate ldap 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ldap/0.2.0 [INFO] validating manifest of ldap-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ldap-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ldap-0.2.0 [INFO] finished frobbing ldap-0.2.0 [INFO] frobbed toml for ldap-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ldap/0.2.0/Cargo.toml [INFO] started frobbing ldap-0.2.0 [INFO] finished frobbing ldap-0.2.0 [INFO] frobbed toml for ldap-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ldap/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ldap-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ldap/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3a259f462a49874ca616ab107687fa0766d69616308e03e4d9a6b9e5a6a067c [INFO] running `"docker" "start" "-a" "d3a259f462a49874ca616ab107687fa0766d69616308e03e4d9a6b9e5a6a067c"` [INFO] [stderr] Checking asnom v0.1.0 [INFO] [stderr] Checking ldap v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/protocol.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(io::Error::new(io::ErrorKind::Other, "Invalid (RequestId, Tag) received.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "Invalid (RequestId, Tag) received."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Codec': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Codec': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | impl Codec for LdapCodec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | impl ClientProto for LdapProto { [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | impl ServerProto for LdapProto { [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:19:36 [INFO] [stderr] | [INFO] [stderr] 19 | fn decode(&mut self, buf: &mut EasyBuf) -> Result, io::Error> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf::as_slice': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | match parse_tag(buf.as_slice()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io::framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(io.framed(LdapCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io::framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(io.framed(LdapCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/protocol.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(io::Error::new(io::ErrorKind::Other, "Invalid (RequestId, Tag) received.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "Invalid (RequestId, Tag) received."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Codec': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | use tokio_core::io::{Io, Codec, EasyBuf, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Codec': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | impl Codec for LdapCodec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | impl ClientProto for LdapProto { [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | impl ServerProto for LdapProto { [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:19:36 [INFO] [stderr] | [INFO] [stderr] 19 | fn decode(&mut self, buf: &mut EasyBuf) -> Result, io::Error> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::EasyBuf::as_slice': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | match parse_tag(buf.as_slice()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io::framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | Ok(io.framed(LdapCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io::framed': moved to the `tokio-io` crate [INFO] [stderr] --> src/protocol.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(io.framed(LdapCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.68s [INFO] running `"docker" "inspect" "d3a259f462a49874ca616ab107687fa0766d69616308e03e4d9a6b9e5a6a067c"` [INFO] running `"docker" "rm" "-f" "d3a259f462a49874ca616ab107687fa0766d69616308e03e4d9a6b9e5a6a067c"` [INFO] [stdout] d3a259f462a49874ca616ab107687fa0766d69616308e03e4d9a6b9e5a6a067c