[INFO] crate lazyf 0.1.4 is already in cache [INFO] extracting crate lazyf 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/lazyf/0.1.4 [INFO] extracting crate lazyf 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazyf/0.1.4 [INFO] validating manifest of lazyf-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazyf-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazyf-0.1.4 [INFO] finished frobbing lazyf-0.1.4 [INFO] frobbed toml for lazyf-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/lazyf/0.1.4/Cargo.toml [INFO] started frobbing lazyf-0.1.4 [INFO] finished frobbing lazyf-0.1.4 [INFO] frobbed toml for lazyf-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazyf/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazyf-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lazyf/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 544568f925f78a1c312bd1e391889ae8bc319ec881f372c98d9c496bec162c42 [INFO] running `"docker" "start" "-a" "544568f925f78a1c312bd1e391889ae8bc319ec881f372c98d9c496bec162c42"` [INFO] [stderr] Checking lazyf v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flag.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | v:v, [INFO] [stderr] | ^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flag.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | v:v, [INFO] [stderr] | ^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flag.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return ss_get(&s,&mut env::args()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ss_get(&s,&mut env::args())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Deref` [INFO] [stderr] --> src/cfg.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ops::Deref; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brace.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flag.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return ss_get(&s,&mut env::args()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ss_get(&s,&mut env::args())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Deref` [INFO] [stderr] --> src/cfg.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ops::Deref; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brace.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lzlist.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | let ss = line.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: item `lzlist::LzList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lzlist.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl LzList { [INFO] [stderr] 57 | | pub fn read(s :&String)->Result{ [INFO] [stderr] 58 | | let sp = s.split("\n"); [INFO] [stderr] 59 | | let mut res = LzList{ [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lzlist.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn read(s :&String)->Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lzlist.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | let sp = s.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lzlist.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if a.len() == 0 {continue;} [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lzlist.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn load_all<'a, IT, ST:AsRef+Debug>(fnames:&mut IT)->LzList [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lzlist.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match LzList::load(&n){ [INFO] [stderr] 118 | | Ok(lz)=>jn.push(lz), [INFO] [stderr] 119 | | _=>{}, [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(lz) = LzList::load(&n) { jn.push(lz) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lzlist.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for ref lz in &self.items{ [INFO] [stderr] | ^^^^^^ ----------- help: try: `let lz = &&self.items;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lzlist.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if self.items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lzlist.rs:194:23 [INFO] [stderr] | [INFO] [stderr] 194 | (&self.items).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/cfg.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn load_first<'a,L,S>(fgname:&str,locs:L)->Cfg [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match floc{ [INFO] [stderr] 36 | | Some(s)=>return Cfg::load(&s), [INFO] [stderr] 37 | | _=>{}, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = floc { return Cfg::load(&s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match LzList::load(l2){ [INFO] [stderr] 43 | | Ok(r)=>return Cfg{list:r,loc:PathBuf::from(l2)}, [INFO] [stderr] 44 | | _=>{}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(r) = LzList::load(l2) { return Cfg{list:r,loc:PathBuf::from(l2)} }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match fres { [INFO] [stderr] 75 | | Some(_)=>return fres, [INFO] [stderr] 76 | | _=>{}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = fres { return fres }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/get.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | self.get_s(s).unwrap_or(def.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| def.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lzlist.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | let ss = line.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: item `lzlist::LzList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lzlist.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl LzList { [INFO] [stderr] 57 | | pub fn read(s :&String)->Result{ [INFO] [stderr] 58 | | let sp = s.split("\n"); [INFO] [stderr] 59 | | let mut res = LzList{ [INFO] [stderr] ... | [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lzlist.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn read(s :&String)->Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lzlist.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | let sp = s.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lzlist.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if a.len() == 0 {continue;} [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `a.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lzlist.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn load_all<'a, IT, ST:AsRef+Debug>(fnames:&mut IT)->LzList [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lzlist.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match LzList::load(&n){ [INFO] [stderr] 118 | | Ok(lz)=>jn.push(lz), [INFO] [stderr] 119 | | _=>{}, [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(lz) = LzList::load(&n) { jn.push(lz) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lzlist.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for ref lz in &self.items{ [INFO] [stderr] | ^^^^^^ ----------- help: try: `let lz = &&self.items;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lzlist.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if self.items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lzlist.rs:194:23 [INFO] [stderr] | [INFO] [stderr] 194 | (&self.items).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/cfg.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn load_first<'a,L,S>(fgname:&str,locs:L)->Cfg [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match floc{ [INFO] [stderr] 36 | | Some(s)=>return Cfg::load(&s), [INFO] [stderr] 37 | | _=>{}, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = floc { return Cfg::load(&s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match LzList::load(l2){ [INFO] [stderr] 43 | | Ok(r)=>return Cfg{list:r,loc:PathBuf::from(l2)}, [INFO] [stderr] 44 | | _=>{}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(r) = LzList::load(l2) { return Cfg{list:r,loc:PathBuf::from(l2)} }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match fres { [INFO] [stderr] 75 | | Some(_)=>return fres, [INFO] [stderr] 76 | | _=>{}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = fres { return fres }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/get.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | self.get_s(s).unwrap_or(def.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| def.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/tests.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | let r = flag::ss_get("-a",&mut v.into_iter().map(|&a|String::from(a))); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lazyf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "544568f925f78a1c312bd1e391889ae8bc319ec881f372c98d9c496bec162c42"` [INFO] running `"docker" "rm" "-f" "544568f925f78a1c312bd1e391889ae8bc319ec881f372c98d9c496bec162c42"` [INFO] [stdout] 544568f925f78a1c312bd1e391889ae8bc319ec881f372c98d9c496bec162c42