[INFO] crate lazy_transducer 0.1.1 is already in cache [INFO] extracting crate lazy_transducer 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lazy_transducer/0.1.1 [INFO] extracting crate lazy_transducer 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_transducer/0.1.1 [INFO] validating manifest of lazy_transducer-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazy_transducer-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazy_transducer-0.1.1 [INFO] finished frobbing lazy_transducer-0.1.1 [INFO] frobbed toml for lazy_transducer-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lazy_transducer/0.1.1/Cargo.toml [INFO] started frobbing lazy_transducer-0.1.1 [INFO] finished frobbing lazy_transducer-0.1.1 [INFO] frobbed toml for lazy_transducer-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_transducer/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazy_transducer-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lazy_transducer/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fa9ada0301be3e7aa3720cd6586bd64a6370192f1d5b9f8c8caff569fac7ad7 [INFO] running `"docker" "start" "-a" "8fa9ada0301be3e7aa3720cd6586bd64a6370192f1d5b9f8c8caff569fac7ad7"` [INFO] [stderr] Compiling scroll_derive v0.8.0 [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Checking scroll v0.8.0 [INFO] [stderr] Checking lazy_transducer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | let contents = self.input.ok_or(TransducerError::BuilderError("No input given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No input given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | let transducer = self.transducer.ok_or(TransducerError::BuilderError("No transducer given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No transducer given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | let input = self.input.ok_or(TransducerError::BuilderError("No input given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No input given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: item `lazy_transducer::LazyTransducer<'a, Input, Output>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lazy_transducer.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl<'a, Input, Output> LazyTransducer<'a, Input, Output> [INFO] [stderr] 115 | | where Input: 'a + Copy, [INFO] [stderr] 116 | | Output: 'a [INFO] [stderr] 117 | | { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lazy_transducer.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | transducer: self.transducer.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.transducer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lazy_transducer.rs:390:29 [INFO] [stderr] | [INFO] [stderr] 390 | folder.consume_iter(self.into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | let contents = self.input.ok_or(TransducerError::BuilderError("No input given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No input given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | let transducer = self.transducer.ok_or(TransducerError::BuilderError("No transducer given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No transducer given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | let input = self.input.ok_or(TransducerError::BuilderError("No input given".to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| TransducerError::BuilderError("No input given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: item `lazy_transducer::LazyTransducer<'a, Input, Output>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lazy_transducer.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl<'a, Input, Output> LazyTransducer<'a, Input, Output> [INFO] [stderr] 115 | | where Input: 'a + Copy, [INFO] [stderr] 116 | | Output: 'a [INFO] [stderr] 117 | | { [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lazy_transducer.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | transducer: self.transducer.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.transducer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lazy_transducer.rs:390:29 [INFO] [stderr] | [INFO] [stderr] 390 | folder.consume_iter(self.into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:32:75 [INFO] [stderr] | [INFO] [stderr] 32 | let derps: Vec = lt.into_par_iter().map(|mut derp| { derp.one = 0xdeadbeef; derp }).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(d.one, 0xdeadbeef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(deadbeef, 0xdeadbeefu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xdead_beefu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(0xdeadbeef, n); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.02s [INFO] running `"docker" "inspect" "8fa9ada0301be3e7aa3720cd6586bd64a6370192f1d5b9f8c8caff569fac7ad7"` [INFO] running `"docker" "rm" "-f" "8fa9ada0301be3e7aa3720cd6586bd64a6370192f1d5b9f8c8caff569fac7ad7"` [INFO] [stdout] 8fa9ada0301be3e7aa3720cd6586bd64a6370192f1d5b9f8c8caff569fac7ad7