[INFO] crate lazy_conf 0.1.1 is already in cache
[INFO] extracting crate lazy_conf 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lazy_conf/0.1.1
[INFO] extracting crate lazy_conf 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_conf/0.1.1
[INFO] validating manifest of lazy_conf-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lazy_conf-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lazy_conf-0.1.1
[INFO] finished frobbing lazy_conf-0.1.1
[INFO] frobbed toml for lazy_conf-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lazy_conf/0.1.1/Cargo.toml
[INFO] started frobbing lazy_conf-0.1.1
[INFO] finished frobbing lazy_conf-0.1.1
[INFO] frobbed toml for lazy_conf-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_conf/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lazy_conf-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lazy_conf/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 82e6d34721f3308aa00e13dfdf8f897eb5179d5d29451e54d3b97b550510c5e7
[INFO] running `"docker" "start" "-a" "82e6d34721f3308aa00e13dfdf8f897eb5179d5d29451e54d3b97b550510c5e7"`
[INFO] [stderr]     Checking lazy_conf v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/get.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/get.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 | /             if *gm == g{
[INFO] [stderr] 115 | |                 if v.is_present(s){
[INFO] [stderr] 116 | |                     return true;
[INFO] [stderr] 117 | |                 }
[INFO] [stderr] 118 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if *gm == g && v.is_present(s) {
[INFO] [stderr] 115 |     return true;
[INFO] [stderr] 116 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lz_list.rs:89:16
[INFO] [stderr]    |
[INFO] [stderr] 89 |             0=>return None,
[INFO] [stderr]    |                ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `get::GetHolder`
[INFO] [stderr]   --> src/get.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new()->Self{
[INFO] [stderr] 72 | |         GetHolder{v:Vec::new(),help_mess:String::new(),fails:String::new()}
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 63 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/get.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     pub fn grab<'a>(&'a mut self)->Grabber<'a>{ 
[INFO] [stderr] 80 | |         Grabber{
[INFO] [stderr] 81 | |             v:Vec::new(),
[INFO] [stderr] 82 | |             h:self,
[INFO] [stderr] 83 | |         }
[INFO] [stderr] 84 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/get.rs:129:12
[INFO] [stderr]     |
[INFO] [stderr] 129 |         if self.fails.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.fails.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/get.rs:141:12
[INFO] [stderr]     |
[INFO] [stderr] 141 |         if self.fails.len() >0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.fails.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/get.rs:169:23
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn is_present(self)->bool{
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/get.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/get.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 | /             if *gm == g{
[INFO] [stderr] 115 | |                 if v.is_present(s){
[INFO] [stderr] 116 | |                     return true;
[INFO] [stderr] 117 | |                 }
[INFO] [stderr] 118 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if *gm == g && v.is_present(s) {
[INFO] [stderr] 115 |     return true;
[INFO] [stderr] 116 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lz_list.rs:89:16
[INFO] [stderr]    |
[INFO] [stderr] 89 |             0=>return None,
[INFO] [stderr]    |                ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lz_list.rs:87:36
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let sp:Vec<&str> = s.split(".").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/flag.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         env::args().find(|v|v==s).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|v|v==s).is_some()` with `any(|v|v==s)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `get::GetHolder`
[INFO] [stderr]   --> src/get.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new()->Self{
[INFO] [stderr] 72 | |         GetHolder{v:Vec::new(),help_mess:String::new(),fails:String::new()}
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 63 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/get.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     pub fn grab<'a>(&'a mut self)->Grabber<'a>{ 
[INFO] [stderr] 80 | |         Grabber{
[INFO] [stderr] 81 | |             v:Vec::new(),
[INFO] [stderr] 82 | |             h:self,
[INFO] [stderr] 83 | |         }
[INFO] [stderr] 84 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/get.rs:129:12
[INFO] [stderr]     |
[INFO] [stderr] 129 |         if self.fails.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.fails.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/get.rs:141:12
[INFO] [stderr]     |
[INFO] [stderr] 141 |         if self.fails.len() >0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.fails.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/get.rs:169:23
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn is_present(self)->bool{
[INFO] [stderr]     |                       ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lz_list.rs:87:36
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let sp:Vec<&str> = s.split(".").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lz_list.rs:112:20
[INFO] [stderr]     |
[INFO] [stderr] 112 |         assert_eq!(dave.deets.get("ext0").unwrap(),"3");
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dave.deets["ext0"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lz_list.rs:113:20
[INFO] [stderr]     |
[INFO] [stderr] 113 |         assert_eq!(dave.deets.get("ext1").unwrap(),"4");
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dave.deets["ext1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lz_list.rs:116:20
[INFO] [stderr]     |
[INFO] [stderr] 116 |         assert_eq!(dave.deets.get("fir").unwrap(),"plop");
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dave.deets["fir"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lz_list.rs:119:20
[INFO] [stderr]     |
[INFO] [stderr] 119 |         assert_eq!(dave.deets.get("flur").unwrap(),"");
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dave.deets["flur"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/flag.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         env::args().find(|v|v==s).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|v|v==s).is_some()` with `any(|v|v==s)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.19s
[INFO] running `"docker" "inspect" "82e6d34721f3308aa00e13dfdf8f897eb5179d5d29451e54d3b97b550510c5e7"`
[INFO] running `"docker" "rm" "-f" "82e6d34721f3308aa00e13dfdf8f897eb5179d5d29451e54d3b97b550510c5e7"`
[INFO] [stdout] 82e6d34721f3308aa00e13dfdf8f897eb5179d5d29451e54d3b97b550510c5e7