[INFO] crate lazy-socket 0.3.0 is already in cache [INFO] extracting crate lazy-socket 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/lazy-socket/0.3.0 [INFO] extracting crate lazy-socket 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy-socket/0.3.0 [INFO] validating manifest of lazy-socket-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazy-socket-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazy-socket-0.3.0 [INFO] finished frobbing lazy-socket-0.3.0 [INFO] frobbed toml for lazy-socket-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/lazy-socket/0.3.0/Cargo.toml [INFO] started frobbing lazy-socket-0.3.0 [INFO] finished frobbing lazy-socket-0.3.0 [INFO] frobbed toml for lazy-socket-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy-socket/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazy-socket-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lazy-socket/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5587c49cfdc074673f654d60f458dd17f5869c22feaba0deb72fb195de69fac [INFO] running `"docker" "start" "-a" "b5587c49cfdc074673f654d60f458dd17f5869c22feaba0deb72fb195de69fac"` [INFO] [stderr] Checking lazy-socket v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: the `sock @ _` pattern can be written as just `sock` [INFO] [stderr] --> src/raw/unix.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | sock @ _ => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `sock @ _` pattern can be written as just `sock` [INFO] [stderr] --> src/raw/unix.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | sock @ _ => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/raw/unix.rs:498:16 [INFO] [stderr] | [INFO] [stderr] 498 | if value == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/raw/unix.rs:563:11 [INFO] [stderr] | [INFO] [stderr] 563 | match storage.ss_family as c_int { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(storage.ss_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raw/unix.rs:577:42 [INFO] [stderr] | [INFO] [stderr] 577 | let ip = net::Ipv6Addr::from(storage.sin6_addr.s6_addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `storage.sin6_addr.s6_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the `result @ _` pattern can be written as just `result` [INFO] [stderr] --> src/raw/unix.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | result @ _ => Ok(result) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `sock @ _` pattern can be written as just `sock` [INFO] [stderr] --> src/raw/unix.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | sock @ _ => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `sock @ _` pattern can be written as just `sock` [INFO] [stderr] --> src/raw/unix.rs:408:17 [INFO] [stderr] | [INFO] [stderr] 408 | sock @ _ => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/raw/unix.rs:498:16 [INFO] [stderr] | [INFO] [stderr] 498 | if value == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/raw/unix.rs:563:11 [INFO] [stderr] | [INFO] [stderr] 563 | match storage.ss_family as c_int { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(storage.ss_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raw/unix.rs:577:42 [INFO] [stderr] | [INFO] [stderr] 577 | let ip = net::Ipv6Addr::from(storage.sin6_addr.s6_addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `storage.sin6_addr.s6_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the `result @ _` pattern can be written as just `result` [INFO] [stderr] --> src/raw/unix.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | result @ _ => Ok(result) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/socket.rs:304:78 [INFO] [stderr] | [INFO] [stderr] 304 | let elapsed = elapsed.as_secs() / 1000 + elapsed.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> tests/socket.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | assert!(result.is_ok() && result.unwrap() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/socket.rs:304:46 [INFO] [stderr] | [INFO] [stderr] 304 | let elapsed = elapsed.as_secs() / 1000 + elapsed.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "b5587c49cfdc074673f654d60f458dd17f5869c22feaba0deb72fb195de69fac"` [INFO] running `"docker" "rm" "-f" "b5587c49cfdc074673f654d60f458dd17f5869c22feaba0deb72fb195de69fac"` [INFO] [stdout] b5587c49cfdc074673f654d60f458dd17f5869c22feaba0deb72fb195de69fac