[INFO] crate lazy-pool 0.2.3 is already in cache [INFO] extracting crate lazy-pool 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/lazy-pool/0.2.3 [INFO] extracting crate lazy-pool 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy-pool/0.2.3 [INFO] validating manifest of lazy-pool-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazy-pool-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazy-pool-0.2.3 [INFO] finished frobbing lazy-pool-0.2.3 [INFO] frobbed toml for lazy-pool-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/lazy-pool/0.2.3/Cargo.toml [INFO] started frobbing lazy-pool-0.2.3 [INFO] finished frobbing lazy-pool-0.2.3 [INFO] frobbed toml for lazy-pool-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy-pool/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazy-pool-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lazy-pool/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6c996e5becf094e2b1ab4fd605654a2b133785a67fef570db51ff3789a097cf [INFO] running `"docker" "start" "-a" "d6c996e5becf094e2b1ab4fd605654a2b133785a67fef570db51ff3789a097cf"` [INFO] [stderr] Checking lazy-pool v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.wrapped.take() { [INFO] [stderr] 155 | | Some(item) => self.pool.release(item), [INFO] [stderr] 156 | | None => (), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(item) = self.wrapped.take() { self.pool.release(item) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.wrapped.take() { [INFO] [stderr] 155 | | Some(item) => self.pool.release(item), [INFO] [stderr] 156 | | None => (), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(item) = self.wrapped.take() { self.pool.release(item) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:272:42 [INFO] [stderr] | [INFO] [stderr] 272 | let pool = Pool::new(3, Box::new(|| AnyObject::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AnyObject::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:309:48 [INFO] [stderr] | [INFO] [stderr] 309 | Self { pool: Pool::new(3, Box::new(|| AnyObject::new())) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AnyObject::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "d6c996e5becf094e2b1ab4fd605654a2b133785a67fef570db51ff3789a097cf"` [INFO] running `"docker" "rm" "-f" "d6c996e5becf094e2b1ab4fd605654a2b133785a67fef570db51ff3789a097cf"` [INFO] [stdout] d6c996e5becf094e2b1ab4fd605654a2b133785a67fef570db51ff3789a097cf