[INFO] crate lase 0.0.2 is already in cache [INFO] extracting crate lase 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/lase/0.0.2 [INFO] extracting crate lase 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lase/0.0.2 [INFO] validating manifest of lase-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lase-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lase-0.0.2 [INFO] finished frobbing lase-0.0.2 [INFO] frobbed toml for lase-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/lase/0.0.2/Cargo.toml [INFO] started frobbing lase-0.0.2 [INFO] finished frobbing lase-0.0.2 [INFO] frobbed toml for lase-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lase/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lase-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lase/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f0ecba438c8b9c4fa000937899c7d3ba7bbc513c66de040198fd67b9d668503 [INFO] running `"docker" "start" "-a" "9f0ecba438c8b9c4fa000937899c7d3ba7bbc513c66de040198fd67b9d668503"` [INFO] [stderr] Checking point v0.3.1 [INFO] [stderr] Checking ilda v0.0.2 [INFO] [stderr] Checking etherdream v0.1.1 [INFO] [stderr] Checking lase v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &Dac::Etherdream { ref dac } => Some(&dac.get_ip_address()), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | Dac::Etherdream { ref dac } => Some(&dac.get_ip_address()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 38 | | dac.play_function(make_points).map_err(|e| e.into()) [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 50 | | dac.stream_pipeline_points(make_points).map_err(|e| e.into()) [INFO] [stderr] 51 | | }, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match self { [INFO] [stderr] 61 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 62 | | dac.stream_simple_points(make_points).map_err(|e| e.into()) [INFO] [stderr] 63 | | }, [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ball.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &Dac::Etherdream { ref dac } => Some(&dac.get_ip_address()), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | Dac::Etherdream { ref dac } => Some(&dac.get_ip_address()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 38 | | dac.play_function(make_points).map_err(|e| e.into()) [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 50 | | dac.stream_pipeline_points(make_points).map_err(|e| e.into()) [INFO] [stderr] 51 | | }, [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dac.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match self { [INFO] [stderr] 61 | | &mut Dac::Etherdream { ref mut dac } => { [INFO] [stderr] 62 | | dac.stream_simple_points(make_points).map_err(|e| e.into()) [INFO] [stderr] 63 | | }, [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | Dac::Etherdream { ref mut dac } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `lase::Dac` [INFO] [stderr] --> examples/circle.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use lase::Dac; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `pos` should have an upper case name such as `POS` [INFO] [stderr] --> examples/circle.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | static mut pos: i32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/circle.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | let j = (f as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/circle.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let j = (f as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(DIV)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/circle.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | let j = (f as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/circle.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let x = j.cos() * ETHERDREAM_X_MAX as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ETHERDREAM_X_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/circle.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let y = j.sin() * ETHERDREAM_Y_MAX as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ETHERDREAM_Y_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `lase::Dac` [INFO] [stderr] --> examples/ball.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use lase::Dac; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `lase::tools::ETHERDREAM_Y_MAX` [INFO] [stderr] --> examples/ball.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use lase::tools::ETHERDREAM_Y_MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `lase::tools::ETHERDREAM_Y_MIN` [INFO] [stderr] --> examples/ball.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use lase::tools::ETHERDREAM_Y_MIN; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> examples/ball.rs:124:7 [INFO] [stderr] | [INFO] [stderr] 124 | thread::sleep_ms(10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `lase::Dac` [INFO] [stderr] --> examples/square.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use lase::Dac; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/ball.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | let mut circle = Arc::new(RwLock::new(Circle::new(8000))); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/ball.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | let mut circle2 = circle.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | let j = (*position as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(*position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | let j = (*position as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(DIV)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:58:49 [INFO] [stderr] | [INFO] [stderr] 58 | let j = (*position as f64 / DIV as f64) * 2 as f64 * PI; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | let x = j.cos() * self.radius as f64 + self.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.radius)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | let x = j.cos() * self.radius as f64 + self.x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | let y = j.sin() * self.radius as f64 + self.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.radius)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/ball.rs:60:46 [INFO] [stderr] | [INFO] [stderr] 60 | let y = j.sin() * self.radius as f64 + self.y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/ball.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | / dac.play_function(|num_points: u16| { [INFO] [stderr] 129 | | circle2.read().unwrap().get_points(num_points, &mut pos) [INFO] [stderr] 130 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/square.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | let j = i as f32 / samples as f32; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/square.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | let j = i as f32 / samples as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/square.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let half = side as f32 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(side)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/square.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let point = self.prototype.get(i).unwrap().clone(); // FIXME LAZINESS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.prototype.get(i).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/square.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let point = self.prototype.get(i).unwrap().clone(); // FIXME LAZINESS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.prototype[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/square.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pos = pos + (points.len() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos += (points.len() as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.70s [INFO] running `"docker" "inspect" "9f0ecba438c8b9c4fa000937899c7d3ba7bbc513c66de040198fd67b9d668503"` [INFO] running `"docker" "rm" "-f" "9f0ecba438c8b9c4fa000937899c7d3ba7bbc513c66de040198fd67b9d668503"` [INFO] [stdout] 9f0ecba438c8b9c4fa000937899c7d3ba7bbc513c66de040198fd67b9d668503