[INFO] crate lapjv 0.1.1 is already in cache [INFO] extracting crate lapjv 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lapjv/0.1.1 [INFO] extracting crate lapjv 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lapjv/0.1.1 [INFO] validating manifest of lapjv-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lapjv-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lapjv-0.1.1 [INFO] finished frobbing lapjv-0.1.1 [INFO] frobbed toml for lapjv-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lapjv/0.1.1/Cargo.toml [INFO] started frobbing lapjv-0.1.1 [INFO] finished frobbing lapjv-0.1.1 [INFO] frobbed toml for lapjv-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lapjv/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lapjv-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lapjv/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2922b86183e47a9e7ba20256b3c77385f176f99645422d9e1d14c2561cd91cc [INFO] running `"docker" "start" "-a" "e2922b86183e47a9e7ba20256b3c77385f176f99645422d9e1d14c2561cd91cc"` [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling lapjv v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:456:22 [INFO] [stderr] | [INFO] [stderr] 456 | let m = vec![849.096136535884, 964.7344199800348, 1658.3745235461179, 1324.4750426251608, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `849.096_136_535_884` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:456:40 [INFO] [stderr] | [INFO] [stderr] 456 | let m = vec![849.096136535884, 964.7344199800348, 1658.3745235461179, 1324.4750426251608, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `964.734_419_980_034_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:456:59 [INFO] [stderr] | [INFO] [stderr] 456 | let m = vec![849.096136535884, 964.7344199800348, 1658.3745235461179, 1324.4750426251608, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_658.374_523_546_117_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:456:79 [INFO] [stderr] | [INFO] [stderr] 456 | let m = vec![849.096136535884, 964.7344199800348, 1658.3745235461179, 1324.4750426251608, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_324.475_042_625_160_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:457:13 [INFO] [stderr] | [INFO] [stderr] 457 | 1565.0473271789378, 1777.6465563492143, 4280.139067225529, 3411.9521087119633, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_565.047_327_178_937_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:457:33 [INFO] [stderr] | [INFO] [stderr] 457 | 1565.0473271789378, 1777.6465563492143, 4280.139067225529, 3411.9521087119633, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_777.646_556_349_214_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:457:53 [INFO] [stderr] | [INFO] [stderr] 457 | 1565.0473271789378, 1777.6465563492143, 4280.139067225529, 3411.9521087119633, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `4_280.139_067_225_529` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:457:72 [INFO] [stderr] | [INFO] [stderr] 457 | 1565.0473271789378, 1777.6465563492143, 4280.139067225529, 3411.9521087119633, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3_411.952_108_711_963_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | 1360.3260879628992, 1546.701932942709, 1304.724155636392, 1048.3839719313205, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_360.326_087_962_899_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:33 [INFO] [stderr] | [INFO] [stderr] 458 | 1360.3260879628992, 1546.701932942709, 1304.724155636392, 1048.3839719313205, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_546.701_932_942_709` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:52 [INFO] [stderr] | [INFO] [stderr] 458 | 1360.3260879628992, 1546.701932942709, 1304.724155636392, 1048.3839719313205, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_304.724_155_636_392` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:71 [INFO] [stderr] | [INFO] [stderr] 458 | 1360.3260879628992, 1546.701932942709, 1304.724155636392, 1048.3839719313205, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_048.383_971_931_320_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | 1559.5777872153571, 1769.1684309771547, 3663.2542984837355, 2926.089718214265]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_559.577_787_215_357_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:33 [INFO] [stderr] | [INFO] [stderr] 459 | 1559.5777872153571, 1769.1684309771547, 3663.2542984837355, 2926.089718214265]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1_769.168_430_977_154_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:53 [INFO] [stderr] | [INFO] [stderr] 459 | 1559.5777872153571, 1769.1684309771547, 3663.2542984837355, 2926.089718214265]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3_663.254_298_483_735_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:73 [INFO] [stderr] | [INFO] [stderr] 459 | 1559.5777872153571, 1769.1684309771547, 3663.2542984837355, 2926.089718214265]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2_926.089_718_214_265` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | (0..row.len()).into_iter().fold(T::zero(), |acc, i| acc + input[(i, row[i])]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..row.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for j in (0..self.dim).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..self.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pred` [INFO] [stderr] --> src/lib.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | for i in 0..dim { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 242 | for (i, ) in pred.iter_mut().enumerate().take(dim) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/lib.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | hi += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/lib.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | hi += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | (0..row.len()).into_iter().fold(T::zero(), |acc, i| acc + input[(i, row[i])]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..row.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for j in (0..self.dim).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..self.dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pred` [INFO] [stderr] --> src/lib.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | for i in 0..dim { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 242 | for (i, ) in pred.iter_mut().enumerate().take(dim) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/lib.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | hi += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/lib.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | hi += 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | assert_eq!(cost, 1071.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | assert_eq!(cost, 1071.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | assert_eq!(cost, 1403.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | assert_eq!(cost, 1403.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:416:49 [INFO] [stderr] | [INFO] [stderr] 416 | let result = find_umins_plain(m.row(0), &vec![0.0,0.0,0.0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0.0,0.0,0.0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lapjv`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e2922b86183e47a9e7ba20256b3c77385f176f99645422d9e1d14c2561cd91cc"` [INFO] running `"docker" "rm" "-f" "e2922b86183e47a9e7ba20256b3c77385f176f99645422d9e1d14c2561cd91cc"` [INFO] [stdout] e2922b86183e47a9e7ba20256b3c77385f176f99645422d9e1d14c2561cd91cc