[INFO] crate lamcal-repl 0.4.0 is already in cache [INFO] extracting crate lamcal-repl 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/lamcal-repl/0.4.0 [INFO] extracting crate lamcal-repl 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lamcal-repl/0.4.0 [INFO] validating manifest of lamcal-repl-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lamcal-repl-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lamcal-repl-0.4.0 [INFO] finished frobbing lamcal-repl-0.4.0 [INFO] frobbed toml for lamcal-repl-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/lamcal-repl/0.4.0/Cargo.toml [INFO] started frobbing lamcal-repl-0.4.0 [INFO] finished frobbing lamcal-repl-0.4.0 [INFO] frobbed toml for lamcal-repl-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lamcal-repl/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lamcal-repl-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lamcal-repl/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fe5187d12adcaf7596c0bd6b9cf6c5e578b0199d8ba4b95d9487d47c615dd77 [INFO] running `"docker" "start" "-a" "6fe5187d12adcaf7596c0bd6b9cf6c5e578b0199d8ba4b95d9487d47c615dd77"` [INFO] [stderr] Checking lamcal v0.4.0 [INFO] [stderr] Checking lamcal-repl v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | cont_output(format!("Environment cleared"), "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Environment cleared".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | cont_output(format!("Loaded default bindings into environment"), "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Loaded default bindings into environment".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | cont_output(format!("Environment cleared"), "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Environment cleared".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | cont_output(format!("Loaded default bindings into environment"), "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Loaded default bindings into environment".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/let_stmt.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | while let Some(chr) = chr_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for chr in chr_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/let_stmt.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | while let Some(chr) = chr_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for chr in chr_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.59s [INFO] running `"docker" "inspect" "6fe5187d12adcaf7596c0bd6b9cf6c5e578b0199d8ba4b95d9487d47c615dd77"` [INFO] running `"docker" "rm" "-f" "6fe5187d12adcaf7596c0bd6b9cf6c5e578b0199d8ba4b95d9487d47c615dd77"` [INFO] [stdout] 6fe5187d12adcaf7596c0bd6b9cf6c5e578b0199d8ba4b95d9487d47c615dd77