[INFO] crate lamcal 0.4.0 is already in cache [INFO] extracting crate lamcal 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/lamcal/0.4.0 [INFO] extracting crate lamcal 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lamcal/0.4.0 [INFO] validating manifest of lamcal-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lamcal-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lamcal-0.4.0 [INFO] finished frobbing lamcal-0.4.0 [INFO] frobbed toml for lamcal-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/lamcal/0.4.0/Cargo.toml [INFO] started frobbing lamcal-0.4.0 [INFO] finished frobbing lamcal-0.4.0 [INFO] frobbed toml for lamcal-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lamcal/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lamcal-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lamcal/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a3c3284850f3d34cacde4993bd546b59b043d970ed3ec97cfaca8b6e4af31c6 [INFO] running `"docker" "start" "-a" "6a3c3284850f3d34cacde4993bd546b59b043d970ed3ec97cfaca8b6e4af31c6"` [INFO] [stderr] Checking lamcal v0.4.0 (/opt/crater/workdir) [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/reduction/mod.rs:768:38 [INFO] [stderr] | [INFO] [stderr] 768 | pub fn alpha(expr: &Term, names: &HashSet<&VarName>) -> Term [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 768 | pub fn alpha(expr: &Term, names: &HashSet<&VarName, S>) -> Term [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashSet [INFO] [stderr] --> src/reduction/mod.rs:783:14 [INFO] [stderr] | [INFO] [stderr] 783 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/reduction/mod.rs:768:38 [INFO] [stderr] | [INFO] [stderr] 768 | pub fn alpha(expr: &Term, names: &HashSet<&VarName>) -> Term [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 768 | pub fn alpha(expr: &Term, names: &HashSet<&VarName, S>) -> Term [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashSet [INFO] [stderr] --> src/reduction/mod.rs:783:14 [INFO] [stderr] | [INFO] [stderr] 783 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `&` [INFO] [stderr] --> src/inspect/tests.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(Stop::No & Stop::No, Stop::No); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `&` [INFO] [stderr] --> src/inspect/tests.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(Stop::Yes & Stop::Yes, Stop::Yes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `|` [INFO] [stderr] --> src/inspect/tests.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(Stop::No | Stop::No, Stop::No); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `|` [INFO] [stderr] --> src/inspect/tests.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | assert_eq!(Stop::Yes | Stop::Yes, Stop::Yes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/tests.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | let input = format!("{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/tests.rs:424:25 [INFO] [stderr] | [INFO] [stderr] 424 | let input = format!("{}", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lamcal`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6a3c3284850f3d34cacde4993bd546b59b043d970ed3ec97cfaca8b6e4af31c6"` [INFO] running `"docker" "rm" "-f" "6a3c3284850f3d34cacde4993bd546b59b043d970ed3ec97cfaca8b6e4af31c6"` [INFO] [stdout] 6a3c3284850f3d34cacde4993bd546b59b043d970ed3ec97cfaca8b6e4af31c6