[INFO] crate lalrpop-intern 0.15.1 is already in cache [INFO] extracting crate lalrpop-intern 0.15.1 into work/ex/clippy-test-run/sources/stable/reg/lalrpop-intern/0.15.1 [INFO] extracting crate lalrpop-intern 0.15.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lalrpop-intern/0.15.1 [INFO] validating manifest of lalrpop-intern-0.15.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lalrpop-intern-0.15.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lalrpop-intern-0.15.1 [INFO] finished frobbing lalrpop-intern-0.15.1 [INFO] frobbed toml for lalrpop-intern-0.15.1 written to work/ex/clippy-test-run/sources/stable/reg/lalrpop-intern/0.15.1/Cargo.toml [INFO] started frobbing lalrpop-intern-0.15.1 [INFO] finished frobbing lalrpop-intern-0.15.1 [INFO] frobbed toml for lalrpop-intern-0.15.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lalrpop-intern/0.15.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lalrpop-intern-0.15.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lalrpop-intern/0.15.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46769fff4bd25866ee89d2495b643ab4ca8a1f9e0d7b5058fd3b33aa69169161 [INFO] running `"docker" "start" "-a" "46769fff4bd25866ee89d2495b643ab4ca8a1f9e0d7b5058fd3b33aa69169161"` [INFO] [stderr] Checking lalrpop-intern v0.15.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | let result = InternedString { index: index }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | let result = InternedString { index: index }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match interner.map.get(s) { [INFO] [stderr] 27 | | Some(&v) => { [INFO] [stderr] 28 | | return v; [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | None => {} [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(&v) = interner.map.get(s) { [INFO] [stderr] 27 | return v; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `InternedString` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl InternedString { [INFO] [stderr] 69 | | fn index(&self) -> usize { [INFO] [stderr] 70 | | self.index as usize [INFO] [stderr] 71 | | } [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | fn index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match interner.map.get(s) { [INFO] [stderr] 27 | | Some(&v) => { [INFO] [stderr] 28 | | return v; [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | None => {} [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(&v) = interner.map.get(s) { [INFO] [stderr] 27 | return v; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `InternedString` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / impl InternedString { [INFO] [stderr] 69 | | fn index(&self) -> usize { [INFO] [stderr] 70 | | self.index as usize [INFO] [stderr] 71 | | } [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | fn index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "46769fff4bd25866ee89d2495b643ab4ca8a1f9e0d7b5058fd3b33aa69169161"` [INFO] running `"docker" "rm" "-f" "46769fff4bd25866ee89d2495b643ab4ca8a1f9e0d7b5058fd3b33aa69169161"` [INFO] [stdout] 46769fff4bd25866ee89d2495b643ab4ca8a1f9e0d7b5058fd3b33aa69169161