[INFO] crate lagraph 0.2.1 is already in cache [INFO] extracting crate lagraph 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/lagraph/0.2.1 [INFO] extracting crate lagraph 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lagraph/0.2.1 [INFO] validating manifest of lagraph-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lagraph-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lagraph-0.2.1 [INFO] finished frobbing lagraph-0.2.1 [INFO] frobbed toml for lagraph-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/lagraph/0.2.1/Cargo.toml [INFO] started frobbing lagraph-0.2.1 [INFO] finished frobbing lagraph-0.2.1 [INFO] frobbed toml for lagraph-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lagraph/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lagraph-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lagraph/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a10fec4ba0c12acf57d89b45750fc770097feb5e36fcb9fb24a87573989ff1be [INFO] running `"docker" "start" "-a" "a10fec4ba0c12acf57d89b45750fc770097feb5e36fcb9fb24a87573989ff1be"` [INFO] [stderr] Checking lagraph v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / fn main() { [INFO] [stderr] 22 | | let yaml = load_yaml!("cli.yml"); [INFO] [stderr] 23 | | let matches = App::from_yaml(yaml).get_matches(); [INFO] [stderr] 24 | | [INFO] [stderr] ... | [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | let finite = if count != 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `count != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:52 [INFO] [stderr] | [INFO] [stderr] 52 | let style = value_t!(matches, "style", String).unwrap_or(String::from("bar")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("bar"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:97:52 [INFO] [stderr] | [INFO] [stderr] 97 | let color = value_t!(matches, "color", String).unwrap_or(String::from(color_default)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(color_default))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | w as u32 - 12 [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / let draw_cap; [INFO] [stderr] 189 | | if max_ping <= width || number_of_bars >= (width) as usize { [INFO] [stderr] 190 | | draw_cap = false; [INFO] [stderr] 191 | | } else { [INFO] [stderr] 192 | | draw_cap = true; [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let draw_cap = if max_ping <= width || number_of_bars >= (width) as usize { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | / let cap; [INFO] [stderr] 196 | | // Draw a cap for sub-character precision [INFO] [stderr] 197 | | if draw_cap && ping >= bar_ping_half && ping < bar_ping_next { [INFO] [stderr] 198 | | // There should be a cap [INFO] [stderr] ... | [INFO] [stderr] 202 | | cap = ""; [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let cap = if draw_cap && ping >= bar_ping_half && ping < bar_ping_next { cap_half_character } else { "" };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | .split("=") [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:49 [INFO] [stderr] | [INFO] [stderr] 215 | (255.0 + (512.0 - 2.0 * desaturation as f32) * (ratio - 0.5)) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:223:47 [INFO] [stderr] | [INFO] [stderr] 223 | (255.0 - (512.0 - desaturation as f32 * 2.0) * (ratio - 0.5)) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | desaturation as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | let bar = [ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:255:56 [INFO] [stderr] | [INFO] [stderr] 255 | value_t!(matches, "timestamp", String).unwrap_or(String::from("none")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("none"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / fn main() { [INFO] [stderr] 22 | | let yaml = load_yaml!("cli.yml"); [INFO] [stderr] 23 | | let matches = App::from_yaml(yaml).get_matches(); [INFO] [stderr] 24 | | [INFO] [stderr] ... | [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | let finite = if count != 0 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `count != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:52:52 [INFO] [stderr] | [INFO] [stderr] 52 | let style = value_t!(matches, "style", String).unwrap_or(String::from("bar")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("bar"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:97:52 [INFO] [stderr] | [INFO] [stderr] 97 | let color = value_t!(matches, "color", String).unwrap_or(String::from(color_default)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(color_default))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | w as u32 - 12 [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / let draw_cap; [INFO] [stderr] 189 | | if max_ping <= width || number_of_bars >= (width) as usize { [INFO] [stderr] 190 | | draw_cap = false; [INFO] [stderr] 191 | | } else { [INFO] [stderr] 192 | | draw_cap = true; [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let draw_cap = if max_ping <= width || number_of_bars >= (width) as usize { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | / let cap; [INFO] [stderr] 196 | | // Draw a cap for sub-character precision [INFO] [stderr] 197 | | if draw_cap && ping >= bar_ping_half && ping < bar_ping_next { [INFO] [stderr] 198 | | // There should be a cap [INFO] [stderr] ... | [INFO] [stderr] 202 | | cap = ""; [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let cap = if draw_cap && ping >= bar_ping_half && ping < bar_ping_next { cap_half_character } else { "" };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | .split("=") [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:49 [INFO] [stderr] | [INFO] [stderr] 215 | (255.0 + (512.0 - 2.0 * desaturation as f32) * (ratio - 0.5)) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:223:47 [INFO] [stderr] | [INFO] [stderr] 223 | (255.0 - (512.0 - desaturation as f32 * 2.0) * (ratio - 0.5)) as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | desaturation as i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(desaturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | let bar = [ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:255:56 [INFO] [stderr] | [INFO] [stderr] 255 | value_t!(matches, "timestamp", String).unwrap_or(String::from("none")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("none"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `"docker" "inspect" "a10fec4ba0c12acf57d89b45750fc770097feb5e36fcb9fb24a87573989ff1be"` [INFO] running `"docker" "rm" "-f" "a10fec4ba0c12acf57d89b45750fc770097feb5e36fcb9fb24a87573989ff1be"` [INFO] [stdout] a10fec4ba0c12acf57d89b45750fc770097feb5e36fcb9fb24a87573989ff1be