[INFO] crate ladspa_noisecoring 1.0.0 is already in cache [INFO] extracting crate ladspa_noisecoring 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/ladspa_noisecoring/1.0.0 [INFO] extracting crate ladspa_noisecoring 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ladspa_noisecoring/1.0.0 [INFO] validating manifest of ladspa_noisecoring-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ladspa_noisecoring-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ladspa_noisecoring-1.0.0 [INFO] finished frobbing ladspa_noisecoring-1.0.0 [INFO] frobbed toml for ladspa_noisecoring-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/ladspa_noisecoring/1.0.0/Cargo.toml [INFO] started frobbing ladspa_noisecoring-1.0.0 [INFO] finished frobbing ladspa_noisecoring-1.0.0 [INFO] frobbed toml for ladspa_noisecoring-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ladspa_noisecoring/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ladspa_noisecoring-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ladspa_noisecoring/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 950ec9b03785cf0ec61ac2ebf870d0a896ac281d2aa6aaf035edc1afee333c51 [INFO] running `"docker" "start" "-a" "950ec9b03785cf0ec61ac2ebf870d0a896ac281d2aa6aaf035edc1afee333c51"` [INFO] [stderr] Checking ladspa v0.3.4 [INFO] [stderr] Checking rustfft v2.1.0 [INFO] [stderr] Checking ladspa_noisecoring v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:289:31 [INFO] [stderr] | [INFO] [stderr] 289 | = self.fft_output[1 .. dilation_radius+1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=dilation_radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:303:34 [INFO] [stderr] | [INFO] [stderr] 303 | = self.fft_output[start+1 .. end+1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start+1..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | self.fft_output[self.filter_length/2 [INFO] [stderr] | __________________________^ [INFO] [stderr] 351 | | .. full_size-self.filter_length/2+1] [INFO] [stderr] | |____________________________________________________________^ help: use: `self.filter_length/2..=full_size-self.filter_length/2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:522:24 [INFO] [stderr] | [INFO] [stderr] 522 | - (0 .. 1 + i/offset) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=i/offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:289:31 [INFO] [stderr] | [INFO] [stderr] 289 | = self.fft_output[1 .. dilation_radius+1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=dilation_radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:303:34 [INFO] [stderr] | [INFO] [stderr] 303 | = self.fft_output[start+1 .. end+1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start+1..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | self.fft_output[self.filter_length/2 [INFO] [stderr] | __________________________^ [INFO] [stderr] 351 | | .. full_size-self.filter_length/2+1] [INFO] [stderr] | |____________________________________________________________^ help: use: `self.filter_length/2..=full_size-self.filter_length/2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:522:24 [INFO] [stderr] | [INFO] [stderr] 522 | - (0 .. 1 + i/offset) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=i/offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.37s [INFO] running `"docker" "inspect" "950ec9b03785cf0ec61ac2ebf870d0a896ac281d2aa6aaf035edc1afee333c51"` [INFO] running `"docker" "rm" "-f" "950ec9b03785cf0ec61ac2ebf870d0a896ac281d2aa6aaf035edc1afee333c51"` [INFO] [stdout] 950ec9b03785cf0ec61ac2ebf870d0a896ac281d2aa6aaf035edc1afee333c51