[INFO] crate ladspa 0.3.4 is already in cache [INFO] extracting crate ladspa 0.3.4 into work/ex/clippy-test-run/sources/stable/reg/ladspa/0.3.4 [INFO] extracting crate ladspa 0.3.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ladspa/0.3.4 [INFO] validating manifest of ladspa-0.3.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ladspa-0.3.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ladspa-0.3.4 [INFO] finished frobbing ladspa-0.3.4 [INFO] frobbed toml for ladspa-0.3.4 written to work/ex/clippy-test-run/sources/stable/reg/ladspa/0.3.4/Cargo.toml [INFO] started frobbing ladspa-0.3.4 [INFO] finished frobbing ladspa-0.3.4 [INFO] frobbed toml for ladspa-0.3.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ladspa/0.3.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ladspa-0.3.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ladspa/0.3.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 950e0b5af6cbae9d89bd735d22aa3e78761c139c63f60a2871532a8f548f1ebb [INFO] running `"docker" "start" "-a" "950e0b5af6cbae9d89bd735d22aa3e78761c139c63f60a2871532a8f548f1ebb"` [INFO] [stderr] Checking ladspa v0.3.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | instantiate: instantiate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instantiate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | connect_port: connect_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connect_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | run: run, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `run` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | cleanup: cleanup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cleanup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | port_map: port_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `port_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | ports: ports, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | instantiate: instantiate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instantiate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | connect_port: connect_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connect_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | run: run, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `run` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | cleanup: cleanup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cleanup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | port_map: port_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `port_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | ports: ports, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/ffi.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if DESCRIPTORS == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/ffi.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | return mem::transmute(&*(*DESCRIPTORS)[index as usize]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(*DESCRIPTORS)[index as usize] as *const ffi::ladspa_h::Descriptor as *mut ffi::ladspa_h::Descriptor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ffi::ladspa_h::Descriptor`) to a reference type (`&mut ffi::ladspa_h::Descriptor`) [INFO] [stderr] --> src/ffi.rs:173:29 [INFO] [stderr] | [INFO] [stderr] 173 | drop_descriptor(mem::transmute(*desc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(*desc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/ffi.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / Vec::from_raw_parts(desc.port_names, [INFO] [stderr] 187 | | desc.port_count as usize, [INFO] [stderr] 188 | | desc.port_count as usize) [INFO] [stderr] 189 | | .iter() [INFO] [stderr] 190 | | .map(|&x| CString::from_raw(x)) [INFO] [stderr] 191 | | .collect::>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/ffi.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / Vec::from_raw_parts(desc.port_names, [INFO] [stderr] 187 | | desc.port_count as usize, [INFO] [stderr] 188 | | desc.port_count as usize) [INFO] [stderr] 189 | | .iter() [INFO] [stderr] 190 | | .map(|&x| CString::from_raw(x)) [INFO] [stderr] 191 | | .collect::>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const ffi::ladspa_h::Descriptor`) to a reference type (`&mut ffi::ladspa_h::Descriptor`) [INFO] [stderr] --> src/ffi.rs:210:47 [INFO] [stderr] | [INFO] [stderr] 210 | let desc: &mut ladspa_h::Descriptor = mem::transmute(descriptor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&'static PluginDescriptor`) [INFO] [stderr] --> src/ffi.rs:212:51 [INFO] [stderr] | [INFO] [stderr] 212 | let rust_desc: &super::PluginDescriptor = mem::transmute(desc.implementation_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(desc.implementation_data as *const PluginDescriptor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:234:35 [INFO] [stderr] | [INFO] [stderr] 234 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut f32`) to a reference type (`&f32`) [INFO] [stderr] --> src/ffi.rs:250:47 [INFO] [stderr] | [INFO] [stderr] 250 | super::PortData::ControlInput(mem::transmute(data_location)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*data_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut f32`) to a reference type (`&mut f32`) [INFO] [stderr] --> src/ffi.rs:253:61 [INFO] [stderr] | [INFO] [stderr] 253 | super::PortData::ControlOutput(RefCell::new(mem::transmute(data_location))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *data_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:265:39 [INFO] [stderr] | [INFO] [stderr] 265 | let handle_ptr: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:274:35 [INFO] [stderr] | [INFO] [stderr] 274 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:289:30 [INFO] [stderr] | [INFO] [stderr] 289 | call_user_code!(Some({ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 290 | | let ref mut handle = *handle; [INFO] [stderr] 291 | | handle.plugin.run(sample_count as usize, &handle.ports) [INFO] [stderr] 292 | | }), [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 289 | call_user_code!(Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ffi.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | let ref mut handle = *handle; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------- help: try: `let handle = &mut (*handle);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:299:35 [INFO] [stderr] | [INFO] [stderr] 299 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:301:30 [INFO] [stderr] | [INFO] [stderr] 301 | call_user_code!(Some(handle.plugin.activate()), "Plugin::activate"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 301 | call_user_code!(Some(()), "Plugin::activate"); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:306:35 [INFO] [stderr] | [INFO] [stderr] 306 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:308:30 [INFO] [stderr] | [INFO] [stderr] 308 | call_user_code!(Some(handle.plugin.deactivate()), "Plugin::deactivate"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 308 | call_user_code!(Some(()), "Plugin::deactivate"); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/ffi.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if DESCRIPTORS == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/ffi.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | return mem::transmute(&*(*DESCRIPTORS)[index as usize]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(*DESCRIPTORS)[index as usize] as *const ffi::ladspa_h::Descriptor as *mut ffi::ladspa_h::Descriptor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ffi::ladspa_h::Descriptor`) to a reference type (`&mut ffi::ladspa_h::Descriptor`) [INFO] [stderr] --> src/ffi.rs:173:29 [INFO] [stderr] | [INFO] [stderr] 173 | drop_descriptor(mem::transmute(*desc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(*desc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/ffi.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / Vec::from_raw_parts(desc.port_names, [INFO] [stderr] 187 | | desc.port_count as usize, [INFO] [stderr] 188 | | desc.port_count as usize) [INFO] [stderr] 189 | | .iter() [INFO] [stderr] 190 | | .map(|&x| CString::from_raw(x)) [INFO] [stderr] 191 | | .collect::>(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/ffi.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / Vec::from_raw_parts(desc.port_names, [INFO] [stderr] 187 | | desc.port_count as usize, [INFO] [stderr] 188 | | desc.port_count as usize) [INFO] [stderr] 189 | | .iter() [INFO] [stderr] 190 | | .map(|&x| CString::from_raw(x)) [INFO] [stderr] 191 | | .collect::>(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const ffi::ladspa_h::Descriptor`) to a reference type (`&mut ffi::ladspa_h::Descriptor`) [INFO] [stderr] --> src/ffi.rs:210:47 [INFO] [stderr] | [INFO] [stderr] 210 | let desc: &mut ladspa_h::Descriptor = mem::transmute(descriptor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&'static PluginDescriptor`) [INFO] [stderr] --> src/ffi.rs:212:51 [INFO] [stderr] | [INFO] [stderr] 212 | let rust_desc: &super::PluginDescriptor = mem::transmute(desc.implementation_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(desc.implementation_data as *const PluginDescriptor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:234:35 [INFO] [stderr] | [INFO] [stderr] 234 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut f32`) to a reference type (`&f32`) [INFO] [stderr] --> src/ffi.rs:250:47 [INFO] [stderr] | [INFO] [stderr] 250 | super::PortData::ControlInput(mem::transmute(data_location)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*data_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut f32`) to a reference type (`&mut f32`) [INFO] [stderr] --> src/ffi.rs:253:61 [INFO] [stderr] | [INFO] [stderr] 253 | super::PortData::ControlOutput(RefCell::new(mem::transmute(data_location))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *data_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:265:39 [INFO] [stderr] | [INFO] [stderr] 265 | let handle_ptr: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:274:35 [INFO] [stderr] | [INFO] [stderr] 274 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:289:30 [INFO] [stderr] | [INFO] [stderr] 289 | call_user_code!(Some({ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 290 | | let ref mut handle = *handle; [INFO] [stderr] 291 | | handle.plugin.run(sample_count as usize, &handle.ports) [INFO] [stderr] 292 | | }), [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 289 | call_user_code!(Some(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ffi.rs:290:33 [INFO] [stderr] | [INFO] [stderr] 290 | let ref mut handle = *handle; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------- help: try: `let handle = &mut (*handle);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:299:35 [INFO] [stderr] | [INFO] [stderr] 299 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:301:30 [INFO] [stderr] | [INFO] [stderr] 301 | call_user_code!(Some(handle.plugin.activate()), "Plugin::activate"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 301 | call_user_code!(Some(()), "Plugin::activate"); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut ffi::Handle<'_>`) [INFO] [stderr] --> src/ffi.rs:306:35 [INFO] [stderr] | [INFO] [stderr] 306 | let handle: &mut Handle = mem::transmute(instance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(instance as *mut ffi::Handle<'_>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ffi.rs:308:30 [INFO] [stderr] | [INFO] [stderr] 308 | call_user_code!(Some(handle.plugin.deactivate()), "Plugin::deactivate"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 308 | call_user_code!(Some(()), "Plugin::deactivate"); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.69s [INFO] running `"docker" "inspect" "950e0b5af6cbae9d89bd735d22aa3e78761c139c63f60a2871532a8f548f1ebb"` [INFO] running `"docker" "rm" "-f" "950e0b5af6cbae9d89bd735d22aa3e78761c139c63f60a2871532a8f548f1ebb"` [INFO] [stdout] 950e0b5af6cbae9d89bd735d22aa3e78761c139c63f60a2871532a8f548f1ebb