[INFO] crate lad 0.1.1 is already in cache
[INFO] extracting crate lad 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lad/0.1.1
[INFO] extracting crate lad 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lad/0.1.1
[INFO] validating manifest of lad-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lad-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lad-0.1.1
[INFO] finished frobbing lad-0.1.1
[INFO] frobbed toml for lad-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lad/0.1.1/Cargo.toml
[INFO] started frobbing lad-0.1.1
[INFO] finished frobbing lad-0.1.1
[INFO] frobbed toml for lad-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lad/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lad-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lad/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 05f0b026a3cdc26226163ec286609d41c2d8ba9a3d3dc21f166afa94bb6e24f0
[INFO] running `"docker" "start" "-a" "05f0b026a3cdc26226163ec286609d41c2d8ba9a3d3dc21f166afa94bb6e24f0"`
[INFO] [stderr]     Checking lad v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wad/mod.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wad/mod.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wad/mod.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wad/mod.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs::File`
[INFO] [stderr]   --> src/lib.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |         use std::fs::File;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Write`
[INFO] [stderr]   --> src/lib.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |         use std::io::Write;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `tmp_entry` is never read
[INFO] [stderr]   --> src/wad/mod.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let mut tmp_entry = DirEntry {
[INFO] [stderr]    |                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/wad/mod.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         (&h[0..]).read(&mut buf).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/wad/mod.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             (&d[i*size_of::<DirEntry>()..]).read(&mut buf).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/wad/mod.rs:71:35
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn get_entry(&self, name: &[u8;8]) -> Result<Vec<Vec<u8>>, WadError> {
[INFO] [stderr]    |                                   ^^^^^^^ help: consider passing by value instead: `[u8;8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/wad/mod.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if tmp.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tmp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/wad/mod.rs:85:48
[INFO] [stderr]    |
[INFO] [stderr] 85 |     pub unsafe fn get_entry_as<T>(&self, name: &[u8;8]) -> Result<Vec<&T>, WadError> {
[INFO] [stderr]    |                                                ^^^^^^^ help: consider passing by value instead: `[u8;8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] warning: value assigned to `tmp_entry` is never read
[INFO] [stderr]   --> src/wad/mod.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let mut tmp_entry = DirEntry {
[INFO] [stderr]    |                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `lad`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/wad/mod.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         (&h[0..]).read(&mut buf).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/wad/mod.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             (&d[i*size_of::<DirEntry>()..]).read(&mut buf).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/wad/mod.rs:71:35
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn get_entry(&self, name: &[u8;8]) -> Result<Vec<Vec<u8>>, WadError> {
[INFO] [stderr]    |                                   ^^^^^^^ help: consider passing by value instead: `[u8;8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/wad/mod.rs:79:12
[INFO] [stderr]    |
[INFO] [stderr] 79 |         if tmp.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tmp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/wad/mod.rs:85:48
[INFO] [stderr]    |
[INFO] [stderr] 85 |     pub unsafe fn get_entry_as<T>(&self, name: &[u8;8]) -> Result<Vec<&T>, WadError> {
[INFO] [stderr]    |                                                ^^^^^^^ help: consider passing by value instead: `[u8;8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `lad`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "05f0b026a3cdc26226163ec286609d41c2d8ba9a3d3dc21f166afa94bb6e24f0"`
[INFO] running `"docker" "rm" "-f" "05f0b026a3cdc26226163ec286609d41c2d8ba9a3d3dc21f166afa94bb6e24f0"`
[INFO] [stdout] 05f0b026a3cdc26226163ec286609d41c2d8ba9a3d3dc21f166afa94bb6e24f0