[INFO] crate kudubot-bindings 0.18.2 is already in cache [INFO] extracting crate kudubot-bindings 0.18.2 into work/ex/clippy-test-run/sources/stable/reg/kudubot-bindings/0.18.2 [INFO] extracting crate kudubot-bindings 0.18.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kudubot-bindings/0.18.2 [INFO] validating manifest of kudubot-bindings-0.18.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kudubot-bindings-0.18.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kudubot-bindings-0.18.2 [INFO] finished frobbing kudubot-bindings-0.18.2 [INFO] frobbed toml for kudubot-bindings-0.18.2 written to work/ex/clippy-test-run/sources/stable/reg/kudubot-bindings/0.18.2/Cargo.toml [INFO] started frobbing kudubot-bindings-0.18.2 [INFO] finished frobbing kudubot-bindings-0.18.2 [INFO] frobbed toml for kudubot-bindings-0.18.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kudubot-bindings/0.18.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kudubot-bindings-0.18.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kudubot-bindings/0.18.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45290c92eadca6826963c81b28c2239211639d2da4647e179d543982491cfda6 [INFO] running `"docker" "start" "-a" "45290c92eadca6826963c81b28c2239211639d2da4647e179d543982491cfda6"` [INFO] [stderr] Checking kudubot-bindings v0.18.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/structs.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return serde_json::to_string(&self).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(&self).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return serde_json::from_str(data.as_str()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::from_str(data.as_str()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / return Message { [INFO] [stderr] 75 | | message_title: String::from(title), [INFO] [stderr] 76 | | message_body: String::from(body), [INFO] [stderr] 77 | | receiver: receiver.clone(), [INFO] [stderr] ... | [INFO] [stderr] 80 | | timestamp: message.timestamp, [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | Message { [INFO] [stderr] 75 | message_title: String::from(title), [INFO] [stderr] 76 | message_body: String::from(body), [INFO] [stderr] 77 | receiver: receiver.clone(), [INFO] [stderr] 78 | sender: message.receiver.clone(), [INFO] [stderr] 79 | sender_group: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/structs.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return serde_json::to_string(&self).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(&self).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return serde_json::from_str(data.as_str()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::from_str(data.as_str()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / return Message { [INFO] [stderr] 75 | | message_title: String::from(title), [INFO] [stderr] 76 | | message_body: String::from(body), [INFO] [stderr] 77 | | receiver: receiver.clone(), [INFO] [stderr] ... | [INFO] [stderr] 80 | | timestamp: message.timestamp, [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | Message { [INFO] [stderr] 75 | message_title: String::from(title), [INFO] [stderr] 76 | message_body: String::from(body), [INFO] [stderr] 77 | receiver: receiver.clone(), [INFO] [stderr] 78 | sender: message.receiver.clone(), [INFO] [stderr] 79 | sender_group: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "45290c92eadca6826963c81b28c2239211639d2da4647e179d543982491cfda6"` [INFO] running `"docker" "rm" "-f" "45290c92eadca6826963c81b28c2239211639d2da4647e179d543982491cfda6"` [INFO] [stdout] 45290c92eadca6826963c81b28c2239211639d2da4647e179d543982491cfda6