[INFO] crate kubewatch 0.9.2 is already in cache [INFO] extracting crate kubewatch 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/kubewatch/0.9.2 [INFO] extracting crate kubewatch 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kubewatch/0.9.2 [INFO] validating manifest of kubewatch-0.9.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kubewatch-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kubewatch-0.9.2 [INFO] finished frobbing kubewatch-0.9.2 [INFO] frobbed toml for kubewatch-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/kubewatch/0.9.2/Cargo.toml [INFO] started frobbing kubewatch-0.9.2 [INFO] finished frobbing kubewatch-0.9.2 [INFO] frobbed toml for kubewatch-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kubewatch/0.9.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kubewatch-0.9.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kubewatch/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97f752908013b5e0b92fe339c23865bf9385b3faaad0fe9224cb4e22d25e4c82 [INFO] running `"docker" "start" "-a" "97f752908013b5e0b92fe339c23865bf9385b3faaad0fe9224cb4e22d25e4c82"` [INFO] [stderr] Checking kubewatch v0.9.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | if let Err(_) = tx.send(event.map_err(Error::DeserializationFailed)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 94 | | break; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________- help: try this: `if tx.send(event.map_err(Error::DeserializationFailed)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:93:20 [INFO] [stderr] | [INFO] [stderr] 93 | if let Err(_) = tx.send(event.map_err(Error::DeserializationFailed)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 94 | | break; [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________- help: try this: `if tx.send(event.map_err(Error::DeserializationFailed)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:147:60 [INFO] [stderr] | [INFO] [stderr] 147 | Ok(self.generator(self.bytes().into_iter().map(|b| Ok(b)))) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:147:31 [INFO] [stderr] | [INFO] [stderr] 147 | Ok(self.generator(self.bytes().into_iter().map(|b| Ok(b)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.bytes()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.59s [INFO] running `"docker" "inspect" "97f752908013b5e0b92fe339c23865bf9385b3faaad0fe9224cb4e22d25e4c82"` [INFO] running `"docker" "rm" "-f" "97f752908013b5e0b92fe339c23865bf9385b3faaad0fe9224cb4e22d25e4c82"` [INFO] [stdout] 97f752908013b5e0b92fe339c23865bf9385b3faaad0fe9224cb4e22d25e4c82