[INFO] crate kubeclient 0.1.0 is already in cache [INFO] extracting crate kubeclient 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kubeclient/0.1.0 [INFO] extracting crate kubeclient 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kubeclient/0.1.0 [INFO] validating manifest of kubeclient-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kubeclient-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kubeclient-0.1.0 [INFO] finished frobbing kubeclient-0.1.0 [INFO] frobbed toml for kubeclient-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kubeclient/0.1.0/Cargo.toml [INFO] started frobbing kubeclient-0.1.0 [INFO] finished frobbing kubeclient-0.1.0 [INFO] frobbed toml for kubeclient-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kubeclient/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kubeclient-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kubeclient/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f427126734fc28aacb10fcc7d673c8571be2f53173729fd8985567d6c4b98e60 [INFO] running `"docker" "start" "-a" "f427126734fc28aacb10fcc7d673c8571be2f53173729fd8985567d6c4b98e60"` [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking kubeclient v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .unwrap_or("/root".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/root".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clients/low_level.rs:153:52 [INFO] [stderr] | [INFO] [stderr] 153 | let root = if mini.api_version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clients/low_level.rs:203:52 [INFO] [stderr] | [INFO] [stderr] 203 | let root = if mini.api_version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/clients/mod.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | / fn get_ns<'a, R: Resource>(&'a self) -> Option<&'a str> { [INFO] [stderr] 290 | | match self.namespace { [INFO] [stderr] 291 | | Some(ref ns) => Some(ns), [INFO] [stderr] 292 | | None => R::default_namespace(), [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/clients/mod.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | / match self.namespace { [INFO] [stderr] 291 | | Some(ref ns) => Some(ns), [INFO] [stderr] 292 | | None => R::default_namespace(), [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ help: try this: `self.namespace.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .unwrap_or("/root".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/root".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clients/low_level.rs:153:52 [INFO] [stderr] | [INFO] [stderr] 153 | let root = if mini.api_version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/clients/low_level.rs:203:52 [INFO] [stderr] | [INFO] [stderr] 203 | let root = if mini.api_version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/clients/mod.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | / fn get_ns<'a, R: Resource>(&'a self) -> Option<&'a str> { [INFO] [stderr] 290 | | match self.namespace { [INFO] [stderr] 291 | | Some(ref ns) => Some(ns), [INFO] [stderr] 292 | | None => R::default_namespace(), [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/clients/mod.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | / match self.namespace { [INFO] [stderr] 291 | | Some(ref ns) => Some(ns), [INFO] [stderr] 292 | | None => R::default_namespace(), [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ help: try this: `self.namespace.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.31s [INFO] running `"docker" "inspect" "f427126734fc28aacb10fcc7d673c8571be2f53173729fd8985567d6c4b98e60"` [INFO] running `"docker" "rm" "-f" "f427126734fc28aacb10fcc7d673c8571be2f53173729fd8985567d6c4b98e60"` [INFO] [stdout] f427126734fc28aacb10fcc7d673c8571be2f53173729fd8985567d6c4b98e60