[INFO] crate ktmpl 0.8.0 is already in cache
[INFO] extracting crate ktmpl 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/ktmpl/0.8.0
[INFO] extracting crate ktmpl 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ktmpl/0.8.0
[INFO] validating manifest of ktmpl-0.8.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ktmpl-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ktmpl-0.8.0
[INFO] finished frobbing ktmpl-0.8.0
[INFO] frobbed toml for ktmpl-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/ktmpl/0.8.0/Cargo.toml
[INFO] started frobbing ktmpl-0.8.0
[INFO] finished frobbing ktmpl-0.8.0
[INFO] frobbed toml for ktmpl-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ktmpl/0.8.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ktmpl-0.8.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ktmpl/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0be67e00758bdf5c4223d4b547eaf2dc5194df6933da98331574b7ee2d7b6066
[INFO] running `"docker" "start" "-a" "0be67e00758bdf5c4223d4b547eaf2dc5194df6933da98331574b7ee2d7b6066"`
[INFO] [stderr]     Checking ktmpl v0.8.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:161:13
[INFO] [stderr]     |
[INFO] [stderr] 161 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             display_name: display_name,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:163:13
[INFO] [stderr]     |
[INFO] [stderr] 163 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             parameter_type: parameter_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:165:13
[INFO] [stderr]     |
[INFO] [stderr] 165 |             required: required,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `required`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/template.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             param_map: param_map,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_map`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:161:13
[INFO] [stderr]     |
[INFO] [stderr] 161 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             display_name: display_name,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:163:13
[INFO] [stderr]     |
[INFO] [stderr] 163 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             parameter_type: parameter_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:165:13
[INFO] [stderr]     |
[INFO] [stderr] 165 |             required: required,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `required`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parameter.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/template.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 |             param_map: param_map,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `param_map`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/template.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             secrets: secrets,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `secrets`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/template.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 |         name: name,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/template.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         namespace: namespace,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/template.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             secrets: secrets,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `secrets`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/template.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 |         name: name,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/template.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         namespace: namespace,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/template.rs:185:5
[INFO] [stderr]     |
[INFO] [stderr] 185 |     return Ok(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/template.rs:185:5
[INFO] [stderr]     |
[INFO] [stderr] 185 |     return Ok(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/processor.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     match yaml {
[INFO] [stderr] 9  | |         &mut Yaml::Array(ref mut array) => process_array(array, parameters),
[INFO] [stderr] 10 | |         &mut Yaml::Hash(ref mut hash) => process_hash(hash, parameters),
[INFO] [stderr] 11 | |         &mut Yaml::String(ref mut string) => process_string(string, parameters),
[INFO] [stderr] 12 | |         _ => None,
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 8  |     match *yaml {
[INFO] [stderr] 9  |         Yaml::Array(ref mut array) => process_array(array, parameters),
[INFO] [stderr] 10 |         Yaml::Hash(ref mut hash) => process_hash(hash, parameters),
[INFO] [stderr] 11 |         Yaml::String(ref mut string) => process_string(string, parameters),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/processor.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match process_yaml(value, parameters) {
[INFO] [stderr] 19 | |             Some(new_value) => *value = new_value,
[INFO] [stderr] 20 | |             _ => {},
[INFO] [stderr] 21 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(new_value) = process_yaml(value, parameters) { *value = new_value }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/processor.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         match process_yaml(value, parameters) {
[INFO] [stderr] 30 | |             Some(new_value) => *value = new_value,
[INFO] [stderr] 31 | |             _ => {},
[INFO] [stderr] 32 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(new_value) = process_yaml(value, parameters) { *value = new_value }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/processor.rs:55:56
[INFO] [stderr]    |
[INFO] [stderr] 55 |             Some(parameter) => parameter.value.clone().unwrap_or("~".to_owned()),
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "~".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/processor.rs:66:39
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let contains_string_replacement = &final_replacement != &replacement;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let contains_string_replacement = final_replacement != replacement;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:118:16
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let hash = match object {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 119 | |         &mut Yaml::Hash(ref mut hash) => hash,
[INFO] [stderr] 120 | |         _ => return Ok(false),
[INFO] [stderr] 121 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let hash = match *object {
[INFO] [stderr] 119 |         Yaml::Hash(ref mut hash) => hash,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 | /         match kind {
[INFO] [stderr] 125 | |             &Yaml::String(ref kind_string) => {
[INFO] [stderr] 126 | |                 if kind_string != "Secret" {
[INFO] [stderr] 127 | |                     return Ok(false);
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             ),
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 124 |         match *kind {
[INFO] [stderr] 125 |             Yaml::String(ref kind_string) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 | /             match data {
[INFO] [stderr] 174 | |                 &mut Yaml::Hash(ref mut data_hash) => {
[INFO] [stderr] 175 | |                     base64_encode_secret_data(data_hash)?;
[INFO] [stderr] 176 | |                     return Ok(true);
[INFO] [stderr] ...   |
[INFO] [stderr] 180 | |                 ),
[INFO] [stderr] 181 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 173 |             match *data {
[INFO] [stderr] 174 |                 Yaml::Hash(ref mut data_hash) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:189:23
[INFO] [stderr]     |
[INFO] [stderr] 189 |           let encoded = match value {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 190 | |             &mut Yaml::String(ref value_string) => encode(value_string.as_bytes()),
[INFO] [stderr] 191 | |             _ => return Err("Encountered non-string secret data value.".to_string()),
[INFO] [stderr] 192 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |         let encoded = match *value {
[INFO] [stderr] 190 |             Yaml::String(ref value_string) => encode(value_string.as_bytes()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/processor.rs:8:5
[INFO] [stderr]    |
[INFO] [stderr] 8  | /     match yaml {
[INFO] [stderr] 9  | |         &mut Yaml::Array(ref mut array) => process_array(array, parameters),
[INFO] [stderr] 10 | |         &mut Yaml::Hash(ref mut hash) => process_hash(hash, parameters),
[INFO] [stderr] 11 | |         &mut Yaml::String(ref mut string) => process_string(string, parameters),
[INFO] [stderr] 12 | |         _ => None,
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 8  |     match *yaml {
[INFO] [stderr] 9  |         Yaml::Array(ref mut array) => process_array(array, parameters),
[INFO] [stderr] 10 |         Yaml::Hash(ref mut hash) => process_hash(hash, parameters),
[INFO] [stderr] 11 |         Yaml::String(ref mut string) => process_string(string, parameters),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/processor.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match process_yaml(value, parameters) {
[INFO] [stderr] 19 | |             Some(new_value) => *value = new_value,
[INFO] [stderr] 20 | |             _ => {},
[INFO] [stderr] 21 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(new_value) = process_yaml(value, parameters) { *value = new_value }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/processor.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         match process_yaml(value, parameters) {
[INFO] [stderr] 30 | |             Some(new_value) => *value = new_value,
[INFO] [stderr] 31 | |             _ => {},
[INFO] [stderr] 32 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(new_value) = process_yaml(value, parameters) { *value = new_value }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/processor.rs:55:56
[INFO] [stderr]    |
[INFO] [stderr] 55 |             Some(parameter) => parameter.value.clone().unwrap_or("~".to_owned()),
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "~".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/processor.rs:66:39
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let contains_string_replacement = &final_replacement != &replacement;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let contains_string_replacement = final_replacement != replacement;
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:118:16
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let hash = match object {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 119 | |         &mut Yaml::Hash(ref mut hash) => hash,
[INFO] [stderr] 120 | |         _ => return Ok(false),
[INFO] [stderr] 121 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let hash = match *object {
[INFO] [stderr] 119 |         Yaml::Hash(ref mut hash) => hash,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 | /         match kind {
[INFO] [stderr] 125 | |             &Yaml::String(ref kind_string) => {
[INFO] [stderr] 126 | |                 if kind_string != "Secret" {
[INFO] [stderr] 127 | |                     return Ok(false);
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             ),
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 124 |         match *kind {
[INFO] [stderr] 125 |             Yaml::String(ref kind_string) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 | /             match data {
[INFO] [stderr] 174 | |                 &mut Yaml::Hash(ref mut data_hash) => {
[INFO] [stderr] 175 | |                     base64_encode_secret_data(data_hash)?;
[INFO] [stderr] 176 | |                     return Ok(true);
[INFO] [stderr] ...   |
[INFO] [stderr] 180 | |                 ),
[INFO] [stderr] 181 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 173 |             match *data {
[INFO] [stderr] 174 |                 Yaml::Hash(ref mut data_hash) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/template.rs:189:23
[INFO] [stderr]     |
[INFO] [stderr] 189 |           let encoded = match value {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 190 | |             &mut Yaml::String(ref value_string) => encode(value_string.as_bytes()),
[INFO] [stderr] 191 | |             _ => return Err("Encountered non-string secret data value.".to_string()),
[INFO] [stderr] 192 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 189 |         let encoded = match *value {
[INFO] [stderr] 190 |             Yaml::String(ref value_string) => encode(value_string.as_bytes()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 | /     loop {
[INFO] [stderr] 141 | |         if let Some(filename) = param_files.next() {
[INFO] [stderr] 142 | |             let values = parameter_values_from_file(&filename)?;
[INFO] [stderr] 143 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |         }
[INFO] [stderr] 148 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(filename) = param_files.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     loop {
[INFO] [stderr] 157 | |         if let Some(name) = parameters.next() {
[INFO] [stderr] 158 | |             let value = parameters.next().expect("Parameter was missing its value.");
[INFO] [stderr] 159 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 169 | |         }
[INFO] [stderr] 170 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(name) = parameters.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     loop {
[INFO] [stderr] 179 | |         if let Some(name) = secret_parameters.next() {
[INFO] [stderr] 180 | |             let namespace = secret_parameters.next().expect("Secret was missing its namespace.");
[INFO] [stderr] 181 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |         }
[INFO] [stderr] 189 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(name) = secret_parameters.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:140:5
[INFO] [stderr]     |
[INFO] [stderr] 140 | /     loop {
[INFO] [stderr] 141 | |         if let Some(filename) = param_files.next() {
[INFO] [stderr] 142 | |             let values = parameter_values_from_file(&filename)?;
[INFO] [stderr] 143 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |         }
[INFO] [stderr] 148 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(filename) = param_files.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     loop {
[INFO] [stderr] 157 | |         if let Some(name) = parameters.next() {
[INFO] [stderr] 158 | |             let value = parameters.next().expect("Parameter was missing its value.");
[INFO] [stderr] 159 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 169 | |         }
[INFO] [stderr] 170 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(name) = parameters.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     loop {
[INFO] [stderr] 179 | |         if let Some(name) = secret_parameters.next() {
[INFO] [stderr] 180 | |             let namespace = secret_parameters.next().expect("Secret was missing its namespace.");
[INFO] [stderr] 181 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 188 | |         }
[INFO] [stderr] 189 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(name) = secret_parameters.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.80s
[INFO] running `"docker" "inspect" "0be67e00758bdf5c4223d4b547eaf2dc5194df6933da98331574b7ee2d7b6066"`
[INFO] running `"docker" "rm" "-f" "0be67e00758bdf5c4223d4b547eaf2dc5194df6933da98331574b7ee2d7b6066"`
[INFO] [stdout] 0be67e00758bdf5c4223d4b547eaf2dc5194df6933da98331574b7ee2d7b6066