[INFO] crate kth 0.1.0 is already in cache [INFO] extracting crate kth 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kth/0.1.0 [INFO] extracting crate kth 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kth/0.1.0 [INFO] validating manifest of kth-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kth-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kth-0.1.0 [INFO] finished frobbing kth-0.1.0 [INFO] frobbed toml for kth-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kth/0.1.0/Cargo.toml [INFO] started frobbing kth-0.1.0 [INFO] finished frobbing kth-0.1.0 [INFO] frobbed toml for kth-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kth/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kth-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kth/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3f87b3b61ce2308c85c54f1956c9d28106c08efbad05e83c2caa29ca785647f [INFO] running `"docker" "start" "-a" "d3f87b3b61ce2308c85c54f1956c9d28106c08efbad05e83c2caa29ca785647f"` [INFO] [stderr] warning: `panic` setting is ignored for `test` profile [INFO] [stderr] Checking index-fixed v0.0.2 [INFO] [stderr] Compiling kth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | let a = 0; let b = 1; let c = 2; let d = 3; let e = 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:106:53 [INFO] [stderr] | [INFO] [stderr] 106 | let a = 0; let b = 1; let c = 2; let d = 3; let e = 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | let mut m = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | let a = 0; let b = 1; let c = 2; let d = 3; let e = 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:106:53 [INFO] [stderr] | [INFO] [stderr] 106 | let a = 0; let b = 1; let c = 2; let d = 3; let e = 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quickselect.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | let mut m = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/quickselect.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if a[0] <= a[2] { [INFO] [stderr] 161 | | a.swap(0,1); [INFO] [stderr] 162 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if a[0] <= a[2] { [INFO] [stderr] 160 | a.swap(0,1); [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | // 1 < 0 && 2 < 0 [INFO] [stderr] 163 | if a[1] < a[2] { [INFO] [stderr] 164 | a.swap(0,1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/quickselect.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | if a[0] <= a[2] { [INFO] [stderr] 153 | | a.swap(1,2); [INFO] [stderr] 154 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if a[0] <= a[2] { [INFO] [stderr] 152 | a.swap(1,2); [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | a.swap(0,1); [INFO] [stderr] 155 | a.swap(0,2); [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 3]`) [INFO] [stderr] --> src/quickselect.rs:223:15 [INFO] [stderr] | [INFO] [stderr] 223 | sort3(index_fixed!(&mut a;..3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 3]`) [INFO] [stderr] --> src/quickselect.rs:232:15 [INFO] [stderr] | [INFO] [stderr] 232 | sort3(index_fixed!(&mut a;..3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quickselect.rs:319:19 [INFO] [stderr] | [INFO] [stderr] 319 | debug_assert!(arr.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/quickselect.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if a[0] <= a[2] { [INFO] [stderr] 161 | | a.swap(0,1); [INFO] [stderr] 162 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if a[0] <= a[2] { [INFO] [stderr] 160 | a.swap(0,1); [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | // 1 < 0 && 2 < 0 [INFO] [stderr] 163 | if a[1] < a[2] { [INFO] [stderr] 164 | a.swap(0,1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/quickselect.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | if a[0] <= a[2] { [INFO] [stderr] 153 | | a.swap(1,2); [INFO] [stderr] 154 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if a[0] <= a[2] { [INFO] [stderr] 152 | a.swap(1,2); [INFO] [stderr] 153 | } else { [INFO] [stderr] 154 | a.swap(0,1); [INFO] [stderr] 155 | a.swap(0,2); [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/quickselect.rs:377:20 [INFO] [stderr] | [INFO] [stderr] 377 | } else if i > p { [INFO] [stderr] | ____________________^ [INFO] [stderr] 378 | | if !(x[i] >= x[p]) { [INFO] [stderr] 379 | | return true; [INFO] [stderr] 380 | | } [INFO] [stderr] 381 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 377 | } else if i > p && !(x[i] >= x[p]) { [INFO] [stderr] 378 | return true; [INFO] [stderr] 379 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quickselect.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 3]`) [INFO] [stderr] --> src/quickselect.rs:223:15 [INFO] [stderr] | [INFO] [stderr] 223 | sort3(index_fixed!(&mut a;..3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 3]`) [INFO] [stderr] --> src/quickselect.rs:232:15 [INFO] [stderr] | [INFO] [stderr] 232 | sort3(index_fixed!(&mut a;..3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 5]`) [INFO] [stderr] --> src/quickselect.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | partition5(index_fixed!(&mut a;..5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quickselect.rs:319:19 [INFO] [stderr] | [INFO] [stderr] 319 | debug_assert!(arr.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/quickselect.rs:374:20 [INFO] [stderr] | [INFO] [stderr] 374 | if !(x[i] <= x[p]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `x[i] > x[p]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/quickselect.rs:378:20 [INFO] [stderr] | [INFO] [stderr] 378 | if !(x[i] >= x[p]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `x[i] < x[p]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/quickselect.rs:390:12 [INFO] [stderr] | [INFO] [stderr] 390 | if !(op == x[p]) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `op != x[p]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 5]`) [INFO] [stderr] --> src/quickselect.rs:406:21 [INFO] [stderr] | [INFO] [stderr] 406 | let d = index_fixed!(&mut d;..5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 5]`) [INFO] [stderr] --> src/quickselect.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | let d = index_fixed!(&mut d;..5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 5]`) [INFO] [stderr] --> src/quickselect.rs:427:21 [INFO] [stderr] | [INFO] [stderr] 427 | let d = index_fixed!(&mut d;..5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut T`) to a reference type (`&mut [T; 3]`) [INFO] [stderr] --> src/quickselect.rs:438:21 [INFO] [stderr] | [INFO] [stderr] 438 | let d = index_fixed!(&mut d;..3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quickselect.rs:448:16 [INFO] [stderr] | [INFO] [stderr] 448 | if d.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `is_partitioned` doesn't need a mutable reference [INFO] [stderr] --> src/quickselect.rs:456:50 [INFO] [stderr] | [INFO] [stderr] 456 | TestResult::from_bool(is_partitioned(&mut d[..], po)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quickselect.rs:461:16 [INFO] [stderr] | [INFO] [stderr] 461 | if d.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `is_partitioned` doesn't need a mutable reference [INFO] [stderr] --> src/quickselect.rs:469:50 [INFO] [stderr] | [INFO] [stderr] 469 | TestResult::from_bool(is_partitioned(&mut d[..], po)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quickselect.rs:474:16 [INFO] [stderr] | [INFO] [stderr] 474 | if d.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> tests/slice.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | } else if i > p { [INFO] [stderr] | ________________^ [INFO] [stderr] 15 | | if !(x[i] >= x[p]) { [INFO] [stderr] 16 | | return true; [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | } else if i > p && !(x[i] >= x[p]) { [INFO] [stderr] 15 | return true; [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> tests/slice.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let mut d = &mut d[..]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/slice.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | if !(x[i] <= x[p]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `x[i] > x[p]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/slice.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | if !(x[i] >= x[p]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `x[i] < x[p]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/slice.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.11s [INFO] running `"docker" "inspect" "d3f87b3b61ce2308c85c54f1956c9d28106c08efbad05e83c2caa29ca785647f"` [INFO] running `"docker" "rm" "-f" "d3f87b3b61ce2308c85c54f1956c9d28106c08efbad05e83c2caa29ca785647f"` [INFO] [stdout] d3f87b3b61ce2308c85c54f1956c9d28106c08efbad05e83c2caa29ca785647f