[INFO] crate ktensor 0.1.0 is already in cache [INFO] extracting crate ktensor 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ktensor/0.1.0 [INFO] extracting crate ktensor 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ktensor/0.1.0 [INFO] validating manifest of ktensor-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ktensor-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ktensor-0.1.0 [INFO] finished frobbing ktensor-0.1.0 [INFO] frobbed toml for ktensor-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ktensor/0.1.0/Cargo.toml [INFO] started frobbing ktensor-0.1.0 [INFO] finished frobbing ktensor-0.1.0 [INFO] frobbed toml for ktensor-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ktensor/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ktensor-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ktensor/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92538e753a284771ee7e595ad73ad37ea673d39761c2a951742115f81ea1596b [INFO] running `"docker" "start" "-a" "92538e753a284771ee7e595ad73ad37ea673d39761c2a951742115f81ea1596b"` [INFO] [stderr] Checking ktensor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/matrix.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tensor/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | matrix: matrix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/matrix.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tensor/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | matrix: matrix, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | a / 64.0 + 0.984375 * (1.0 + a.exp()).ln() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | a / 64.0 + 0.984375 * (1.0 + a.exp()).ln() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.015_625` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.015_625` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | a / 64.0 + 0.984375 * (1.0 + a.exp()).ln() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | a / 64.0 + 0.984375 * (1.0 + a.exp()).ln() [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.015_625` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.015_625` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/op/relu.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | g * (0.015625 + 0.984375 * (1.0 + (-a).exp()).recip()) [INFO] [stderr] | ^^^^^^^^ help: consider: `0.984_375` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `math::matrix::Matrix` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/math/matrix.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl Matrix { [INFO] [stderr] 18 | | /// Returns a new `Matrix` [INFO] [stderr] 19 | | /// [INFO] [stderr] 20 | | /// # Arguments [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/matrix.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn to_flattened(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: item `math::matrix::Matrix` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/math/matrix.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl Matrix { [INFO] [stderr] 18 | | /// Returns a new `Matrix` [INFO] [stderr] 19 | | /// [INFO] [stderr] 20 | | /// # Arguments [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/math/matrix.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn to_flattened(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tensor/mod.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_flattened(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context` [INFO] [stderr] --> src/context/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Context { [INFO] [stderr] 15 | | Context { [INFO] [stderr] 16 | | map: HashMap::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | op_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:29:94 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(node_id: String, operation: fn(Vec>) -> Tensor, operation_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, parameter: Vec>>, calc_dim: fn(Vec) -> Vec2) -> Node where T: Copy { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:39:99 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn with_dim(node_id: String, operation: fn(Vec>) -> Tensor, operation_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, parameter: Vec>>, dimension: Vec2) -> Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tensor/mod.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_flattened(self) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context` [INFO] [stderr] --> src/context/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Context { [INFO] [stderr] 15 | | Context { [INFO] [stderr] 16 | | map: HashMap::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | op_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:29:94 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(node_id: String, operation: fn(Vec>) -> Tensor, operation_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, parameter: Vec>>, calc_dim: fn(Vec) -> Vec2) -> Node where T: Copy { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/node/junction.rs:39:99 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn with_dim(node_id: String, operation: fn(Vec>) -> Tensor, operation_prime: fn(&Tensor, Vec<&Tensor>) -> Vec>, parameter: Vec>>, dimension: Vec2) -> Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_u8` [INFO] [stderr] --> tests/mnist.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn read_u8(reader: &mut Read) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/mnist.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref mut labels_reader = BufReader::new(labels_file); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^------------------------------- help: try: `let labels_reader = &mut BufReader::new(labels_file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/mnist.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref mut data_reader = BufReader::new(data_file); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^----------------------------- help: try: `let data_reader = &mut BufReader::new(data_file);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/mnist.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match data_reader.read_exact(sample_data.as_mut()) { [INFO] [stderr] 67 | | Err(reason) => panic!("failed to read data byte array: {}", Error::description(&reason)), [INFO] [stderr] 68 | | Ok(_) => (), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(reason) = data_reader.read_exact(sample_data.as_mut()) { panic!("failed to read data byte array: {}", Error::description(&reason)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/mnist.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / match labels_reader.read_exact(sample_labels_byte.as_mut()) { [INFO] [stderr] 72 | | Err(reason) => panic!("failed to read labels byte array: {}", Error::description(&reason)), [INFO] [stderr] 73 | | Ok(_) => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(reason) = labels_reader.read_exact(sample_labels_byte.as_mut()) { panic!("failed to read labels byte array: {}", Error::description(&reason)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> tests/mnist.rs:76:56 [INFO] [stderr] | [INFO] [stderr] 76 | let sample_data = sample_data.iter().map(|&x| (x as f32 - 128.0) / 74.0).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.59s [INFO] running `"docker" "inspect" "92538e753a284771ee7e595ad73ad37ea673d39761c2a951742115f81ea1596b"` [INFO] running `"docker" "rm" "-f" "92538e753a284771ee7e595ad73ad37ea673d39761c2a951742115f81ea1596b"` [INFO] [stdout] 92538e753a284771ee7e595ad73ad37ea673d39761c2a951742115f81ea1596b