[INFO] crate krpc-rs 0.3.1 is already in cache
[INFO] extracting crate krpc-rs 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/krpc-rs/0.3.1
[INFO] extracting crate krpc-rs 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/krpc-rs/0.3.1
[INFO] validating manifest of krpc-rs-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of krpc-rs-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing krpc-rs-0.3.1
[INFO] finished frobbing krpc-rs-0.3.1
[INFO] frobbed toml for krpc-rs-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/krpc-rs/0.3.1/Cargo.toml
[INFO] started frobbing krpc-rs-0.3.1
[INFO] finished frobbing krpc-rs-0.3.1
[INFO] frobbed toml for krpc-rs-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/krpc-rs/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting krpc-rs-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/krpc-rs/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 770d225eeb329a4561638192272d5fc88600c6ecf94c8f5b0bd894343e88fa90
[INFO] running `"docker" "start" "-a" "770d225eeb329a4561638192272d5fc88600c6ecf94c8f5b0bd894343e88fa90"`
[INFO] [stderr] Checking krpc-rs v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr] --> src/schema.rs:6:10
[INFO] [stderr] |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/rpc.rs:39:13
[INFO] [stderr] |
[INFO] [stderr] 39 | id : id,
[INFO] [stderr] | ^^^^^^^ help: replace it with: `id`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/rpc.rs:40:13
[INFO] [stderr] |
[INFO] [stderr] 40 | socket : socket
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/stream.rs:26:13
[INFO] [stderr] |
[INFO] [stderr] 26 | socket : socket,
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/stream.rs:27:13
[INFO] [stderr] |
[INFO] [stderr] 27 | rpc : rpc
[INFO] [stderr] | ^^^^^^^^^ help: replace it with: `rpc`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr] --> src/schema.rs:6:10
[INFO] [stderr] |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/rpc.rs:39:13
[INFO] [stderr] |
[INFO] [stderr] 39 | id : id,
[INFO] [stderr] | ^^^^^^^ help: replace it with: `id`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/rpc.rs:40:13
[INFO] [stderr] |
[INFO] [stderr] 40 | socket : socket
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/stream.rs:26:13
[INFO] [stderr] |
[INFO] [stderr] 26 | socket : socket,
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/stream.rs:27:13
[INFO] [stderr] |
[INFO] [stderr] 27 | rpc : rpc
[INFO] [stderr] | ^^^^^^^^^ help: replace it with: `rpc`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr] --> src/schema.rs:6:10
[INFO] [stderr] |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/rpc.rs:51:35
[INFO] [stderr] |
[INFO] [stderr] 51 | len += ((buf[0] & 0b01111111) as usize) << i;
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/rpc.rs:52:29
[INFO] [stderr] |
[INFO] [stderr] 52 | if buf[0] & 0b10000000 == 0 { break }
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/stream.rs:55:35
[INFO] [stderr] |
[INFO] [stderr] 55 | len += ((buf[0] & 0b01111111) as usize) << i;
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/stream.rs:56:29
[INFO] [stderr] |
[INFO] [stderr] 56 | if buf[0] & 0b10000000 == 0 { break }
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr] --> src/schema.rs:6:10
[INFO] [stderr] |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/rpc.rs:51:35
[INFO] [stderr] |
[INFO] [stderr] 51 | len += ((buf[0] & 0b01111111) as usize) << i;
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/rpc.rs:52:29
[INFO] [stderr] |
[INFO] [stderr] 52 | if buf[0] & 0b10000000 == 0 { break }
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/stream.rs:55:35
[INFO] [stderr] |
[INFO] [stderr] 55 | len += ((buf[0] & 0b01111111) as usize) << i;
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/stream.rs:56:29
[INFO] [stderr] |
[INFO] [stderr] 56 | if buf[0] & 0b10000000 == 0 { break }
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/stream.rs:32:13
[INFO] [stderr] |
[INFO] [stderr] 32 | let mut request : Request = make_request!(service, procedure, args);
[INFO] [stderr] | ----^^^^^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(unused_mut)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/stream.rs:32:13
[INFO] [stderr] |
[INFO] [stderr] 32 | let mut request : Request = make_request!(service, procedure, args);
[INFO] [stderr] | ----^^^^^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(unused_mut)] on by default
[INFO] [stderr]
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr] --> src/macros.rs:9:9
[INFO] [stderr] |
[INFO] [stderr] 9 | / match $res {
[INFO] [stderr] 10 | | Ok(i) => i,
[INFO] [stderr] 11 | | Err(e) => return Err($err(e))
[INFO] [stderr] 12 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] ::: src/rpc.rs:24:9
[INFO] [stderr] |
[INFO] [stderr] 24 | unwrap_ret!(socket.write(&RPC_HELLO_MESSAGE), ConnectionErr::HelloMessageFailed);
[INFO] [stderr] | --------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr] --> src/macros.rs:9:9
[INFO] [stderr] |
[INFO] [stderr] 9 | / match $res {
[INFO] [stderr] 10 | | Ok(i) => i,
[INFO] [stderr] 11 | | Err(e) => return Err($err(e))
[INFO] [stderr] 12 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] ::: src/rpc.rs:31:13
[INFO] [stderr] |
[INFO] [stderr] 31 | unwrap_ret!(socket.write(&buf), ConnectionErr::NameMessageFailed);
[INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr] --> src/rpc.rs:44:5
[INFO] [stderr] |
[INFO] [stderr] 44 | / pub fn receive<'a>(&'a mut self) -> Result