[INFO] crate kreida 0.0.1 is already in cache [INFO] extracting crate kreida 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/kreida/0.0.1 [INFO] extracting crate kreida 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kreida/0.0.1 [INFO] validating manifest of kreida-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kreida-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kreida-0.0.1 [INFO] finished frobbing kreida-0.0.1 [INFO] frobbed toml for kreida-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/kreida/0.0.1/Cargo.toml [INFO] started frobbing kreida-0.0.1 [INFO] finished frobbing kreida-0.0.1 [INFO] frobbed toml for kreida-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kreida/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kreida-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kreida/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c261b686562846f43372d38fafcad4c5b1f45ded331432e728c123f14562e0b [INFO] running `"docker" "start" "-a" "6c261b686562846f43372d38fafcad4c5b1f45ded331432e728c123f14562e0b"` [INFO] [stderr] Checking kreida v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/space.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return Rect { a: a.into(), b: b.into() } .norm() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rect { a: a.into(), b: b.into() } .norm()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/space.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return Rect { a: a.into(), b: b.into() } .norm() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rect { a: a.into(), b: b.into() } .norm()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: item `core::buffer::Buffer<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/core/buffer.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl<'a> Buffer<'a> { [INFO] [stderr] 14 | | pub fn from_row(ptr: *mut Color, len: usize, width: usize) -> Self { [INFO] [stderr] 15 | | if len % width != 0 { [INFO] [stderr] 16 | | unreachable!() [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/buffer.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | buf: unsafe { slice::from_raw_parts_mut(ptr, len) }, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/buffer.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | pixel.a = (pixel.a as u16 * k as u16 / 256) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(pixel.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/buffer.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | pixel.a = (pixel.a as u16 * k as u16 / 256) as u8; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/canvas.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | let canvas = unsafe {canvas.as_mut()}.unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/canvas.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let chart = unsafe {canvas.as_ref()}.unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/space.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self.is_original() && other.is_original() { [INFO] [stderr] 68 | | true => Original( (self.into_inner(), other.into_inner()) ), [INFO] [stderr] 69 | | false => Fixed( (self.into_inner(), other.into_inner()) ), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_original() && other.is_original() { Original( (self.into_inner(), other.into_inner()) ) } else { Fixed( (self.into_inner(), other.into_inner()) ) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/style.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match v { [INFO] [stderr] 12 | | true => Color::black(), [INFO] [stderr] 13 | | false => Color::white(), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { Color::black() } else { Color::white() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn as_bool(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kreida`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `core::buffer::Buffer<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/core/buffer.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl<'a> Buffer<'a> { [INFO] [stderr] 14 | | pub fn from_row(ptr: *mut Color, len: usize, width: usize) -> Self { [INFO] [stderr] 15 | | if len % width != 0 { [INFO] [stderr] 16 | | unreachable!() [INFO] [stderr] ... | [INFO] [stderr] 171 | | } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/buffer.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | buf: unsafe { slice::from_raw_parts_mut(ptr, len) }, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/buffer.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | pixel.a = (pixel.a as u16 * k as u16 / 256) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(pixel.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core/buffer.rs:45:41 [INFO] [stderr] | [INFO] [stderr] 45 | pixel.a = (pixel.a as u16 * k as u16 / 256) as u8; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/canvas.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | let canvas = unsafe {canvas.as_mut()}.unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/core/canvas.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let chart = unsafe {canvas.as_ref()}.unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/space.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self.is_original() && other.is_original() { [INFO] [stderr] 68 | | true => Original( (self.into_inner(), other.into_inner()) ), [INFO] [stderr] 69 | | false => Fixed( (self.into_inner(), other.into_inner()) ), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_original() && other.is_original() { Original( (self.into_inner(), other.into_inner()) ) } else { Fixed( (self.into_inner(), other.into_inner()) ) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/core/style.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match v { [INFO] [stderr] 12 | | true => Color::black(), [INFO] [stderr] 13 | | false => Color::white(), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { Color::black() } else { Color::white() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn as_bool(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kreida`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c261b686562846f43372d38fafcad4c5b1f45ded331432e728c123f14562e0b"` [INFO] running `"docker" "rm" "-f" "6c261b686562846f43372d38fafcad4c5b1f45ded331432e728c123f14562e0b"` [INFO] [stdout] 6c261b686562846f43372d38fafcad4c5b1f45ded331432e728c123f14562e0b