[INFO] crate krankerl 0.10.0 is already in cache
[INFO] extracting crate krankerl 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/krankerl/0.10.0
[INFO] extracting crate krankerl 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/krankerl/0.10.0
[INFO] validating manifest of krankerl-0.10.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of krankerl-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing krankerl-0.10.0
[INFO] finished frobbing krankerl-0.10.0
[INFO] frobbed toml for krankerl-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/krankerl/0.10.0/Cargo.toml
[INFO] started frobbing krankerl-0.10.0
[INFO] finished frobbing krankerl-0.10.0
[INFO] frobbed toml for krankerl-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/krankerl/0.10.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting krankerl-0.10.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/krankerl/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 219422bbdd3aab5e3c5e05ee60ea5688bf666a5669c5c9c3c7f68493ee1b7e44
[INFO] running `"docker" "start" "-a" "219422bbdd3aab5e3c5e05ee60ea5688bf666a5669c5c9c3c7f68493ee1b7e44"`
[INFO] [stderr]     Checking xpath_reader v0.5.1
[INFO] [stderr]     Checking globset v0.4.2
[INFO] [stderr]     Checking docopt v1.0.2
[INFO] [stderr]     Checking npm_scripts v0.1.2
[INFO] [stderr]     Checking nextcloud_appsignature v0.3.0
[INFO] [stderr]     Checking composer v0.1.0
[INFO] [stderr]     Checking nextcloud_appstore v0.4.0
[INFO] [stderr]     Checking nextcloud_appinfo v0.4.1
[INFO] [stderr]     Checking krankerl v0.10.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config/krankerl.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     config
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config/krankerl.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |       let config = serde_json::from_str(&contents)
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 50 | |         .map_err(|err| format_err!("could not parse config.json: {}", err));
[INFO] [stderr]    | |___________________________________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Command`, `Stdio`
[INFO] [stderr]  --> src/packaging/artifacts.rs:4:20
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::process::{Command, Stdio};
[INFO] [stderr]   |                    ^^^^^^^  ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/commands/sign_package.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     env::home_dir().ok_or(format_err!("Could not resolve home dir",))
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config/krankerl.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     config
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config/krankerl.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |       let config = serde_json::from_str(&contents)
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 50 | |         .map_err(|err| format_err!("could not parse config.json: {}", err));
[INFO] [stderr]    | |___________________________________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Command`, `Stdio`
[INFO] [stderr]  --> src/packaging/artifacts.rs:4:20
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::process::{Command, Stdio};
[INFO] [stderr]   |                    ^^^^^^^  ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/commands/sign_package.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     env::home_dir().ok_or(format_err!("Could not resolve home dir",))
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/commands/login.rs:4:34
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn log_in_to_appstore(token: &String) -> Result<(), Error> {
[INFO] [stderr]   |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/commands/login.rs:8:32
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn log_in_to_github(token: &String) -> Result<(), Error> {
[INFO] [stderr]   |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]  --> src/commands/sign_package.rs:9:21
[INFO] [stderr]   |
[INFO] [stderr] 9 |     env::home_dir().ok_or(format_err!("Could not resolve home dir",))
[INFO] [stderr]   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Could not resolve home dir",))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/sign_package.rs:12:33
[INFO] [stderr]    |
[INFO] [stderr] 12 | fn get_private_key_path(app_id: &String) -> Result<PathBuf, Error> {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/sign_package.rs:20:29
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn get_package_path(app_id: &String) -> Result<PathBuf, Error> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |             pb.set_message(&format!("Installing npm packages..."));
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installing npm packages...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 pb.set_message(&format!("Running npm build script..."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Running npm build script...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 pb.finish_with_message(&format!("Installed npm packages and ran build script."));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed npm packages and ran build script.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:39:41
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 pb.finish_with_message(&format!("Installed npm packages."));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed npm packages.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:44:37
[INFO] [stderr]    |
[INFO] [stderr] 44 |             pb.finish_with_message(&format!("No npm config found."));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No npm config found.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pb.set_message(&format!("Installing composer packages..."));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installing composer packages...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:57:33
[INFO] [stderr]    |
[INFO] [stderr] 57 |         pb.finish_with_message(&format!("Installed composer packages."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed composer packages.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |         pb.finish_with_message(&format!("No composer config found."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No composer config found.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default`
[INFO] [stderr]   --> src/config/app.rs:47:22
[INFO] [stderr]    |
[INFO] [stderr] 47 |               package: self
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 48 | |                 .package
[INFO] [stderr] 49 | |                 .map(|pc| pc.into())
[INFO] [stderr] 50 | |                 .unwrap_or(PackageConfig::default()),
[INFO] [stderr]    | |____________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 |             package: self
[INFO] [stderr] 48 |                 .package
[INFO] [stderr] 49 |                 .map(|pc| pc.into()).unwrap_or_default(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config/app.rs:73:43
[INFO] [stderr]    |
[INFO] [stderr] 73 |             before_cmds: self.before_cmds.unwrap_or(vec![]),
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config/app.rs:74:35
[INFO] [stderr]    |
[INFO] [stderr] 74 |             exclude: self.exclude.unwrap_or(vec![]),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/config/app.rs:97:12
[INFO] [stderr]     |
[INFO] [stderr] 97  |       if let Ok(_) = File::open(&path_buf) {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 98  | |         bail!(error::KrankerlError::Other {
[INFO] [stderr] 99  | |             cause: "krankerl.toml already exists.".to_string()
[INFO] [stderr] 100 | |         });
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____- help: try this: `if File::open(&path_buf).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/config/app.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         r#"[package]
[INFO] [stderr] 107 | | exclude = [
[INFO] [stderr] 108 | |
[INFO] [stderr] 109 | | ]
[INFO] [stderr] ...   |
[INFO] [stderr] 113 | | ]
[INFO] [stderr] 114 | | "#.as_bytes(),
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]     |
[INFO] [stderr] 106 |         br#"[package]
[INFO] [stderr] 107 | exclude = [
[INFO] [stderr] 108 | 
[INFO] [stderr] 109 | ]
[INFO] [stderr] 110 | 
[INFO] [stderr] 111 | before_cmds = [
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/krankerl.rs:13:34
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn set_appstore_token(token: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/krankerl.rs:22:32
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn set_github_token(token: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/occ.rs:28:38
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn enable_app(&self, app_id: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/occ.rs:34:39
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn disable_app(&self, app_id: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/packaging/exclude.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn new(excludes: &Vec<String>) -> Result<Self, Error> {
[INFO] [stderr]    |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/packaging/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |     app_id: &String,
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 32 |     app_id: &str,
[INFO] [stderr]    |             ^^^^
[INFO] [stderr] help: change `app_id.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let mut compressed_archive_filename = app_id.to_string();
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:39:10
[INFO] [stderr]    |
[INFO] [stderr] 39 |     url: &String,
[INFO] [stderr]    |          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |     signature: &String,
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:42:16
[INFO] [stderr]    |
[INFO] [stderr] 42 |     api_token: &String,
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/commands/login.rs:4:34
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn log_in_to_appstore(token: &String) -> Result<(), Error> {
[INFO] [stderr]   |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/commands/login.rs:8:32
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn log_in_to_github(token: &String) -> Result<(), Error> {
[INFO] [stderr]   |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]  --> src/commands/sign_package.rs:9:21
[INFO] [stderr]   |
[INFO] [stderr] 9 |     env::home_dir().ok_or(format_err!("Could not resolve home dir",))
[INFO] [stderr]   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Could not resolve home dir",))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/sign_package.rs:12:33
[INFO] [stderr]    |
[INFO] [stderr] 12 | fn get_private_key_path(app_id: &String) -> Result<PathBuf, Error> {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/sign_package.rs:20:29
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn get_package_path(app_id: &String) -> Result<PathBuf, Error> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |             pb.set_message(&format!("Installing npm packages..."));
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installing npm packages...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 pb.set_message(&format!("Running npm build script..."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Running npm build script...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 pb.finish_with_message(&format!("Installed npm packages and ran build script."));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed npm packages and ran build script.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:39:41
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 pb.finish_with_message(&format!("Installed npm packages."));
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed npm packages.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:44:37
[INFO] [stderr]    |
[INFO] [stderr] 44 |             pb.finish_with_message(&format!("No npm config found."));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No npm config found.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 |         pb.set_message(&format!("Installing composer packages..."));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installing composer packages...".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:57:33
[INFO] [stderr]    |
[INFO] [stderr] 57 |         pb.finish_with_message(&format!("Installed composer packages."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Installed composer packages.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/commands/up.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |         pb.finish_with_message(&format!("No composer config found."));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No composer config found.".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default`
[INFO] [stderr]   --> src/config/app.rs:47:22
[INFO] [stderr]    |
[INFO] [stderr] 47 |               package: self
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 48 | |                 .package
[INFO] [stderr] 49 | |                 .map(|pc| pc.into())
[INFO] [stderr] 50 | |                 .unwrap_or(PackageConfig::default()),
[INFO] [stderr]    | |____________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 |             package: self
[INFO] [stderr] 48 |                 .package
[INFO] [stderr] 49 |                 .map(|pc| pc.into()).unwrap_or_default(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config/app.rs:73:43
[INFO] [stderr]    |
[INFO] [stderr] 73 |             before_cmds: self.before_cmds.unwrap_or(vec![]),
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config/app.rs:74:35
[INFO] [stderr]    |
[INFO] [stderr] 74 |             exclude: self.exclude.unwrap_or(vec![]),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/config/app.rs:97:12
[INFO] [stderr]     |
[INFO] [stderr] 97  |       if let Ok(_) = File::open(&path_buf) {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 98  | |         bail!(error::KrankerlError::Other {
[INFO] [stderr] 99  | |             cause: "krankerl.toml already exists.".to_string()
[INFO] [stderr] 100 | |         });
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____- help: try this: `if File::open(&path_buf).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/config/app.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 | /         r#"[package]
[INFO] [stderr] 107 | | exclude = [
[INFO] [stderr] 108 | |
[INFO] [stderr] 109 | | ]
[INFO] [stderr] ...   |
[INFO] [stderr] 113 | | ]
[INFO] [stderr] 114 | | "#.as_bytes(),
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]     |
[INFO] [stderr] 106 |         br#"[package]
[INFO] [stderr] 107 | exclude = [
[INFO] [stderr] 108 | 
[INFO] [stderr] 109 | ]
[INFO] [stderr] 110 | 
[INFO] [stderr] 111 | before_cmds = [
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/krankerl.rs:13:34
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn set_appstore_token(token: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/krankerl.rs:22:32
[INFO] [stderr]    |
[INFO] [stderr] 22 | pub fn set_github_token(token: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/occ.rs:28:38
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn enable_app(&self, app_id: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/occ.rs:34:39
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn disable_app(&self, app_id: &String) -> Result<(), Error> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/packaging/exclude.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn new(excludes: &Vec<String>) -> Result<Self, Error> {
[INFO] [stderr]    |                          ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/packaging/mod.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |     app_id: &String,
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 32 |     app_id: &str,
[INFO] [stderr]    |             ^^^^
[INFO] [stderr] help: change `app_id.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let mut compressed_archive_filename = app_id.to_string();
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:39:10
[INFO] [stderr]    |
[INFO] [stderr] 39 |     url: &String,
[INFO] [stderr]    |          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |     signature: &String,
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:42:16
[INFO] [stderr]    |
[INFO] [stderr] 42 |     api_token: &String,
[INFO] [stderr]    |                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 33.22s
[INFO] running `"docker" "inspect" "219422bbdd3aab5e3c5e05ee60ea5688bf666a5669c5c9c3c7f68493ee1b7e44"`
[INFO] running `"docker" "rm" "-f" "219422bbdd3aab5e3c5e05ee60ea5688bf666a5669c5c9c3c7f68493ee1b7e44"`
[INFO] [stdout] 219422bbdd3aab5e3c5e05ee60ea5688bf666a5669c5c9c3c7f68493ee1b7e44