[INFO] crate korq 0.4.0 is already in cache [INFO] extracting crate korq 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/korq/0.4.0 [INFO] extracting crate korq 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/korq/0.4.0 [INFO] validating manifest of korq-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of korq-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing korq-0.4.0 [INFO] finished frobbing korq-0.4.0 [INFO] frobbed toml for korq-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/korq/0.4.0/Cargo.toml [INFO] started frobbing korq-0.4.0 [INFO] finished frobbing korq-0.4.0 [INFO] frobbed toml for korq-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/korq/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting korq-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/korq/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69527b55d3ac406998c88c939134aa1d6ca74d06d9ee08e6e3b5641aadd2145a [INFO] running `"docker" "start" "-a" "69527b55d3ac406998c88c939134aa1d6ca74d06d9ee08e6e3b5641aadd2145a"` [INFO] [stderr] Compiling k8s-openapi v0.2.0 [INFO] [stderr] Compiling carboxyl v0.2.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking qube v0.4.0 [INFO] [stderr] Checking korq v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const RUN_PHASE: &'static str = "Running"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/logtailer.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | .and_then(move |mut res| { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | while let Some(event) = events.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for event in events { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:165:42 [INFO] [stderr] | [INFO] [stderr] 165 | mem::replace(&mut *wpwriter, event.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if registry.iter().position(|x| *x.name == *event.name && *x.container == *event.container).is_none() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `registry.iter().position(|x| *x.name == *event.name && *x.container == *event.container).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:179:26 [INFO] [stderr] | [INFO] [stderr] 179 | let ec = event.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const RUN_PHASE: &'static str = "Running"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/logtailer.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | .and_then(move |mut res| { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | while let Some(event) = events.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for event in events { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:165:42 [INFO] [stderr] | [INFO] [stderr] 165 | mem::replace(&mut *wpwriter, event.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | if registry.iter().position(|x| *x.name == *event.name && *x.container == *event.container).is_none() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `registry.iter().position(|x| *x.name == *event.name && *x.container == *event.container).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:179:26 [INFO] [stderr] | [INFO] [stderr] 179 | let ec = event.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `"docker" "inspect" "69527b55d3ac406998c88c939134aa1d6ca74d06d9ee08e6e3b5641aadd2145a"` [INFO] running `"docker" "rm" "-f" "69527b55d3ac406998c88c939134aa1d6ca74d06d9ee08e6e3b5641aadd2145a"` [INFO] [stdout] 69527b55d3ac406998c88c939134aa1d6ca74d06d9ee08e6e3b5641aadd2145a