[INFO] crate kolmogorov_smirnov 1.1.0 is already in cache [INFO] extracting crate kolmogorov_smirnov 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/kolmogorov_smirnov/1.1.0 [INFO] extracting crate kolmogorov_smirnov 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kolmogorov_smirnov/1.1.0 [INFO] validating manifest of kolmogorov_smirnov-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kolmogorov_smirnov-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kolmogorov_smirnov-1.1.0 [INFO] finished frobbing kolmogorov_smirnov-1.1.0 [INFO] frobbed toml for kolmogorov_smirnov-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kolmogorov_smirnov/1.1.0/Cargo.toml [INFO] started frobbing kolmogorov_smirnov-1.1.0 [INFO] finished frobbing kolmogorov_smirnov-1.1.0 [INFO] frobbed toml for kolmogorov_smirnov-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kolmogorov_smirnov/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kolmogorov_smirnov-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kolmogorov_smirnov/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bba44981758085dab6bfc1482988b8287e0597375b52c8dcc4158e01b249c511 [INFO] running `"docker" "start" "-a" "bba44981758085dab6bfc1482988b8287e0597375b52c8dcc4158e01b249c511"` [INFO] [stderr] Checking kolmogorov_smirnov v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | Samples { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:338:26 [INFO] [stderr] | [INFO] [stderr] 338 | Percentile { val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | is_rejected: is_rejected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_rejected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | statistic: statistic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statistic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | reject_probability: reject_probability, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reject_probability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | critical_value: critical_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `critical_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | confidence: confidence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `confidence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | OrderableF64 { val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:350:23 [INFO] [stderr] | [INFO] [stderr] 350 | Samples { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | Samples { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ecdf.rs:338:26 [INFO] [stderr] | [INFO] [stderr] 338 | Percentile { val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | is_rejected: is_rejected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_rejected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | statistic: statistic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statistic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | reject_probability: reject_probability, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reject_probability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | critical_value: critical_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `critical_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | confidence: confidence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `confidence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | OrderableF64 { val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:350:23 [INFO] [stderr] | [INFO] [stderr] 350 | Samples { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let rank = (p as f64 * self.length as f64 / 100.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | num_samples_leq_t as f64 / length as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_samples_leq_t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | num_samples_leq_t as f64 / length as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | let rank = (p as f64 * length as f64 / 100.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let j = j as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `ks::test_f64` [INFO] [stderr] --> src/bin/ks_f64.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ks::test_f64; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/critical_values.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | for n2 in 16..(limit + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `16..=limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/critical_values.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | for n2 in 16..(limit + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `16..=limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused import: `ks::test` [INFO] [stderr] --> src/bin/ks_i64.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ks::test; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let rank = (p as f64 * self.length as f64 / 100.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | num_samples_leq_t as f64 / length as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_samples_leq_t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | num_samples_leq_t as f64 / length as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | let rank = (p as f64 * length as f64 / 100.0).ceil() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ecdf.rs:322:40 [INFO] [stderr] | [INFO] [stderr] 322 | Box::new(shrunk.filter(|v| v.len() > 0).map(|v| Samples { vec: v })) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | ecdf(&xs.vec, max) == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ecdf(&xs.vec, max) - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | ecdf(&xs.vec, max) == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | ecdf.value(max) == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ecdf.value(max) - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | ecdf.value(max) == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | ecdf(&xs.vec, val) == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ecdf(&xs.vec, val) - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | ecdf(&xs.vec, val) == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | ecdf.value(val) == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ecdf.value(val) - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | ecdf.value(val) == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:506:35 [INFO] [stderr] | [INFO] [stderr] 506 | TestResult::from_bool(actual == expected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(actual - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:506:35 [INFO] [stderr] | [INFO] [stderr] 506 | TestResult::from_bool(actual == expected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:530:35 [INFO] [stderr] | [INFO] [stderr] 530 | TestResult::from_bool(ecdf.value(val) == expected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ecdf.value(val) - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:530:35 [INFO] [stderr] | [INFO] [stderr] 530 | TestResult::from_bool(ecdf.value(val) == expected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ecdf.rs:541:13 [INFO] [stderr] | [INFO] [stderr] 541 | multiple_use.value(val) == ecdf(&xs.vec, val) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(multiple_use.value(val) - ecdf(&xs.vec, val)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ecdf.rs:541:13 [INFO] [stderr] | [INFO] [stderr] 541 | multiple_use.value(val) == ecdf(&xs.vec, val) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:770:13 [INFO] [stderr] | [INFO] [stderr] 770 | p.val as f64 / 100.0 <= ecdf(&xs.vec, actual) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(p.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | p.val as f64 / 100.0 <= ecdf.value(actual) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(p.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:799:13 [INFO] [stderr] | [INFO] [stderr] 799 | p.val as f64 / 100.0 <= ecdf(&xs.vec, actual) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(p.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ecdf.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | p.val as f64 / 100.0 <= ecdf.value(actual) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(p.val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `ks::test` [INFO] [stderr] --> src/bin/ks_i64.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ks::test; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let j = j as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:397:33 [INFO] [stderr] | [INFO] [stderr] 397 | assert!(xs.len() > 0 && ys.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | actual == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(actual - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | actual == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | result.statistic == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result.statistic - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | result.statistic == 1.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:506:13 [INFO] [stderr] | [INFO] [stderr] 506 | result.statistic == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result.statistic - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:506:13 [INFO] [stderr] | [INFO] [stderr] 506 | result.statistic == 0.5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | result.statistic == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result.statistic - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | result.statistic == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:574:35 [INFO] [stderr] | [INFO] [stderr] 574 | ys.vec.push(min - (j as u64) - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:578:28 [INFO] [stderr] | [INFO] [stderr] 578 | let expected = n as f64 / ys.vec.len() as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | result.statistic == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result.statistic - expected).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | result.statistic == expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:593:35 [INFO] [stderr] | [INFO] [stderr] 593 | ys.vec.push(max + (j as u64) + 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:597:28 [INFO] [stderr] | [INFO] [stderr] 597 | let expected = n as f64 / ys.vec.len() as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:613:35 [INFO] [stderr] | [INFO] [stderr] 613 | ys.vec.push(min - (j as u64) - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:614:35 [INFO] [stderr] | [INFO] [stderr] 614 | ys.vec.push(max + (j as u64) + 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:618:28 [INFO] [stderr] | [INFO] [stderr] 618 | let expected = n as f64 / ys.vec.len() as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:634:35 [INFO] [stderr] | [INFO] [stderr] 634 | ys.vec.push(min - (j as u64) - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:638:35 [INFO] [stderr] | [INFO] [stderr] 638 | ys.vec.push(max + (j as u64) + 1); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:642:28 [INFO] [stderr] | [INFO] [stderr] 642 | let expected = cmp::max(n, m) as f64 / ys.vec.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cmp::max(n, m))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kolmogorov_smirnov`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `ks::test_f64` [INFO] [stderr] --> src/bin/ks_f64.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use ks::test_f64; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "bba44981758085dab6bfc1482988b8287e0597375b52c8dcc4158e01b249c511"` [INFO] running `"docker" "rm" "-f" "bba44981758085dab6bfc1482988b8287e0597375b52c8dcc4158e01b249c511"` [INFO] [stdout] bba44981758085dab6bfc1482988b8287e0597375b52c8dcc4158e01b249c511