[INFO] crate kodama 0.2.2 is already in cache [INFO] extracting crate kodama 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/kodama/0.2.2 [INFO] extracting crate kodama 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kodama/0.2.2 [INFO] validating manifest of kodama-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kodama-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kodama-0.2.2 [INFO] finished frobbing kodama-0.2.2 [INFO] frobbed toml for kodama-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/kodama/0.2.2/Cargo.toml [INFO] started frobbing kodama-0.2.2 [INFO] finished frobbing kodama-0.2.2 [INFO] frobbed toml for kodama-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kodama/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kodama-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kodama/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4618d8f1eefd295f477299a900691d21ad0f38eef3b9e7201ae961769a6cc2c [INFO] running `"docker" "start" "-a" "a4618d8f1eefd295f477299a900691d21ad0f38eef3b9e7201ae961769a6cc2c"` [INFO] [stderr] Checking kodama v0.2.2 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/active.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | CondensedMatrix { data: data, observations: 0 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | CondensedMatrix { data: data, observations: observations } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:56:43 [INFO] [stderr] | [INFO] [stderr] 56 | CondensedMatrix { data: data, observations: observations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | observations: observations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | cluster1: cluster1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | cluster2: cluster2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | dissimilarity: dissimilarity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dissimilarity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/primitive.rs:163:19 [INFO] [stderr] | [INFO] [stderr] 163 | match active.range(row..).skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/union.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.next_parent = self.next_parent + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_parent += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:438:25 [INFO] [stderr] | [INFO] [stderr] 438 | fn requires_sorting(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:447:25 [INFO] [stderr] | [INFO] [stderr] 447 | fn square(&self, condensed_matrix: &mut [T]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:457:23 [INFO] [stderr] | [INFO] [stderr] 457 | fn sqrt(&self, dend: &mut Dendrogram) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:467:19 [INFO] [stderr] | [INFO] [stderr] 467 | fn on_squares(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:531:25 [INFO] [stderr] | [INFO] [stderr] 531 | fn square(&self, condensed_matrix: &mut [T]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:537:23 [INFO] [stderr] | [INFO] [stderr] 537 | fn sqrt(&self, dend: &mut Dendrogram) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:720:9 [INFO] [stderr] | [INFO] [stderr] 720 | self.sizes[cluster2] = self.sizes[cluster1] + self.sizes[cluster2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.sizes[cluster2] += self.sizes[cluster1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/active.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | CondensedMatrix { data: data, observations: 0 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | CondensedMatrix { data: data, observations: observations } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/condensed.rs:56:43 [INFO] [stderr] | [INFO] [stderr] 56 | CondensedMatrix { data: data, observations: observations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | observations: observations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | cluster1: cluster1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | cluster2: cluster2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | dissimilarity: dissimilarity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dissimilarity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dendrogram.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: couldn't read benches/../data/locations/ma-bench-small.dist: No such file or directory (os error 2) [INFO] [stderr] --> benches/bench.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | include_bytes!("../data/locations/ma-bench-small.dist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: couldn't read benches/../data/locations/ma-bench-large.dist: No such file or directory (os error 2) [INFO] [stderr] --> benches/bench.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | include_bytes!("../data/locations/ma-bench-large.dist"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kodama`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chain.rs:246:54 [INFO] [stderr] | [INFO] [stderr] 246 | dend_prim.eq_with_epsilon(&dend_nnchain, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chain.rs:254:54 [INFO] [stderr] | [INFO] [stderr] 254 | dend_prim.eq_with_epsilon(&dend_nnchain, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chain.rs:262:54 [INFO] [stderr] | [INFO] [stderr] 262 | dend_prim.eq_with_epsilon(&dend_nnchain, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generic.rs:398:54 [INFO] [stderr] | [INFO] [stderr] 398 | dend_prim.eq_with_epsilon(&dend_generic, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generic.rs:406:54 [INFO] [stderr] | [INFO] [stderr] 406 | dend_prim.eq_with_epsilon(&dend_generic, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generic.rs:430:57 [INFO] [stderr] | [INFO] [stderr] 430 | dend_nnchain.eq_with_epsilon(&dend_generic, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generic.rs:438:57 [INFO] [stderr] | [INFO] [stderr] 438 | dend_nnchain.eq_with_epsilon(&dend_generic, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/generic.rs:446:57 [INFO] [stderr] | [INFO] [stderr] 446 | dend_nnchain.eq_with_epsilon(&dend_generic, 0.0000000001) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 55 [INFO] [stderr] --> src/active.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | / fn iter_range() { [INFO] [stderr] 251 | | let mut a = Active::with_len(5); [INFO] [stderr] 252 | | assert_eq!(items_range(&a, 0..5), vec![0, 1, 2, 3, 4]); [INFO] [stderr] 253 | | assert_eq!(items_range(&a, 0..1), vec![0]); [INFO] [stderr] ... | [INFO] [stderr] 315 | | assert_eq!(items_range(&a, 5..5), vec![]); [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/primitive.rs:163:19 [INFO] [stderr] | [INFO] [stderr] 163 | match active.range(row..).skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `xs`. [INFO] [stderr] --> src/test.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..xs.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for in &mut xs { [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/union.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.next_parent = self.next_parent + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_parent += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/union.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / fn find_with_unions() { [INFO] [stderr] 161 | | let mut set = LinkageUnionFind::with_len(5); [INFO] [stderr] 162 | | [INFO] [stderr] 163 | | set.union(1, 3); [INFO] [stderr] ... | [INFO] [stderr] 198 | | assert_eq!(8, set.find(7)); [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:438:25 [INFO] [stderr] | [INFO] [stderr] 438 | fn requires_sorting(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:447:25 [INFO] [stderr] | [INFO] [stderr] 447 | fn square(&self, condensed_matrix: &mut [T]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:457:23 [INFO] [stderr] | [INFO] [stderr] 457 | fn sqrt(&self, dend: &mut Dendrogram) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:467:19 [INFO] [stderr] | [INFO] [stderr] 467 | fn on_squares(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:531:25 [INFO] [stderr] | [INFO] [stderr] 531 | fn square(&self, condensed_matrix: &mut [T]) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:537:23 [INFO] [stderr] | [INFO] [stderr] 537 | fn sqrt(&self, dend: &mut Dendrogram) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:720:9 [INFO] [stderr] | [INFO] [stderr] 720 | self.sizes[cluster2] = self.sizes[cluster1] + self.sizes[cluster2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.sizes[cluster2] += self.sizes[cluster1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a4618d8f1eefd295f477299a900691d21ad0f38eef3b9e7201ae961769a6cc2c"` [INFO] running `"docker" "rm" "-f" "a4618d8f1eefd295f477299a900691d21ad0f38eef3b9e7201ae961769a6cc2c"` [INFO] [stdout] a4618d8f1eefd295f477299a900691d21ad0f38eef3b9e7201ae961769a6cc2c