[INFO] crate knx_examples_rs 0.0.4 is already in cache [INFO] extracting crate knx_examples_rs 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/knx_examples_rs/0.0.4 [INFO] extracting crate knx_examples_rs 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/knx_examples_rs/0.0.4 [INFO] validating manifest of knx_examples_rs-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knx_examples_rs-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knx_examples_rs-0.0.4 [INFO] finished frobbing knx_examples_rs-0.0.4 [INFO] frobbed toml for knx_examples_rs-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/knx_examples_rs/0.0.4/Cargo.toml [INFO] started frobbing knx_examples_rs-0.0.4 [INFO] finished frobbing knx_examples_rs-0.0.4 [INFO] frobbed toml for knx_examples_rs-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/knx_examples_rs/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knx_examples_rs-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/knx_examples_rs/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 603725cbe656b6279cdbc05eb48187899694dff80001b142d5641779fae54049 [INFO] running `"docker" "start" "-a" "603725cbe656b6279cdbc05eb48187899694dff80001b142d5641779fae54049"` [INFO] [stderr] Checking knx_rs v0.0.4 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking knx_ets_rs v0.0.4 [INFO] [stderr] Checking knx_examples_rs v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: variable `ets` is assigned to, but never used [INFO] [stderr] --> src/bin/knx_listen.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let mut ets: Option = None; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_ets` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ets` is never read [INFO] [stderr] --> src/bin/knx_listen.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | ets = Some(Ets::new(opc_file)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/knx_listen.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / let mut ets: Option = None; [INFO] [stderr] 95 | | [INFO] [stderr] 96 | | if parms.is_present("opcfile") { [INFO] [stderr] 97 | | let opc_file = parms.value_of("opcfile").unwrap(); [INFO] [stderr] 98 | | ets = Some(Ets::new(opc_file)); [INFO] [stderr] 99 | | // ets.unwrap().print(); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let ets = if parms.is_present("opcfile") { ..; Some(Ets::new(opc_file)) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: variable `ets` is assigned to, but never used [INFO] [stderr] --> src/bin/knx_listen.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let mut ets: Option = None; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_ets` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ets` is never read [INFO] [stderr] --> src/bin/knx_listen.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | ets = Some(Ets::new(opc_file)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/knx_listen.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / let mut ets: Option = None; [INFO] [stderr] 95 | | [INFO] [stderr] 96 | | if parms.is_present("opcfile") { [INFO] [stderr] 97 | | let opc_file = parms.value_of("opcfile").unwrap(); [INFO] [stderr] 98 | | ets = Some(Ets::new(opc_file)); [INFO] [stderr] 99 | | // ets.unwrap().print(); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let ets = if parms.is_present("opcfile") { ..; Some(Ets::new(opc_file)) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.79s [INFO] running `"docker" "inspect" "603725cbe656b6279cdbc05eb48187899694dff80001b142d5641779fae54049"` [INFO] running `"docker" "rm" "-f" "603725cbe656b6279cdbc05eb48187899694dff80001b142d5641779fae54049"` [INFO] [stdout] 603725cbe656b6279cdbc05eb48187899694dff80001b142d5641779fae54049