[INFO] crate knock 0.1.8 is already in cache
[INFO] extracting crate knock 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/knock/0.1.8
[INFO] extracting crate knock 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/knock/0.1.8
[INFO] validating manifest of knock-0.1.8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of knock-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing knock-0.1.8
[INFO] finished frobbing knock-0.1.8
[INFO] frobbed toml for knock-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/knock/0.1.8/Cargo.toml
[INFO] started frobbing knock-0.1.8
[INFO] finished frobbing knock-0.1.8
[INFO] frobbed toml for knock-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/knock/0.1.8/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting knock-0.1.8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/knock/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] eaecd919e5e69a39775c9c457b492d933b4b0b061aa24173fc1e64b9854031f9
[INFO] running `"docker" "start" "-a" "eaecd919e5e69a39775c9c457b492d933b4b0b061aa24173fc1e64b9854031f9"`
[INFO] [stderr]     Checking knock v0.1.8 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             body: body,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:53:13
[INFO] [stderr]    |
[INFO] [stderr] 53 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/response.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             body: body,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             response: response,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `response`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             response: response,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `response`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             url: url,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             url: url,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:1:26
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const HTTP_VERSION: &'static str = "HTTP/1.0";
[INFO] [stderr]   |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:2:25
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CL_METHODS: [&'static str; 2] = ["POST", "PUT"];
[INFO] [stderr]   |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:3:21
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub const C_TYPE: [&'static str; 3] = [
[INFO] [stderr]   |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const SEP: &'static str = "\r\n";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const DEF_ACCEPT: &'static str = "*/*";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:14:22
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub const DEF_CONN: &'static str = "close";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const H_HOST: &'static str = "Host";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub const H_ACCPT: &'static str = "Accept";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub const H_CONN: &'static str = "Connection";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const H_CTYPE: &'static str = "Content-Type";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub const H_CLEN: &'static str = "Content-Length";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:1:26
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub const HTTP_VERSION: &'static str = "HTTP/1.0";
[INFO] [stderr]   |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:2:25
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const CL_METHODS: [&'static str; 2] = ["POST", "PUT"];
[INFO] [stderr]   |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:3:21
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub const C_TYPE: [&'static str; 3] = [
[INFO] [stderr]   |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const SEP: &'static str = "\r\n";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub const DEF_ACCEPT: &'static str = "*/*";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:14:22
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub const DEF_CONN: &'static str = "close";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const H_HOST: &'static str = "Host";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub const H_ACCPT: &'static str = "Accept";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub const H_CONN: &'static str = "Connection";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const H_CTYPE: &'static str = "Content-Type";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/consts.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub const H_CLEN: &'static str = "Content-Length";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:294:25
[INFO] [stderr]     |
[INFO] [stderr] 294 |           let connector = match self.danger_accept_invalid_certs {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 295 | |             true  => TlsConnector::builder().danger_accept_invalid_certs(true).build()?,
[INFO] [stderr] 296 | |             false => TlsConnector::builder().build()?,
[INFO] [stderr] 297 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.danger_accept_invalid_certs { TlsConnector::builder().danger_accept_invalid_certs(true).build()? } else { TlsConnector::builder().build()? }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:294:25
[INFO] [stderr]     |
[INFO] [stderr] 294 |           let connector = match self.danger_accept_invalid_certs {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 295 | |             true  => TlsConnector::builder().danger_accept_invalid_certs(true).build()?,
[INFO] [stderr] 296 | |             false => TlsConnector::builder().build()?,
[INFO] [stderr] 297 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.danger_accept_invalid_certs { TlsConnector::builder().danger_accept_invalid_certs(true).build()? } else { TlsConnector::builder().build()? }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> tests/unit.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |         assert!(http.method == "GET".to_string(), "should be equals");
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^ help: try: `"GET"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> tests/unit.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 |         assert!(http.method == "POST".to_string(), "should be equals");
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: try: `"POST"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.78s
[INFO] running `"docker" "inspect" "eaecd919e5e69a39775c9c457b492d933b4b0b061aa24173fc1e64b9854031f9"`
[INFO] running `"docker" "rm" "-f" "eaecd919e5e69a39775c9c457b492d933b4b0b061aa24173fc1e64b9854031f9"`
[INFO] [stdout] eaecd919e5e69a39775c9c457b492d933b4b0b061aa24173fc1e64b9854031f9