[INFO] crate kl-http 0.2.0 is already in cache [INFO] extracting crate kl-http 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/kl-http/0.2.0 [INFO] extracting crate kl-http 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kl-http/0.2.0 [INFO] validating manifest of kl-http-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kl-http-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kl-http-0.2.0 [INFO] finished frobbing kl-http-0.2.0 [INFO] frobbed toml for kl-http-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/kl-http/0.2.0/Cargo.toml [INFO] started frobbing kl-http-0.2.0 [INFO] finished frobbing kl-http-0.2.0 [INFO] frobbed toml for kl-http-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kl-http/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kl-http-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kl-http/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79888b1a9da733178d8ce000af6e9cf814a256d9b9f90e4893b25f25746abf62 [INFO] running `"docker" "start" "-a" "79888b1a9da733178d8ce000af6e9cf814a256d9b9f90e4893b25f25746abf62"` [INFO] [stderr] Checking kl-http v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:4 [INFO] [stderr] | [INFO] [stderr] 95 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:4 [INFO] [stderr] | [INFO] [stderr] 95 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Request` [INFO] [stderr] --> src/tests.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | use http::{Request, Response, StatusCode}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super` [INFO] [stderr] --> src/tests.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::*; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `listening_thread` [INFO] [stderr] --> src/tests.rs:14:6 [INFO] [stderr] | [INFO] [stderr] 14 | let listening_thread = ::std::thread::spawn(move || { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_listening_thread` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:135:3 [INFO] [stderr] | [INFO] [stderr] 135 | self.tcp_stream.write(&response_bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:317:22 [INFO] [stderr] | [INFO] [stderr] 317 | let ret: Vec = iter.map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:374:22 [INFO] [stderr] | [INFO] [stderr] 374 | let ret: Vec = iter.map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:411:3 [INFO] [stderr] | [INFO] [stderr] 411 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 412 | | &HttpRequestError::ParsingError(_) => "A stream parsing error occurred.", [INFO] [stderr] 413 | | &HttpRequestError::ContentLengthParsingError(_) => { [INFO] [stderr] 414 | | "The content length failed parsing into an integer." [INFO] [stderr] ... | [INFO] [stderr] 417 | | &HttpRequestError::BodyWritingError(_) => "Failed to write http body.", [INFO] [stderr] 418 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 411 | match *self { [INFO] [stderr] 412 | HttpRequestError::ParsingError(_) => "A stream parsing error occurred.", [INFO] [stderr] 413 | HttpRequestError::ContentLengthParsingError(_) => { [INFO] [stderr] 414 | "The content length failed parsing into an integer." [INFO] [stderr] 415 | } [INFO] [stderr] 416 | HttpRequestError::IOError(_) => "A IO error occurred.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kl-http`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tests.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | incoming_request.iter().map(|x| *x).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `incoming_request.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests.rs:30:11 [INFO] [stderr] | [INFO] [stderr] 30 | .body("hello me".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello me"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tests.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | myhttp.respond(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tests.rs:39:2 [INFO] [stderr] | [INFO] [stderr] 39 | s.write(incoming_request).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tests.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | &"hello me" [INFO] [stderr] | __________^ [INFO] [stderr] 49 | | .as_bytes() [INFO] [stderr] 50 | | .iter() [INFO] [stderr] 51 | | .map(|x| *x) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 48 | &"hello me" [INFO] [stderr] 49 | .as_bytes() [INFO] [stderr] 50 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests.rs:48:4 [INFO] [stderr] | [INFO] [stderr] 48 | &"hello me" [INFO] [stderr] | __________^ [INFO] [stderr] 49 | | .as_bytes() [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"hello me"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:135:3 [INFO] [stderr] | [INFO] [stderr] 135 | self.tcp_stream.write(&response_bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:317:22 [INFO] [stderr] | [INFO] [stderr] 317 | let ret: Vec = iter.map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:374:22 [INFO] [stderr] | [INFO] [stderr] 374 | let ret: Vec = iter.map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:411:3 [INFO] [stderr] | [INFO] [stderr] 411 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 412 | | &HttpRequestError::ParsingError(_) => "A stream parsing error occurred.", [INFO] [stderr] 413 | | &HttpRequestError::ContentLengthParsingError(_) => { [INFO] [stderr] 414 | | "The content length failed parsing into an integer." [INFO] [stderr] ... | [INFO] [stderr] 417 | | &HttpRequestError::BodyWritingError(_) => "Failed to write http body.", [INFO] [stderr] 418 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 411 | match *self { [INFO] [stderr] 412 | HttpRequestError::ParsingError(_) => "A stream parsing error occurred.", [INFO] [stderr] 413 | HttpRequestError::ContentLengthParsingError(_) => { [INFO] [stderr] 414 | "The content length failed parsing into an integer." [INFO] [stderr] 415 | } [INFO] [stderr] 416 | HttpRequestError::IOError(_) => "A IO error occurred.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kl-http`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "79888b1a9da733178d8ce000af6e9cf814a256d9b9f90e4893b25f25746abf62"` [INFO] running `"docker" "rm" "-f" "79888b1a9da733178d8ce000af6e9cf814a256d9b9f90e4893b25f25746abf62"` [INFO] [stdout] 79888b1a9da733178d8ce000af6e9cf814a256d9b9f90e4893b25f25746abf62