[INFO] crate kiwi-schema 0.1.1 is already in cache [INFO] extracting crate kiwi-schema 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/kiwi-schema/0.1.1 [INFO] extracting crate kiwi-schema 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kiwi-schema/0.1.1 [INFO] validating manifest of kiwi-schema-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kiwi-schema-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kiwi-schema-0.1.1 [INFO] finished frobbing kiwi-schema-0.1.1 [INFO] frobbed toml for kiwi-schema-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/kiwi-schema/0.1.1/Cargo.toml [INFO] started frobbing kiwi-schema-0.1.1 [INFO] finished frobbing kiwi-schema-0.1.1 [INFO] frobbed toml for kiwi-schema-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kiwi-schema/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kiwi-schema-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kiwi-schema/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 929e81fdcba32347d473ddbafec5b6e031eefc485c551f160db664e0c9bc7349 [INFO] running `"docker" "start" "-a" "929e81fdcba32347d473ddbafec5b6e031eefc485c551f160db664e0c9bc7349"` [INFO] [stderr] Checking kiwi-schema v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:221:50 [INFO] [stderr] | [INFO] [stderr] 221 | assert_eq!(try(&[253, 255, 255, 255, 15]), Ok(-2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:222:49 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(try(&[254, 255, 255, 255, 15]), Ok(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:223:50 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(try(&[255, 255, 255, 255, 15]), Ok(-2147483648)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:243:38 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(try(&[253, 255, 7]), Ok(131069)); [INFO] [stderr] | ^^^^^^ help: consider: `131_069` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:244:38 [INFO] [stderr] | [INFO] [stderr] 244 | assert_eq!(try(&[254, 255, 7]), Ok(131070)); [INFO] [stderr] | ^^^^^^ help: consider: `131_070` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:245:49 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(try(&[253, 255, 255, 255, 15]), Ok(4294967293)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_293` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:246:49 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(try(&[254, 255, 255, 255, 15]), Ok(4294967294)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_294` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:247:49 [INFO] [stderr] | [INFO] [stderr] 247 | assert_eq!(try(&[255, 255, 255, 255, 15]), Ok(4294967295)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(bb.read_var_uint(), Ok(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:428:48 [INFO] [stderr] | [INFO] [stderr] 428 | assert_eq!(write_once(|bb| bb.write_var_int(-2147483647)), [253, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:429:47 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(write_once(|bb| bb.write_var_int(2147483647)), [254, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:430:48 [INFO] [stderr] | [INFO] [stderr] 430 | assert_eq!(write_once(|bb| bb.write_var_int(-2147483648)), [255, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:445:48 [INFO] [stderr] | [INFO] [stderr] 445 | assert_eq!(write_once(|bb| bb.write_var_uint(131069)), [253, 255, 7]); [INFO] [stderr] | ^^^^^^ help: consider: `131_069` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:446:48 [INFO] [stderr] | [INFO] [stderr] 446 | assert_eq!(write_once(|bb| bb.write_var_uint(131070)), [254, 255, 7]); [INFO] [stderr] | ^^^^^^ help: consider: `131_070` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:447:48 [INFO] [stderr] | [INFO] [stderr] 447 | assert_eq!(write_once(|bb| bb.write_var_uint(4294967293)), [253, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_293` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:448:48 [INFO] [stderr] | [INFO] [stderr] 448 | assert_eq!(write_once(|bb| bb.write_var_uint(4294967294)), [254, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_294` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:449:48 [INFO] [stderr] | [INFO] [stderr] 449 | assert_eq!(write_once(|bb| bb.write_var_uint(4294967295)), [255, 255, 255, 255, 15]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:482:21 [INFO] [stderr] | [INFO] [stderr] 482 | bb.write_var_uint(123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | self.index = self.index + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | result |= ((byte & 127) as u32) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte & 127)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | first as u32 | [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:10 [INFO] [stderr] | [INFO] [stderr] 138 | ((self.data[self.index] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.data[self.index + 1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:10 [INFO] [stderr] | [INFO] [stderr] 140 | ((self.data[self.index + 2] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `ByteBufferMut` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:302:1 [INFO] [stderr] | [INFO] [stderr] 302 | / impl ByteBufferMut { [INFO] [stderr] 303 | | /// Creates an empty ByteBufferMut ready for writing. [INFO] [stderr] 304 | | pub fn new() -> ByteBufferMut { [INFO] [stderr] 305 | | ByteBufferMut{data: vec![]} [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ByteBufferMut` [INFO] [stderr] --> src/lib.rs:304:3 [INFO] [stderr] | [INFO] [stderr] 304 | / pub fn new() -> ByteBufferMut { [INFO] [stderr] 305 | | ByteBufferMut{data: vec![]} [INFO] [stderr] 306 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 298 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/lib.rs:364:8 [INFO] [stderr] | [INFO] [stderr] 364 | if (bits & 255) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `bits.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: item `Value<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:818:1 [INFO] [stderr] | [INFO] [stderr] 818 | / impl<'a> Value<'a> { [INFO] [stderr] 819 | | /// A convenience method to extract the value out of a [Bool](#variant.Bool). [INFO] [stderr] 820 | | /// Returns `false` for other value kinds. [INFO] [stderr] 821 | | pub fn as_bool(&self) -> bool { [INFO] [stderr] ... | [INFO] [stderr] 1045 | | } [INFO] [stderr] 1046 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1018:33 [INFO] [stderr] | [INFO] [stderr] 1018 | let def = &schema.defs[*schema.def_name_to_index.get(name).unwrap()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&schema.def_name_to_index[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1019:22 [INFO] [stderr] | [INFO] [stderr] 1019 | let index = *def.field_name_to_index.get(value).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&def.field_name_to_index[value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1024:33 [INFO] [stderr] | [INFO] [stderr] 1024 | let def = &schema.defs[*schema.def_name_to_index.get(name).unwrap()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&schema.def_name_to_index[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | self.index = self.index + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | result |= ((byte & 127) as u32) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte & 127)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | first as u32 | [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:10 [INFO] [stderr] | [INFO] [stderr] 138 | ((self.data[self.index] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | ((self.data[self.index + 1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:10 [INFO] [stderr] | [INFO] [stderr] 140 | ((self.data[self.index + 2] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[self.index + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `ByteBufferMut` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:302:1 [INFO] [stderr] | [INFO] [stderr] 302 | / impl ByteBufferMut { [INFO] [stderr] 303 | | /// Creates an empty ByteBufferMut ready for writing. [INFO] [stderr] 304 | | pub fn new() -> ByteBufferMut { [INFO] [stderr] 305 | | ByteBufferMut{data: vec![]} [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ByteBufferMut` [INFO] [stderr] --> src/lib.rs:304:3 [INFO] [stderr] | [INFO] [stderr] 304 | / pub fn new() -> ByteBufferMut { [INFO] [stderr] 305 | | ByteBufferMut{data: vec![]} [INFO] [stderr] 306 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 298 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/lib.rs:364:8 [INFO] [stderr] | [INFO] [stderr] 364 | if (bits & 255) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `bits.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: item `Value<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:818:1 [INFO] [stderr] | [INFO] [stderr] 818 | / impl<'a> Value<'a> { [INFO] [stderr] 819 | | /// A convenience method to extract the value out of a [Bool](#variant.Bool). [INFO] [stderr] 820 | | /// Returns `false` for other value kinds. [INFO] [stderr] 821 | | pub fn as_bool(&self) -> bool { [INFO] [stderr] ... | [INFO] [stderr] 1045 | | } [INFO] [stderr] 1046 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1018:33 [INFO] [stderr] | [INFO] [stderr] 1018 | let def = &schema.defs[*schema.def_name_to_index.get(name).unwrap()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&schema.def_name_to_index[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1019:22 [INFO] [stderr] | [INFO] [stderr] 1019 | let index = *def.field_name_to_index.get(value).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&def.field_name_to_index[value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1024:33 [INFO] [stderr] | [INFO] [stderr] 1024 | let def = &schema.defs[*schema.def_name_to_index.get(name).unwrap()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&schema.def_name_to_index[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:1133:3 [INFO] [stderr] | [INFO] [stderr] 1133 | assert_eq!(value[4].as_float(), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:1133:3 [INFO] [stderr] | [INFO] [stderr] 1133 | assert_eq!(value[4].as_float(), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/lib.rs:1195:1 [INFO] [stderr] | [INFO] [stderr] 1195 | / fn value_encode_and_decode() { [INFO] [stderr] 1196 | | let schema = Schema::new(vec![ [INFO] [stderr] 1197 | | Def::new("Enum".to_owned(), DefKind::Enum, vec![ [INFO] [stderr] 1198 | | Field {name: "FOO".to_owned(), type_id: 0, is_array: false, value: 100}, [INFO] [stderr] ... | [INFO] [stderr] 1298 | | assert_eq!(Value::decode(&schema, 2, &[9, 0, 0]), Ok(Value::Object("Message", insert(HashMap::new(), "v_message", Value::Object("Message", HashMap::new()))))); [INFO] [stderr] 1299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:1325:3 [INFO] [stderr] | [INFO] [stderr] 1325 | / fn use_item<'a>(_: &'a Value<'static>) { [INFO] [stderr] 1326 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kiwi-schema`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "929e81fdcba32347d473ddbafec5b6e031eefc485c551f160db664e0c9bc7349"` [INFO] running `"docker" "rm" "-f" "929e81fdcba32347d473ddbafec5b6e031eefc485c551f160db664e0c9bc7349"` [INFO] [stdout] 929e81fdcba32347d473ddbafec5b6e031eefc485c551f160db664e0c9bc7349