[INFO] crate kitsu 0.2.0 is already in cache [INFO] extracting crate kitsu 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/kitsu/0.2.0 [INFO] extracting crate kitsu 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kitsu/0.2.0 [INFO] validating manifest of kitsu-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kitsu-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kitsu-0.2.0 [INFO] finished frobbing kitsu-0.2.0 [INFO] frobbed toml for kitsu-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/kitsu/0.2.0/Cargo.toml [INFO] started frobbing kitsu-0.2.0 [INFO] finished frobbing kitsu-0.2.0 [INFO] frobbed toml for kitsu-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kitsu/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kitsu-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kitsu/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 780b344edea71159dcac1b175e3e5fb82c477d81cba971ff47cb14f41f9aa513 [INFO] running `"docker" "start" "-a" "780b344edea71159dcac1b175e3e5fb82c477d81cba971ff47cb14f41f9aa513"` [INFO] [stderr] Checking kitsu v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | pub const API_URL: &'static str = "https://kitsu.io/api/edge"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | pub const API_URL: &'static str = "https://kitsu.io/api/edge"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn largest<'a>(&'a self) -> Option<&'a String> { [INFO] [stderr] 363 | | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:363:56 [INFO] [stderr] | [INFO] [stderr] 363 | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.small.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:363:32 [INFO] [stderr] | [INFO] [stderr] 363 | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.large.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / pub fn largest<'a>(&'a self) -> Option<&'a String> { [INFO] [stderr] 390 | | self.original.as_ref() [INFO] [stderr] 391 | | .or(self.large.as_ref()) [INFO] [stderr] 392 | | .or(self.medium.as_ref()) [INFO] [stderr] 393 | | .or(self.small.as_ref()) [INFO] [stderr] 394 | | .or(self.tiny.as_ref()) [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:394:14 [INFO] [stderr] | [INFO] [stderr] 394 | .or(self.tiny.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.tiny.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:393:14 [INFO] [stderr] | [INFO] [stderr] 393 | .or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.small.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:392:14 [INFO] [stderr] | [INFO] [stderr] 392 | .or(self.medium.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.medium.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:391:14 [INFO] [stderr] | [INFO] [stderr] 391 | .or(self.large.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.large.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn largest<'a>(&'a self) -> Option<&'a String> { [INFO] [stderr] 363 | | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:363:56 [INFO] [stderr] | [INFO] [stderr] 363 | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.small.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:363:32 [INFO] [stderr] | [INFO] [stderr] 363 | self.original.as_ref().or(self.large.as_ref()).or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.large.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/model.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / pub fn largest<'a>(&'a self) -> Option<&'a String> { [INFO] [stderr] 390 | | self.original.as_ref() [INFO] [stderr] 391 | | .or(self.large.as_ref()) [INFO] [stderr] 392 | | .or(self.medium.as_ref()) [INFO] [stderr] 393 | | .or(self.small.as_ref()) [INFO] [stderr] 394 | | .or(self.tiny.as_ref()) [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:394:14 [INFO] [stderr] | [INFO] [stderr] 394 | .or(self.tiny.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.tiny.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:393:14 [INFO] [stderr] | [INFO] [stderr] 393 | .or(self.small.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.small.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:392:14 [INFO] [stderr] | [INFO] [stderr] 392 | .or(self.medium.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.medium.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/model.rs:391:14 [INFO] [stderr] | [INFO] [stderr] 391 | .or(self.large.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.large.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:921:17 [INFO] [stderr] | [INFO] [stderr] 921 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1010:17 [INFO] [stderr] | [INFO] [stderr] 1010 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1052:17 [INFO] [stderr] | [INFO] [stderr] 1052 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1102:17 [INFO] [stderr] | [INFO] [stderr] 1102 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1133:17 [INFO] [stderr] | [INFO] [stderr] 1133 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model.rs:1144:20 [INFO] [stderr] | [INFO] [stderr] 1144 | fn youtube_url(id: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:921:17 [INFO] [stderr] | [INFO] [stderr] 921 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1010:17 [INFO] [stderr] | [INFO] [stderr] 1010 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1052:17 [INFO] [stderr] | [INFO] [stderr] 1052 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1102:17 [INFO] [stderr] | [INFO] [stderr] 1102 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:1133:17 [INFO] [stderr] | [INFO] [stderr] 1133 | pub fn name(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model.rs:1144:20 [INFO] [stderr] | [INFO] [stderr] 1144 | fn youtube_url(id: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/test_reqwest_support.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | assert!(res.data.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/test_reqwest_support.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | assert!(res.data.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/test_reqwest_support.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(res.data.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.18s [INFO] running `"docker" "inspect" "780b344edea71159dcac1b175e3e5fb82c477d81cba971ff47cb14f41f9aa513"` [INFO] running `"docker" "rm" "-f" "780b344edea71159dcac1b175e3e5fb82c477d81cba971ff47cb14f41f9aa513"` [INFO] [stdout] 780b344edea71159dcac1b175e3e5fb82c477d81cba971ff47cb14f41f9aa513