[INFO] crate kiteconnect 0.2.4 is already in cache [INFO] extracting crate kiteconnect 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/kiteconnect/0.2.4 [INFO] extracting crate kiteconnect 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kiteconnect/0.2.4 [INFO] validating manifest of kiteconnect-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kiteconnect-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kiteconnect-0.2.4 [INFO] finished frobbing kiteconnect-0.2.4 [INFO] frobbed toml for kiteconnect-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/kiteconnect/0.2.4/Cargo.toml [INFO] started frobbing kiteconnect-0.2.4 [INFO] finished frobbing kiteconnect-0.2.4 [INFO] frobbed toml for kiteconnect-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kiteconnect/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kiteconnect-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kiteconnect/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 122a05b1db23e4c30410ba76ac697ca2149febe8321a8845a43ea048d14149df [INFO] running `"docker" "start" "-a" "122a05b1db23e4c30410ba76ac697ca2149febe8321a8845a43ea048d14149df"` [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Checking kiteconnect v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ticker.rs:380:26 [INFO] [stderr] | [INFO] [stderr] 380 | Server { out: out } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ticker.rs:380:26 [INFO] [stderr] | [INFO] [stderr] 380 | Server { out: out } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/connect.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | const URL: &'static str = "https://api.kite.trade"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ticker.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | divisor = 10000000.0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/connect.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | const URL: &'static str = mockito::SERVER_URL; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ticker.rs:189:31 [INFO] [stderr] | [INFO] [stderr] 189 | divisor = 10000000.0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:147:42 [INFO] [stderr] | [INFO] [stderr] 147 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:188:42 [INFO] [stderr] | [INFO] [stderr] 188 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/connect.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / pub fn place_order( [INFO] [stderr] 241 | | &self, [INFO] [stderr] 242 | | exchange: &str, [INFO] [stderr] 243 | | tradingsymbol: &str, [INFO] [stderr] ... | [INFO] [stderr] 278 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/connect.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn modify_order( [INFO] [stderr] 283 | | &self, [INFO] [stderr] 284 | | order_id: &str, [INFO] [stderr] 285 | | variety: &str, [INFO] [stderr] ... | [INFO] [stderr] 316 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/connect.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | / pub fn convert_position( [INFO] [stderr] 383 | | &self, [INFO] [stderr] 384 | | exchange: &str, [INFO] [stderr] 385 | | tradingsymbol: &str, [INFO] [stderr] ... | [INFO] [stderr] 404 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 405 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | / let url: reqwest::Url; [INFO] [stderr] 410 | | if order_id.is_some() { [INFO] [stderr] 411 | | url = self.build_url(format!("/mf/orders/{}", order_id.unwrap()).as_str(), None); [INFO] [stderr] 412 | | } else { [INFO] [stderr] 413 | | url = self.build_url("/mf/orders", None); [INFO] [stderr] 414 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if order_id.is_some() { self.build_url(format!("/mf/orders/{}", order_id.unwrap()).as_str(), None) } else { self.build_url("/mf/orders", None) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:452:9 [INFO] [stderr] | [INFO] [stderr] 452 | / let url: reqwest::Url; [INFO] [stderr] 453 | | if sip_id.is_some() { [INFO] [stderr] 454 | | url = self.build_url(format!("/mf/sips/{}", sip_id.unwrap()).as_str(), None); [INFO] [stderr] 455 | | } else { [INFO] [stderr] 456 | | url = self.build_url("/mf/sips", None); [INFO] [stderr] 457 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if sip_id.is_some() { self.build_url(format!("/mf/sips/{}", sip_id.unwrap()).as_str(), None) } else { self.build_url("/mf/sips", None) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/connect.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn place_mf_sip( [INFO] [stderr] 465 | | &self, [INFO] [stderr] 466 | | tradingsymbol: &str, [INFO] [stderr] 467 | | amount: &str, [INFO] [stderr] ... | [INFO] [stderr] 486 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 487 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:564:9 [INFO] [stderr] | [INFO] [stderr] 564 | / let url: reqwest::Url; [INFO] [stderr] 565 | | if exchange.is_some() { [INFO] [stderr] 566 | | url = self.build_url(format!("/instruments{}", exchange.unwrap()).as_str(), None); [INFO] [stderr] 567 | | } else { [INFO] [stderr] 568 | | url = self.build_url("/instruments", None); [INFO] [stderr] 569 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if exchange.is_some() { self.build_url(format!("/instruments{}", exchange.unwrap()).as_str(), None) } else { self.build_url("/instruments", None) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/ticker.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | modes.entry(mode.clone()).or_insert(vec![]).push(token.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/ticker.rs:145:51 [INFO] [stderr] | [INFO] [stderr] 145 | *self.subscribed_tokens.entry(*token).or_insert("".to_string()) = mode.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ticker.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / let mut divisor: f64 = 100.0; [INFO] [stderr] 188 | | if segment == 3 { // cds [INFO] [stderr] 189 | | divisor = 10000000.0; [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let divisor = if segment == 3 { 10000000.0 } else { 100.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ticker.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / let mut tradable = true; [INFO] [stderr] 192 | | if segment == 9 { // indices [INFO] [stderr] 193 | | tradable = false; [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let tradable = if segment == 9 { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:215:37 [INFO] [stderr] | [INFO] [stderr] 215 | "high": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:216:36 [INFO] [stderr] | [INFO] [stderr] 216 | "low": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:217:37 [INFO] [stderr] | [INFO] [stderr] 217 | "open": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:218:38 [INFO] [stderr] | [INFO] [stderr] 218 | "close": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:225:76 [INFO] [stderr] | [INFO] [stderr] 225 | data["change"] = json!((last_price - ohlc_close) * 100 as f64 / ohlc_close); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:228:51 [INFO] [stderr] | [INFO] [stderr] 228 | data["timestamp"] = json!(reader.read_i32::().unwrap() as f64 / divisor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:240:39 [INFO] [stderr] | [INFO] [stderr] 240 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:241:42 [INFO] [stderr] | [INFO] [stderr] 241 | "last_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:242:42 [INFO] [stderr] | [INFO] [stderr] 242 | "average_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:243:35 [INFO] [stderr] | [INFO] [stderr] 243 | "volume": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:244:41 [INFO] [stderr] | [INFO] [stderr] 244 | "buy_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:245:42 [INFO] [stderr] | [INFO] [stderr] 245 | "sell_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | "open": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:248:37 [INFO] [stderr] | [INFO] [stderr] 248 | "high": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:249:36 [INFO] [stderr] | [INFO] [stderr] 249 | "low": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:250:38 [INFO] [stderr] | [INFO] [stderr] 250 | "close": reader.read_i32::().unwrap() as f64 / divisor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:256:76 [INFO] [stderr] | [INFO] [stderr] 256 | data["change"] = json!((last_price - ohlc_close) * 100 as f64 / ohlc_close); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:259:57 [INFO] [stderr] | [INFO] [stderr] 259 | data["last_trade_time"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:260:44 [INFO] [stderr] | [INFO] [stderr] 260 | data["oi"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:261:53 [INFO] [stderr] | [INFO] [stderr] 261 | data["oi_day_high"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:262:52 [INFO] [stderr] | [INFO] [stderr] 262 | data["oi_day_low"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:263:51 [INFO] [stderr] | [INFO] [stderr] 263 | data["timestamp"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:270:45 [INFO] [stderr] | [INFO] [stderr] 270 | "quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:271:42 [INFO] [stderr] | [INFO] [stderr] 271 | "price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | "orders": reader.read_i16::().unwrap() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i16::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:147:42 [INFO] [stderr] | [INFO] [stderr] 147 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/connect.rs:188:42 [INFO] [stderr] | [INFO] [stderr] 188 | Err(ErrorKind::KiteException(format!("{}", resp.text()?)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `resp.text()?.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/connect.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | / pub fn place_order( [INFO] [stderr] 241 | | &self, [INFO] [stderr] 242 | | exchange: &str, [INFO] [stderr] 243 | | tradingsymbol: &str, [INFO] [stderr] ... | [INFO] [stderr] 278 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/connect.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn modify_order( [INFO] [stderr] 283 | | &self, [INFO] [stderr] 284 | | order_id: &str, [INFO] [stderr] 285 | | variety: &str, [INFO] [stderr] ... | [INFO] [stderr] 316 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/connect.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | / pub fn convert_position( [INFO] [stderr] 383 | | &self, [INFO] [stderr] 384 | | exchange: &str, [INFO] [stderr] 385 | | tradingsymbol: &str, [INFO] [stderr] ... | [INFO] [stderr] 404 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 405 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | / let url: reqwest::Url; [INFO] [stderr] 410 | | if order_id.is_some() { [INFO] [stderr] 411 | | url = self.build_url(format!("/mf/orders/{}", order_id.unwrap()).as_str(), None); [INFO] [stderr] 412 | | } else { [INFO] [stderr] 413 | | url = self.build_url("/mf/orders", None); [INFO] [stderr] 414 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if order_id.is_some() { self.build_url(format!("/mf/orders/{}", order_id.unwrap()).as_str(), None) } else { self.build_url("/mf/orders", None) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:452:9 [INFO] [stderr] | [INFO] [stderr] 452 | / let url: reqwest::Url; [INFO] [stderr] 453 | | if sip_id.is_some() { [INFO] [stderr] 454 | | url = self.build_url(format!("/mf/sips/{}", sip_id.unwrap()).as_str(), None); [INFO] [stderr] 455 | | } else { [INFO] [stderr] 456 | | url = self.build_url("/mf/sips", None); [INFO] [stderr] 457 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if sip_id.is_some() { self.build_url(format!("/mf/sips/{}", sip_id.unwrap()).as_str(), None) } else { self.build_url("/mf/sips", None) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/connect.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn place_mf_sip( [INFO] [stderr] 465 | | &self, [INFO] [stderr] 466 | | tradingsymbol: &str, [INFO] [stderr] 467 | | amount: &str, [INFO] [stderr] ... | [INFO] [stderr] 486 | | self._raise_or_return_json(&mut resp) [INFO] [stderr] 487 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/connect.rs:564:9 [INFO] [stderr] | [INFO] [stderr] 564 | / let url: reqwest::Url; [INFO] [stderr] 565 | | if exchange.is_some() { [INFO] [stderr] 566 | | url = self.build_url(format!("/instruments{}", exchange.unwrap()).as_str(), None); [INFO] [stderr] 567 | | } else { [INFO] [stderr] 568 | | url = self.build_url("/instruments", None); [INFO] [stderr] 569 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let url = if exchange.is_some() { self.build_url(format!("/instruments{}", exchange.unwrap()).as_str(), None) } else { self.build_url("/instruments", None) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/ticker.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | modes.entry(mode.clone()).or_insert(vec![]).push(token.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/ticker.rs:145:51 [INFO] [stderr] | [INFO] [stderr] 145 | *self.subscribed_tokens.entry(*token).or_insert("".to_string()) = mode.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ticker.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(debug!("Sender not bound to the instance")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ticker.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / let mut divisor: f64 = 100.0; [INFO] [stderr] 188 | | if segment == 3 { // cds [INFO] [stderr] 189 | | divisor = 10000000.0; [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let divisor = if segment == 3 { 10000000.0 } else { 100.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ticker.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / let mut tradable = true; [INFO] [stderr] 192 | | if segment == 9 { // indices [INFO] [stderr] 193 | | tradable = false; [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let tradable = if segment == 9 { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:213:39 [INFO] [stderr] | [INFO] [stderr] 213 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:215:37 [INFO] [stderr] | [INFO] [stderr] 215 | "high": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:216:36 [INFO] [stderr] | [INFO] [stderr] 216 | "low": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:217:37 [INFO] [stderr] | [INFO] [stderr] 217 | "open": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:218:38 [INFO] [stderr] | [INFO] [stderr] 218 | "close": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:225:76 [INFO] [stderr] | [INFO] [stderr] 225 | data["change"] = json!((last_price - ohlc_close) * 100 as f64 / ohlc_close); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:228:51 [INFO] [stderr] | [INFO] [stderr] 228 | data["timestamp"] = json!(reader.read_i32::().unwrap() as f64 / divisor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:240:39 [INFO] [stderr] | [INFO] [stderr] 240 | "last_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:241:42 [INFO] [stderr] | [INFO] [stderr] 241 | "last_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:242:42 [INFO] [stderr] | [INFO] [stderr] 242 | "average_price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:243:35 [INFO] [stderr] | [INFO] [stderr] 243 | "volume": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:244:41 [INFO] [stderr] | [INFO] [stderr] 244 | "buy_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:245:42 [INFO] [stderr] | [INFO] [stderr] 245 | "sell_quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | "open": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:248:37 [INFO] [stderr] | [INFO] [stderr] 248 | "high": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:249:36 [INFO] [stderr] | [INFO] [stderr] 249 | "low": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:250:38 [INFO] [stderr] | [INFO] [stderr] 250 | "close": reader.read_i32::().unwrap() as f64 / divisor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:256:76 [INFO] [stderr] | [INFO] [stderr] 256 | data["change"] = json!((last_price - ohlc_close) * 100 as f64 / ohlc_close); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:259:57 [INFO] [stderr] | [INFO] [stderr] 259 | data["last_trade_time"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:260:44 [INFO] [stderr] | [INFO] [stderr] 260 | data["oi"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:261:53 [INFO] [stderr] | [INFO] [stderr] 261 | data["oi_day_high"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:262:52 [INFO] [stderr] | [INFO] [stderr] 262 | data["oi_day_low"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:263:51 [INFO] [stderr] | [INFO] [stderr] 263 | data["timestamp"] = json!(reader.read_i32::().unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:270:45 [INFO] [stderr] | [INFO] [stderr] 270 | "quantity": reader.read_i32::().unwrap() as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:271:42 [INFO] [stderr] | [INFO] [stderr] 271 | "price": reader.read_i32::().unwrap() as f64 / divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ticker.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | "orders": reader.read_i16::().unwrap() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.read_i16::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ticker.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | kiteticker.connect(MyHandler{}, Some("127.0.0.1:3012")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ticker.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | kiteticker.sender.unwrap().send("PING"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `ws::Message` [INFO] [stderr] --> examples/ticker_sample.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use ws::Message; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/ticker_sample.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | ws.subscribe(vec![53511431]); [INFO] [stderr] | ^^^^^^^^ help: consider: `53_511_431` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/ticker_sample.rs:18:34 [INFO] [stderr] | [INFO] [stderr] 18 | ws.set_mode("full", vec![53511431]); [INFO] [stderr] | ^^^^^^^^ help: consider: `53_511_431` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ws` [INFO] [stderr] --> examples/ticker_sample.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | fn on_ticks(&mut self, ws: &mut WebSocketHandler, tick: Vec) [INFO] [stderr] | ^^ help: consider using `_ws` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ws` [INFO] [stderr] --> examples/ticker_sample.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | fn on_close(&mut self, ws: &mut WebSocketHandler) [INFO] [stderr] | ^^ help: consider using `_ws` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ws` [INFO] [stderr] --> examples/ticker_sample.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | fn on_error(&mut self, ws: &mut WebSocketHandler) [INFO] [stderr] | ^^ help: consider using `_ws` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/ticker_sample.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | ws.subscribe(vec![53511431]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/ticker_sample.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | ws.set_mode("full", vec![53511431]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/ticker_sample.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | ticker.connect(custom_handler, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> examples/ticker_sample.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.27s [INFO] running `"docker" "inspect" "122a05b1db23e4c30410ba76ac697ca2149febe8321a8845a43ea048d14149df"` [INFO] running `"docker" "rm" "-f" "122a05b1db23e4c30410ba76ac697ca2149febe8321a8845a43ea048d14149df"` [INFO] [stdout] 122a05b1db23e4c30410ba76ac697ca2149febe8321a8845a43ea048d14149df