[INFO] crate kinto_http 0.1.0 is already in cache [INFO] extracting crate kinto_http 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kinto_http/0.1.0 [INFO] extracting crate kinto_http 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kinto_http/0.1.0 [INFO] validating manifest of kinto_http-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kinto_http-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kinto_http-0.1.0 [INFO] finished frobbing kinto_http-0.1.0 [INFO] frobbed toml for kinto_http-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kinto_http/0.1.0/Cargo.toml [INFO] started frobbing kinto_http-0.1.0 [INFO] finished frobbing kinto_http-0.1.0 [INFO] frobbed toml for kinto_http-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kinto_http/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kinto_http-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kinto_http/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a082cf45d2f45a91eb155a35779872375bb9dbf75b3d7c47c51d9497dc2e3a38 [INFO] running `"docker" "start" "-a" "a082cf45d2f45a91eb155a35779872375bb9dbf75b3d7c47c51d9497dc2e3a38"` [INFO] [stderr] Checking kinto_http v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | server_url: server_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | GetCollection {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | DeleteCollection {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:192:23 [INFO] [stderr] | [INFO] [stderr] 192 | CreateRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:214:20 [INFO] [stderr] | [INFO] [stderr] 214 | GetRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | UpdateRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:253:22 [INFO] [stderr] | [INFO] [stderr] 253 | PatchRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | DeleteRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | BatchRequest { preparer: preparer, requests: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | responses: responses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `responses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bucket.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | Bucket {client: client, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | collection: collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | collection: collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | server_url: server_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | body: body [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | GetCollection {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:171:27 [INFO] [stderr] | [INFO] [stderr] 171 | DeleteCollection {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:192:23 [INFO] [stderr] | [INFO] [stderr] 192 | CreateRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:214:20 [INFO] [stderr] | [INFO] [stderr] 214 | GetRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:233:23 [INFO] [stderr] | [INFO] [stderr] 233 | UpdateRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:253:22 [INFO] [stderr] | [INFO] [stderr] 253 | PatchRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | DeleteRecord {preparer: preparer} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | BatchRequest { preparer: preparer, requests: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `preparer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/batch.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | responses: responses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `responses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bucket.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | Bucket {client: client, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | collection: collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | bucket: bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | collection: collection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return new_client; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return new_client; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return Ok(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(response)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bucket.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Collection::new(self.client.clone(), self, id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Collection::new(self.client.clone(), self, id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bucket.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collection.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return Record::new(self.client.clone(), self, id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Record::new(self.client.clone(), self, id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collection.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return new_client; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return new_client; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return Ok(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(response)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bucket.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Collection::new(self.client.clone(), self, id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Collection::new(self.client.clone(), self, id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bucket.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collection.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return Record::new(self.client.clone(), self, id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Record::new(self.client.clone(), self, id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/collection.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | Err(value) => return Err(value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return ids; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return client; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return client.bucket("food"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `client.bucket("food")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return client.bucket("food").collection("meat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `client.bucket("food").collection("meat")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return client.bucket("food").collection("meat").record("entrecote"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `client.bucket("food").collection("meat").record("entrecote")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.auth.to_owned() { [INFO] [stderr] 92 | | Some(method) => headers.set(method), [INFO] [stderr] 93 | | None => () [INFO] [stderr] 94 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(method) = self.auth.to_owned() { headers.set(method) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/paths.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | format!("/batch"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/batch".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/paths.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | format!("/buckets"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/buckets".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/request.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match preparer.client.auth.to_owned() { [INFO] [stderr] 71 | | Some(method) => headers.set(method), [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(method) = preparer.client.auth.to_owned() { headers.set(method) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/batch.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | "body": req.body.unwrap_or(json!({})), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| json!({}))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | status: batch_wrapper.status.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_wrapper.status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/bucket.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'a>(client: KintoClient, id: &'a str) -> Self { [INFO] [stderr] 50 | | Bucket {client: client, id: id.to_owned(), [INFO] [stderr] 51 | | timestamp: None, data: None, permissions: None} [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bucket.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/collection.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new<'a>(client: KintoClient, bucket: Bucket, id: &'a str) -> Self { [INFO] [stderr] 53 | | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] 54 | | timestamp: None, data: None, permissions: None} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/record.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new<'a>(client: KintoClient, collection: Collection, id: &'a str) -> Self { [INFO] [stderr] 52 | | Record { [INFO] [stderr] 53 | | client: client, [INFO] [stderr] 54 | | bucket: collection.bucket.clone(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/record.rs:119:29 [INFO] [stderr] | [INFO] [stderr] 119 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let mut split = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.auth.to_owned() { [INFO] [stderr] 92 | | Some(method) => headers.set(method), [INFO] [stderr] 93 | | None => () [INFO] [stderr] 94 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(method) = self.auth.to_owned() { headers.set(method) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/paths.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | format!("/batch"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/batch".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/paths.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | format!("/buckets"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/buckets".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/request.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match preparer.client.auth.to_owned() { [INFO] [stderr] 71 | | Some(method) => headers.set(method), [INFO] [stderr] 72 | | None => () [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(method) = preparer.client.auth.to_owned() { headers.set(method) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/batch.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | "body": req.body.unwrap_or(json!({})), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| json!({}))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | status: batch_wrapper.status.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `batch_wrapper.status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/bucket.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'a>(client: KintoClient, id: &'a str) -> Self { [INFO] [stderr] 50 | | Bucket {client: client, id: id.to_owned(), [INFO] [stderr] 51 | | timestamp: None, data: None, permissions: None} [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bucket.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bucket.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match bucket.create() { [INFO] [stderr] 169 | | Ok(_) => panic!(""), [INFO] [stderr] 170 | | Err(_) => () [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = bucket.create() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bucket.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / match bucket.load() { [INFO] [stderr] 194 | | Ok(_) => panic!(""), [INFO] [stderr] 195 | | Err(_) => () [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = bucket.load() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bucket.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | / match bucket.update() { [INFO] [stderr] 218 | | Ok(_) => panic!(""), [INFO] [stderr] 219 | | Err(_) => () [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = bucket.update() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/collection.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new<'a>(client: KintoClient, bucket: Bucket, id: &'a str) -> Self { [INFO] [stderr] 53 | | Collection {client: client, bucket: bucket, id: id.to_owned(), [INFO] [stderr] 54 | | timestamp: None, data: None, permissions: None} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/collection.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match collection.create() { [INFO] [stderr] 180 | | Ok(_) => panic!(""), [INFO] [stderr] 181 | | Err(_) => () [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = collection.create() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/collection.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match collection.load() { [INFO] [stderr] 205 | | Ok(_) => panic!(""), [INFO] [stderr] 206 | | Err(_) => () [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = collection.load() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/collection.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / match collection.update() { [INFO] [stderr] 229 | | Ok(_) => panic!(""), [INFO] [stderr] 230 | | Err(_) => () [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = collection.update() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/record.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new<'a>(client: KintoClient, collection: Collection, id: &'a str) -> Self { [INFO] [stderr] 52 | | Record { [INFO] [stderr] 53 | | client: client, [INFO] [stderr] 54 | | bucket: collection.bucket.clone(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/record.rs:119:29 [INFO] [stderr] | [INFO] [stderr] 119 | timestamp: Some(timestamp.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/record.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match record.create() { [INFO] [stderr] 152 | | Ok(_) => panic!(""), [INFO] [stderr] 153 | | Err(_) => () [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = record.create() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/record.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / match record.load() { [INFO] [stderr] 177 | | Ok(_) => panic!(""), [INFO] [stderr] 178 | | Err(_) => () [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = record.load() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/record.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match record.update() { [INFO] [stderr] 201 | | Ok(_) => panic!(""), [INFO] [stderr] 202 | | Err(_) => () [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = record.update() { panic!("") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let mut split = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.92s [INFO] running `"docker" "inspect" "a082cf45d2f45a91eb155a35779872375bb9dbf75b3d7c47c51d9497dc2e3a38"` [INFO] running `"docker" "rm" "-f" "a082cf45d2f45a91eb155a35779872375bb9dbf75b3d7c47c51d9497dc2e3a38"` [INFO] [stdout] a082cf45d2f45a91eb155a35779872375bb9dbf75b3d7c47c51d9497dc2e3a38