[INFO] crate kgb 0.0.10 is already in cache [INFO] extracting crate kgb 0.0.10 into work/ex/clippy-test-run/sources/stable/reg/kgb/0.0.10 [INFO] extracting crate kgb 0.0.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kgb/0.0.10 [INFO] validating manifest of kgb-0.0.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kgb-0.0.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kgb-0.0.10 [INFO] finished frobbing kgb-0.0.10 [INFO] frobbed toml for kgb-0.0.10 written to work/ex/clippy-test-run/sources/stable/reg/kgb/0.0.10/Cargo.toml [INFO] started frobbing kgb-0.0.10 [INFO] finished frobbing kgb-0.0.10 [INFO] frobbed toml for kgb-0.0.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kgb/0.0.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kgb-0.0.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kgb/0.0.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a8b7d3d3d0d18b1a62f8763cb5324700ea7b494ff76ba3215d6a21fd459403a [INFO] running `"docker" "start" "-a" "3a8b7d3d3d0d18b1a62f8763cb5324700ea7b494ff76ba3215d6a21fd459403a"` [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking nya v0.7.1 [INFO] [stderr] Checking assert_cli v0.6.3 [INFO] [stderr] Checking comrak v0.2.14 [INFO] [stderr] Checking kgb v0.0.10 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filei18n.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | if rest2.len() > 0 && is_iso6391_code(last2) && last == &"md" { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest2.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontmatter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match text.starts_with("---\n") { [INFO] [stderr] 18 | | true => { [INFO] [stderr] 19 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 20 | | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | false => None, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 17 | if text.starts_with("---\n") { [INFO] [stderr] 18 | let slice_after_marker = &text[4..]; [INFO] [stderr] 19 | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] 20 | let yaml_slice = &text[4..marker_end + 4]; [INFO] [stderr] 21 | let content_slice = &text[marker_end + 2 * 4..]; [INFO] [stderr] 22 | Some(( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/frontmatter.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serialize(matter: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Yaml]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frontmatter.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn deserialize(matter: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbars.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | .unwrap_or(vec![String::from("en")]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![String::from("en")])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | &ctxmap.insert("en", t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctxmap.insert("en", t);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | &ctxmap.insert(&locales[i], t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctxmap.insert(&locales[i], t);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbars.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | .unwrap_or("My Site".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "My Site".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | &filevec.push(file_struct); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filevec.push(file_struct);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | &filevec.push(file_struct); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filevec.push(file_struct);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/layouts.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(_) = de[0].as_hash().unwrap().get(&Yaml::from_str("layout")) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 41 | | has_layout = true; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________- help: try this: `if de[0].as_hash().unwrap().get(&Yaml::from_str("layout")).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/util.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / let mut result = false; [INFO] [stderr] 21 | | if path.extension().unwrap() == "hbs" { [INFO] [stderr] 22 | | result = true; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if path.extension().unwrap() == "hbs" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/util.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | if path.iter().any(|s| { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | let st = s.to_str().unwrap(); [INFO] [stderr] 27 | | st == "_layouts" || st == "_locales" || st == "_config.toml" [INFO] [stderr] 28 | | }) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / let mut source; [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if matches.is_present("SOURCE") { [INFO] [stderr] 46 | | source = matches.value_of("SOURCE").unwrap(); [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | source = cdir.to_str().unwrap(); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let source = if matches.is_present("SOURCE") { matches.value_of("SOURCE").unwrap() } else { cdir.to_str().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let mut config_ignores: Vec = config.get("ignore").unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `config.get("ignore").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/filei18n.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | if rest2.len() > 0 && is_iso6391_code(last2) && last == &"md" { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest2.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontmatter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match text.starts_with("---\n") { [INFO] [stderr] 18 | | true => { [INFO] [stderr] 19 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 20 | | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | false => None, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 17 | if text.starts_with("---\n") { [INFO] [stderr] 18 | let slice_after_marker = &text[4..]; [INFO] [stderr] 19 | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] 20 | let yaml_slice = &text[4..marker_end + 4]; [INFO] [stderr] 21 | let content_slice = &text[marker_end + 2 * 4..]; [INFO] [stderr] 22 | Some(( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/frontmatter.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serialize(matter: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Yaml]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frontmatter.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn deserialize(matter: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbars.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | .unwrap_or(vec![String::from("en")]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![String::from("en")])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | &ctxmap.insert("en", t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctxmap.insert("en", t);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | &ctxmap.insert(&locales[i], t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ctxmap.insert(&locales[i], t);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbars.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | .unwrap_or("My Site".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "My Site".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | &filevec.push(file_struct); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filevec.push(file_struct);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/hbars.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | &filevec.push(file_struct); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filevec.push(file_struct);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/layouts.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(_) = de[0].as_hash().unwrap().get(&Yaml::from_str("layout")) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 41 | | has_layout = true; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________- help: try this: `if de[0].as_hash().unwrap().get(&Yaml::from_str("layout")).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/util.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / let mut result = false; [INFO] [stderr] 21 | | if path.extension().unwrap() == "hbs" { [INFO] [stderr] 22 | | result = true; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if path.extension().unwrap() == "hbs" { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/util.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | if path.iter().any(|s| { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | let st = s.to_str().unwrap(); [INFO] [stderr] 27 | | st == "_layouts" || st == "_locales" || st == "_config.toml" [INFO] [stderr] 28 | | }) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / let mut source; [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if matches.is_present("SOURCE") { [INFO] [stderr] 46 | | source = matches.value_of("SOURCE").unwrap(); [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | source = cdir.to_str().unwrap(); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let source = if matches.is_present("SOURCE") { matches.value_of("SOURCE").unwrap() } else { cdir.to_str().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let mut config_ignores: Vec = config.get("ignore").unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `config.get("ignore").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.04s [INFO] running `"docker" "inspect" "3a8b7d3d3d0d18b1a62f8763cb5324700ea7b494ff76ba3215d6a21fd459403a"` [INFO] running `"docker" "rm" "-f" "3a8b7d3d3d0d18b1a62f8763cb5324700ea7b494ff76ba3215d6a21fd459403a"` [INFO] [stdout] 3a8b7d3d3d0d18b1a62f8763cb5324700ea7b494ff76ba3215d6a21fd459403a