[INFO] crate kg 0.0.5 is already in cache [INFO] extracting crate kg 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/kg/0.0.5 [INFO] extracting crate kg 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kg/0.0.5 [INFO] validating manifest of kg-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kg-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kg-0.0.5 [INFO] finished frobbing kg-0.0.5 [INFO] frobbed toml for kg-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/kg/0.0.5/Cargo.toml [INFO] started frobbing kg-0.0.5 [INFO] finished frobbing kg-0.0.5 [INFO] frobbed toml for kg-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kg/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kg-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kg/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5ee858b84c5558323a8ddeee460e7bc9aaa4b9e4e4c55a6aa11e4da871094be [INFO] running `"docker" "start" "-a" "d5ee858b84c5558323a8ddeee460e7bc9aaa4b9e4e4c55a6aa11e4da871094be"` [INFO] [stderr] Checking config v0.9.2 [INFO] [stderr] Checking comrak v0.2.14 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking nya v0.6.0 [INFO] [stderr] Checking kg v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontmatter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match text.starts_with("---\n") { [INFO] [stderr] 18 | | true => { [INFO] [stderr] 19 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 20 | | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | false => None, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 17 | if text.starts_with("---\n") { [INFO] [stderr] 18 | let slice_after_marker = &text[4..]; [INFO] [stderr] 19 | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] 20 | let yaml_slice = &text[4..marker_end + 4]; [INFO] [stderr] 21 | let content_slice = &text[marker_end + 2 * 4..]; [INFO] [stderr] 22 | Some(( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/frontmatter.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serialize(matter: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Yaml]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frontmatter.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn deserialize(matter: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/frontmatter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match text.starts_with("---\n") { [INFO] [stderr] 18 | | true => { [INFO] [stderr] 19 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 20 | | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 28 | | false => None, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 17 | if text.starts_with("---\n") { [INFO] [stderr] 18 | let slice_after_marker = &text[4..]; [INFO] [stderr] 19 | let marker_end = slice_after_marker.find("---\n").unwrap(); [INFO] [stderr] 20 | let yaml_slice = &text[4..marker_end + 4]; [INFO] [stderr] 21 | let content_slice = &text[marker_end + 2 * 4..]; [INFO] [stderr] 22 | Some(( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/frontmatter.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn serialize(matter: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Yaml]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frontmatter.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn deserialize(matter: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.67s [INFO] running `"docker" "inspect" "d5ee858b84c5558323a8ddeee460e7bc9aaa4b9e4e4c55a6aa11e4da871094be"` [INFO] running `"docker" "rm" "-f" "d5ee858b84c5558323a8ddeee460e7bc9aaa4b9e4e4c55a6aa11e4da871094be"` [INFO] [stdout] d5ee858b84c5558323a8ddeee460e7bc9aaa4b9e4e4c55a6aa11e4da871094be