[INFO] crate keygen 2.1.0 is already in cache
[INFO] extracting crate keygen 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/keygen/2.1.0
[INFO] extracting crate keygen 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/keygen/2.1.0
[INFO] validating manifest of keygen-2.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of keygen-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing keygen-2.1.0
[INFO] finished frobbing keygen-2.1.0
[INFO] frobbed toml for keygen-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/keygen/2.1.0/Cargo.toml
[INFO] started frobbing keygen-2.1.0
[INFO] finished frobbing keygen-2.1.0
[INFO] frobbed toml for keygen-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/keygen/2.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting keygen-2.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/keygen/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2fab841e94f54bd7c462df188ccf1c08c0061fd7fac5b8f64c805e5a90c45daa
[INFO] running `"docker" "start" "-a" "2fab841e94f54bd7c462df188ccf1c08c0061fd7fac5b8f64c805e5a90c45daa"`
[INFO] [stderr]     Checking serial-key v2.0.0
[INFO] [stderr]     Checking keygen v2.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             num_bytes: num_bytes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             num_bytes: num_bytes,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:225:25
[INFO] [stderr]     |
[INFO] [stderr] 225 | /                         let mut blacklist: Vec<String> = vec![];
[INFO] [stderr] 226 | |                         if matches.is_present("blacklist") {
[INFO] [stderr] 227 | |                             // convert Vec<str> to Vec<String>
[INFO] [stderr] 228 | |                             blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect();
[INFO] [stderr] 229 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:233:63
[INFO] [stderr]     |
[INFO] [stderr] 233 |                                 let bytes: Vec<i16> = s.split(",").map(|s| s.parse().unwrap()).collect();
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:277:30
[INFO] [stderr]     |
[INFO] [stderr] 277 |                   let config = match matches.is_present("config") {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 278 | |                     true => {
[INFO] [stderr] 279 | |                         // read existing config
[INFO] [stderr] 280 | |                         let path = matches.value_of("config").unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 317 | |                     }
[INFO] [stderr] 318 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 277 |                 let config = if matches.is_present("config") {
[INFO] [stderr] 278 |     // read existing config
[INFO] [stderr] 279 |     let path = matches.value_of("config").unwrap();
[INFO] [stderr] 280 |     match read_config_from_file(Path::new(path)) {
[INFO] [stderr] 281 |         Ok(config) => config,
[INFO] [stderr] 282 |         Err(e) => panic!("Error reading config: {:?}", e)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:292:25
[INFO] [stderr]     |
[INFO] [stderr] 292 | /                         let mut blacklist: Vec<String> = vec![];
[INFO] [stderr] 293 | |                         if matches.is_present("blacklist") {
[INFO] [stderr] 294 | |                             // convert Vec<str> to Vec<String>
[INFO] [stderr] 295 | |                             blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect();
[INFO] [stderr] 296 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:301:63
[INFO] [stderr]     |
[INFO] [stderr] 301 |                                 let bytes: Vec<i16> = s.split(",").map(|s| s.parse().unwrap()).collect();
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:321:28
[INFO] [stderr]     |
[INFO] [stderr] 321 |                 let seed = crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()) as i64;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:225:25
[INFO] [stderr]     |
[INFO] [stderr] 225 | /                         let mut blacklist: Vec<String> = vec![];
[INFO] [stderr] 226 | |                         if matches.is_present("blacklist") {
[INFO] [stderr] 227 | |                             // convert Vec<str> to Vec<String>
[INFO] [stderr] 228 | |                             blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect();
[INFO] [stderr] 229 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:233:63
[INFO] [stderr]     |
[INFO] [stderr] 233 |                                 let bytes: Vec<i16> = s.split(",").map(|s| s.parse().unwrap()).collect();
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:277:30
[INFO] [stderr]     |
[INFO] [stderr] 277 |                   let config = match matches.is_present("config") {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 278 | |                     true => {
[INFO] [stderr] 279 | |                         // read existing config
[INFO] [stderr] 280 | |                         let path = matches.value_of("config").unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 317 | |                     }
[INFO] [stderr] 318 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 277 |                 let config = if matches.is_present("config") {
[INFO] [stderr] 278 |     // read existing config
[INFO] [stderr] 279 |     let path = matches.value_of("config").unwrap();
[INFO] [stderr] 280 |     match read_config_from_file(Path::new(path)) {
[INFO] [stderr] 281 |         Ok(config) => config,
[INFO] [stderr] 282 |         Err(e) => panic!("Error reading config: {:?}", e)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:292:25
[INFO] [stderr]     |
[INFO] [stderr] 292 | /                         let mut blacklist: Vec<String> = vec![];
[INFO] [stderr] 293 | |                         if matches.is_present("blacklist") {
[INFO] [stderr] 294 | |                             // convert Vec<str> to Vec<String>
[INFO] [stderr] 295 | |                             blacklist = matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect();
[INFO] [stderr] 296 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> blacklist = if matches.is_present("blacklist") { matches.values_of("blacklist").unwrap().map(|s| s.to_string()).collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:301:63
[INFO] [stderr]     |
[INFO] [stderr] 301 |                                 let bytes: Vec<i16> = s.split(",").map(|s| s.parse().unwrap()).collect();
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:321:28
[INFO] [stderr]     |
[INFO] [stderr] 321 |                 let seed = crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()) as i64;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(crc32::checksum_ieee(format!("{}+{}", input, &config.hash).as_bytes()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.70s
[INFO] running `"docker" "inspect" "2fab841e94f54bd7c462df188ccf1c08c0061fd7fac5b8f64c805e5a90c45daa"`
[INFO] running `"docker" "rm" "-f" "2fab841e94f54bd7c462df188ccf1c08c0061fd7fac5b8f64c805e5a90c45daa"`
[INFO] [stdout] 2fab841e94f54bd7c462df188ccf1c08c0061fd7fac5b8f64c805e5a90c45daa