[INFO] crate ketree 0.5.2 is already in cache [INFO] extracting crate ketree 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/ketree/0.5.2 [INFO] extracting crate ketree 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ketree/0.5.2 [INFO] validating manifest of ketree-0.5.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ketree-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ketree-0.5.2 [INFO] finished frobbing ketree-0.5.2 [INFO] frobbed toml for ketree-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/ketree/0.5.2/Cargo.toml [INFO] started frobbing ketree-0.5.2 [INFO] finished frobbing ketree-0.5.2 [INFO] frobbed toml for ketree-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ketree/0.5.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ketree-0.5.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ketree/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 240d509b00592e412d56f941c6da782ef431865bdaca0c097b252efaf34aa033 [INFO] running `"docker" "start" "-a" "240d509b00592e412d56f941c6da782ef431865bdaca0c097b252efaf34aa033"` [INFO] [stderr] Checking gumdrop v0.1.0 [INFO] [stderr] Compiling gumdrop_derive v0.1.0 [INFO] [stderr] Compiling ketos_derive v0.10.0 [INFO] [stderr] Checking linefeed v0.2.6 [INFO] [stderr] Checking ketos v0.10.0 [INFO] [stderr] Checking ketree v0.5.2 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/ketree/tree.rs:219:68 [INFO] [stderr] | [INFO] [stderr] 219 | #[derive(Clone, Debug, ForeignValue, FromValueClone, FromValueRef, StructValue)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | / match i.data() { [INFO] [stderr] 237 | | &Expression::Operator(ref f) => { [INFO] [stderr] 238 | | let minks = match i.children() { [INFO] [stderr] 239 | | &Some(ref m) => m, [INFO] [stderr] ... | [INFO] [stderr] 250 | | &Expression::Constant(ref c) => yeta.push(c.clone()), [INFO] [stderr] 251 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 236 | match *i.data() { [INFO] [stderr] 237 | Expression::Operator(ref f) => { [INFO] [stderr] 238 | let minks = match i.children() { [INFO] [stderr] 239 | &Some(ref m) => m, [INFO] [stderr] 240 | &None => { panic!("Operator found no operands"); }, [INFO] [stderr] 241 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:238:33 [INFO] [stderr] | [INFO] [stderr] 238 | let minks = match i.children() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 239 | | &Some(ref m) => m, [INFO] [stderr] 240 | | &None => { panic!("Operator found no operands"); }, [INFO] [stderr] 241 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | let minks = match *i.children() { [INFO] [stderr] 239 | Some(ref m) => m, [INFO] [stderr] 240 | None => { panic!("Operator found no operands"); }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:315:24 [INFO] [stderr] | [INFO] [stderr] 315 | clen = match nbr.children() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 316 | | &Some(ref vc) => vc.len(), [INFO] [stderr] 317 | | &None => 0, [INFO] [stderr] 318 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 315 | clen = match *nbr.children() { [INFO] [stderr] 316 | Some(ref vc) => vc.len(), [INFO] [stderr] 317 | None => 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | / if let &Some(ref vc) = self.tree_stack[self.tree_stack.len() - 1].children() { [INFO] [stderr] 322 | | self.tree_stack.push(&vc[self.pos_stack[self.pos_stack.len() - 1]]); [INFO] [stderr] 323 | | self.pos_stack.push(0); [INFO] [stderr] 324 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 327 | | panic!("Iteration failed unexpectedly"); [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | if let Some(ref vc) = *self.tree_stack[self.tree_stack.len() - 1].children() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ketree/tree.rs:336:16 [INFO] [stderr] | [INFO] [stderr] 336 | if 0 == self.tree_stack.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tree_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/ketree/tree.rs:219:68 [INFO] [stderr] | [INFO] [stderr] 219 | #[derive(Clone, Debug, ForeignValue, FromValueClone, FromValueRef, StructValue)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | / match i.data() { [INFO] [stderr] 237 | | &Expression::Operator(ref f) => { [INFO] [stderr] 238 | | let minks = match i.children() { [INFO] [stderr] 239 | | &Some(ref m) => m, [INFO] [stderr] ... | [INFO] [stderr] 250 | | &Expression::Constant(ref c) => yeta.push(c.clone()), [INFO] [stderr] 251 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 236 | match *i.data() { [INFO] [stderr] 237 | Expression::Operator(ref f) => { [INFO] [stderr] 238 | let minks = match i.children() { [INFO] [stderr] 239 | &Some(ref m) => m, [INFO] [stderr] 240 | &None => { panic!("Operator found no operands"); }, [INFO] [stderr] 241 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:238:33 [INFO] [stderr] | [INFO] [stderr] 238 | let minks = match i.children() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 239 | | &Some(ref m) => m, [INFO] [stderr] 240 | | &None => { panic!("Operator found no operands"); }, [INFO] [stderr] 241 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | let minks = match *i.children() { [INFO] [stderr] 239 | Some(ref m) => m, [INFO] [stderr] 240 | None => { panic!("Operator found no operands"); }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:315:24 [INFO] [stderr] | [INFO] [stderr] 315 | clen = match nbr.children() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 316 | | &Some(ref vc) => vc.len(), [INFO] [stderr] 317 | | &None => 0, [INFO] [stderr] 318 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 315 | clen = match *nbr.children() { [INFO] [stderr] 316 | Some(ref vc) => vc.len(), [INFO] [stderr] 317 | None => 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ketree/tree.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | / if let &Some(ref vc) = self.tree_stack[self.tree_stack.len() - 1].children() { [INFO] [stderr] 322 | | self.tree_stack.push(&vc[self.pos_stack[self.pos_stack.len() - 1]]); [INFO] [stderr] 323 | | self.pos_stack.push(0); [INFO] [stderr] 324 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 327 | | panic!("Iteration failed unexpectedly"); [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | if let Some(ref vc) = *self.tree_stack[self.tree_stack.len() - 1].children() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ketree/tree.rs:336:16 [INFO] [stderr] | [INFO] [stderr] 336 | if 0 == self.tree_stack.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tree_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/build.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / match piter.next() { [INFO] [stderr] 50 | | Some(_) => panic!("Iterator returned value that was not None"), [INFO] [stderr] 51 | | None => {}, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(_) = piter.next() { panic!("Iterator returned value that was not None") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/build.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(6.0, result.0.accumulate(&vars).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/build.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(6.0, result.0.accumulate(&vars).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ketree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "240d509b00592e412d56f941c6da782ef431865bdaca0c097b252efaf34aa033"` [INFO] running `"docker" "rm" "-f" "240d509b00592e412d56f941c6da782ef431865bdaca0c097b252efaf34aa033"` [INFO] [stdout] 240d509b00592e412d56f941c6da782ef431865bdaca0c097b252efaf34aa033