[INFO] crate kelp 0.1.0 is already in cache [INFO] extracting crate kelp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kelp/0.1.0 [INFO] extracting crate kelp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kelp/0.1.0 [INFO] validating manifest of kelp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kelp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kelp-0.1.0 [INFO] finished frobbing kelp-0.1.0 [INFO] frobbed toml for kelp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kelp/0.1.0/Cargo.toml [INFO] started frobbing kelp-0.1.0 [INFO] finished frobbing kelp-0.1.0 [INFO] frobbed toml for kelp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kelp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kelp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kelp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2f81b467a3f79b226cb9df1b0a13bacca91e5ca0483f7def5c204ceb91362a7 [INFO] running `"docker" "start" "-a" "c2f81b467a3f79b226cb9df1b0a13bacca91e5ca0483f7def5c204ceb91362a7"` [INFO] [stderr] Checking kelp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `conv_option::ConvOptionBuilder` [INFO] [stderr] --> src/conv_option.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | ConvOptionBuilder { [INFO] [stderr] 125 | | ascii: false, [INFO] [stderr] 126 | | digit: false, [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/convert.rs:195:50 [INFO] [stderr] | [INFO] [stderr] 195 | let ignore: Vec = option.ignore_chars().into_iter().map(|c| *c as u32).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `conv_option::ConvOptionBuilder` [INFO] [stderr] --> src/conv_option.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Self { [INFO] [stderr] 124 | | ConvOptionBuilder { [INFO] [stderr] 125 | | ascii: false, [INFO] [stderr] 126 | | digit: false, [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:244:20 [INFO] [stderr] | [INFO] [stderr] 244 | assert_eq!(table.get(&65313).unwrap(), "A"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65313]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(table.get(&65296).unwrap(), "0"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65296]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(table.get(&12460).unwrap(), "ガ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12460]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:253:20 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(table.get(&65314).unwrap(), "B"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65314]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(table.get(&65315).unwrap(), "C"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65315]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | assert_eq!(table.get(&65298).unwrap(), "2"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65298]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | assert_eq!(table.get(&65316).unwrap(), "D"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65316]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(table.get(&12463).unwrap(), "ク"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12463]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(table.get(&65300).unwrap(), "4"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65300]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | assert_eq!(table.get(&65301).unwrap(), "5"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65301]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(table.get(&12465).unwrap(), "ケ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12465]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:300:20 [INFO] [stderr] | [INFO] [stderr] 300 | assert_eq!(table.get(&12466).unwrap(), "ゲ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12466]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:307:20 [INFO] [stderr] | [INFO] [stderr] 307 | assert_eq!(table.get(&97).unwrap(), "a"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&97]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:308:20 [INFO] [stderr] | [INFO] [stderr] 308 | assert_eq!(table.get(&48).unwrap(), "0"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&48]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | assert_eq!(table.get(&65393).unwrap(), "ア"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65393]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:316:20 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(table.get(&98).unwrap(), "b"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&98]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:325:20 [INFO] [stderr] | [INFO] [stderr] 325 | assert_eq!(table.get(&99).unwrap(), "c"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&99]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | assert_eq!(table.get(&50).unwrap(), "2"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&50]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:334:20 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(table.get(&100).unwrap(), "d"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&100]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:336:20 [INFO] [stderr] | [INFO] [stderr] 336 | assert_eq!(table.get(&65396).unwrap(), "エ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65396]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:344:20 [INFO] [stderr] | [INFO] [stderr] 344 | assert_eq!(table.get(&52).unwrap(), "4"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&52]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:353:20 [INFO] [stderr] | [INFO] [stderr] 353 | assert_eq!(table.get(&53).unwrap(), "5"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&53]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:354:20 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(table.get(&65398).unwrap(), "カ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65398]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:363:20 [INFO] [stderr] | [INFO] [stderr] 363 | assert_eq!(table.get(&65399).unwrap(), "キ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&65399]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:370:20 [INFO] [stderr] | [INFO] [stderr] 370 | assert_eq!(table.get(&12354).unwrap(), "ア"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12354]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:377:20 [INFO] [stderr] | [INFO] [stderr] 377 | assert_eq!(table.get(&12355).unwrap(), "ィ"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12355]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/conv_table.rs:384:20 [INFO] [stderr] | [INFO] [stderr] 384 | assert_eq!(table.get(&12531).unwrap(), "ん"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table[&12531]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/convert.rs:195:50 [INFO] [stderr] | [INFO] [stderr] 195 | let ignore: Vec = option.ignore_chars().into_iter().map(|c| *c as u32).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "c2f81b467a3f79b226cb9df1b0a13bacca91e5ca0483f7def5c204ceb91362a7"` [INFO] running `"docker" "rm" "-f" "c2f81b467a3f79b226cb9df1b0a13bacca91e5ca0483f7def5c204ceb91362a7"` [INFO] [stdout] c2f81b467a3f79b226cb9df1b0a13bacca91e5ca0483f7def5c204ceb91362a7