[INFO] crate keepass 0.1.2 is already in cache [INFO] extracting crate keepass 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/keepass/0.1.2 [INFO] extracting crate keepass 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/keepass/0.1.2 [INFO] validating manifest of keepass-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of keepass-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing keepass-0.1.2 [INFO] finished frobbing keepass-0.1.2 [INFO] frobbed toml for keepass-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/keepass/0.1.2/Cargo.toml [INFO] started frobbing keepass-0.1.2 [INFO] finished frobbing keepass-0.1.2 [INFO] frobbed toml for keepass-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/keepass/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting keepass-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/keepass/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cb117bf6120a79b09db34cebbc64bea94d1d568ce6c3642d42e7c93df2e1f5a [INFO] running `"docker" "start" "-a" "0cb117bf6120a79b09db34cebbc64bea94d1d568ce6c3642d42e7c93df2e1f5a"` [INFO] [stderr] Checking secstr v0.2.1 [INFO] [stderr] Checking keepass v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / fn new(&self, key: &[u8], iv: &[u8]) -> Box { [INFO] [stderr] 17 | | cbc_decryptor(KeySize::KeySize256, key, iv, PkcsPadding) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / fn new(&self, key: &[u8], iv: &[u8]) -> Box { [INFO] [stderr] 25 | | Box::new(Salsa20::new(key, iv)) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn new(&self, _: &[u8], _: &[u8]) -> Box { [INFO] [stderr] 33 | | Box::new(NoOpDecryptor) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decrypt.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | let mut key: [u8; 32] = composite_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `composite_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &DecompressionError::Io(ref e) => write!(f, "I/O error during decompression: {}", e), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | DecompressionError::Io(ref e) => write!(f, "I/O error during decompression: {}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &DecompressionError::Io(ref e) => e.description(), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | DecompressionError::Io(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &DecompressionError::Io(ref e) => Some(e), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | DecompressionError::Io(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/decompress.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(in_buffer.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/xmlparse.rs:70:57 [INFO] [stderr] | [INFO] [stderr] 70 | .map_or(false, |v| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 71 | | v.to_lowercase().parse::().unwrap_or(false) [INFO] [stderr] 72 | | }) { [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/xmlparse.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | if attributes.into_iter() [INFO] [stderr] | ____________________________^ [INFO] [stderr] 67 | | .filter(|oa| oa.name.local_name == "Protected") [INFO] [stderr] 68 | | .next() [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|oa| oa.name.local_name == "Protected").next()` with `find(|oa| oa.name.local_name == "Protected")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/xmlparse.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | if attributes.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xmlparse.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | } else if let None = parsed_stack_head { [INFO] [stderr] | ____________________________________- ^^^^ [INFO] [stderr] 112 | | // There is no more parent nodes left -> we are at the root [INFO] [stderr] 113 | | root_group = finished_group; [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________________- help: try this: `if parsed_stack_head.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &OpenDBError::Io(ref e) => write!(f, "I/O error: {}", e), [INFO] [stderr] 83 | | &OpenDBError::Compression(_) => write!(f, "Decompression error"), [INFO] [stderr] 84 | | &OpenDBError::Crypto(_) => write!(f, "Decryption error"), [INFO] [stderr] ... | [INFO] [stderr] 97 | | &OpenDBError::BlockHashMismatch => write!(f, "Block hash verification failed"), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | OpenDBError::Io(ref e) => write!(f, "I/O error: {}", e), [INFO] [stderr] 83 | OpenDBError::Compression(_) => write!(f, "Decompression error"), [INFO] [stderr] 84 | OpenDBError::Crypto(_) => write!(f, "Decryption error"), [INFO] [stderr] 85 | OpenDBError::IncorrectKey => write!(f, "Incorrect key"), [INFO] [stderr] 86 | OpenDBError::InvalidIdentifier => write!(f, "Invalid file header - not a .kdbx file?"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self { [INFO] [stderr] 105 | | &OpenDBError::Io(ref e) => e.description(), [INFO] [stderr] 106 | | &OpenDBError::Compression(ref e) => e.description(), [INFO] [stderr] 107 | | &OpenDBError::Crypto(_) => "decryption error", [INFO] [stderr] ... | [INFO] [stderr] 114 | | &OpenDBError::BlockHashMismatch => "block hash verification failed", [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *self { [INFO] [stderr] 105 | OpenDBError::Io(ref e) => e.description(), [INFO] [stderr] 106 | OpenDBError::Compression(ref e) => e.description(), [INFO] [stderr] 107 | OpenDBError::Crypto(_) => "decryption error", [INFO] [stderr] 108 | OpenDBError::IncorrectKey => "incorrect key", [INFO] [stderr] 109 | OpenDBError::InvalidIdentifier => "invalid file header", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &OpenDBError::Io(ref e) => Some(e), [INFO] [stderr] 121 | | &OpenDBError::Compression(ref e) => Some(e), [INFO] [stderr] 122 | | _ => None, [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | OpenDBError::Io(ref e) => Some(e), [INFO] [stderr] 121 | OpenDBError::Compression(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / fn new(&self, key: &[u8], iv: &[u8]) -> Box { [INFO] [stderr] 17 | | cbc_decryptor(KeySize::KeySize256, key, iv, PkcsPadding) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / fn new(&self, key: &[u8], iv: &[u8]) -> Box { [INFO] [stderr] 25 | | Box::new(Salsa20::new(key, iv)) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/decrypt.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn new(&self, _: &[u8], _: &[u8]) -> Box { [INFO] [stderr] 33 | | Box::new(NoOpDecryptor) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decrypt.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | let mut key: [u8; 32] = composite_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `composite_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &DecompressionError::Io(ref e) => write!(f, "I/O error during decompression: {}", e), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | DecompressionError::Io(ref e) => write!(f, "I/O error during decompression: {}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &DecompressionError::Io(ref e) => e.description(), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | DecompressionError::Io(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decompress.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &DecompressionError::Io(ref e) => Some(e), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | DecompressionError::Io(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/decompress.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(in_buffer.into_iter().cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/xmlparse.rs:70:57 [INFO] [stderr] | [INFO] [stderr] 70 | .map_or(false, |v| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 71 | | v.to_lowercase().parse::().unwrap_or(false) [INFO] [stderr] 72 | | }) { [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/xmlparse.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | if attributes.into_iter() [INFO] [stderr] | ____________________________^ [INFO] [stderr] 67 | | .filter(|oa| oa.name.local_name == "Protected") [INFO] [stderr] 68 | | .next() [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|oa| oa.name.local_name == "Protected").next()` with `find(|oa| oa.name.local_name == "Protected")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/xmlparse.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | if attributes.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xmlparse.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | } else if let None = parsed_stack_head { [INFO] [stderr] | ____________________________________- ^^^^ [INFO] [stderr] 112 | | // There is no more parent nodes left -> we are at the root [INFO] [stderr] 113 | | root_group = finished_group; [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________________- help: try this: `if parsed_stack_head.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match self { [INFO] [stderr] 82 | | &OpenDBError::Io(ref e) => write!(f, "I/O error: {}", e), [INFO] [stderr] 83 | | &OpenDBError::Compression(_) => write!(f, "Decompression error"), [INFO] [stderr] 84 | | &OpenDBError::Crypto(_) => write!(f, "Decryption error"), [INFO] [stderr] ... | [INFO] [stderr] 97 | | &OpenDBError::BlockHashMismatch => write!(f, "Block hash verification failed"), [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 81 | match *self { [INFO] [stderr] 82 | OpenDBError::Io(ref e) => write!(f, "I/O error: {}", e), [INFO] [stderr] 83 | OpenDBError::Compression(_) => write!(f, "Decompression error"), [INFO] [stderr] 84 | OpenDBError::Crypto(_) => write!(f, "Decryption error"), [INFO] [stderr] 85 | OpenDBError::IncorrectKey => write!(f, "Incorrect key"), [INFO] [stderr] 86 | OpenDBError::InvalidIdentifier => write!(f, "Invalid file header - not a .kdbx file?"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self { [INFO] [stderr] 105 | | &OpenDBError::Io(ref e) => e.description(), [INFO] [stderr] 106 | | &OpenDBError::Compression(ref e) => e.description(), [INFO] [stderr] 107 | | &OpenDBError::Crypto(_) => "decryption error", [INFO] [stderr] ... | [INFO] [stderr] 114 | | &OpenDBError::BlockHashMismatch => "block hash verification failed", [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *self { [INFO] [stderr] 105 | OpenDBError::Io(ref e) => e.description(), [INFO] [stderr] 106 | OpenDBError::Compression(ref e) => e.description(), [INFO] [stderr] 107 | OpenDBError::Crypto(_) => "decryption error", [INFO] [stderr] 108 | OpenDBError::IncorrectKey => "incorrect key", [INFO] [stderr] 109 | OpenDBError::InvalidIdentifier => "invalid file header", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &OpenDBError::Io(ref e) => Some(e), [INFO] [stderr] 121 | | &OpenDBError::Compression(ref e) => Some(e), [INFO] [stderr] 122 | | _ => None, [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | OpenDBError::Io(ref e) => Some(e), [INFO] [stderr] 121 | OpenDBError::Compression(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:428:27 [INFO] [stderr] | [INFO] [stderr] 428 | .map_err(|e| OpenDBError::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OpenDBError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.92s [INFO] running `"docker" "inspect" "0cb117bf6120a79b09db34cebbc64bea94d1d568ce6c3642d42e7c93df2e1f5a"` [INFO] running `"docker" "rm" "-f" "0cb117bf6120a79b09db34cebbc64bea94d1d568ce6c3642d42e7c93df2e1f5a"` [INFO] [stdout] 0cb117bf6120a79b09db34cebbc64bea94d1d568ce6c3642d42e7c93df2e1f5a