[INFO] crate kdbush 0.1.0 is already in cache [INFO] extracting crate kdbush 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kdbush/0.1.0 [INFO] extracting crate kdbush 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kdbush/0.1.0 [INFO] validating manifest of kdbush-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kdbush-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kdbush-0.1.0 [INFO] finished frobbing kdbush-0.1.0 [INFO] frobbed toml for kdbush-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kdbush/0.1.0/Cargo.toml [INFO] started frobbing kdbush-0.1.0 [INFO] finished frobbing kdbush-0.1.0 [INFO] frobbed toml for kdbush-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kdbush/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kdbush-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kdbush/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c055bef2f8a80dcb41cbf386da8a9bb9bbae025f9d5010e78c31cb869e23ce4 [INFO] running `"docker" "start" "-a" "9c055bef2f8a80dcb41cbf386da8a9bb9bbae025f9d5010e78c31cb869e23ce4"` [INFO] [stderr] Checking kdbush v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdbush.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | node_size: node_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/kdbush.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | let s = 0.5 * f64::exp(2.0 * z / 3.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdbush.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | node_size: node_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_size` [INFO] [stderr] | [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/kdbush.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | let r = k as f64 - m * s / n + [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/kdbush.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/kdbush.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | let s = 0.5 * f64::exp(2.0 * z / 3.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/kdbush.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | let r = k as f64 - m * s / n + [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/kdbush.rs:282:1 [INFO] [stderr] | [INFO] [stderr] 282 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/kdbush.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / fn range_idx(&self, [INFO] [stderr] 114 | | minx: TNumber, [INFO] [stderr] 115 | | miny: TNumber, [INFO] [stderr] 116 | | maxx: TNumber, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kdbush.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for i in left..right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/kdbush.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / fn within_idx(&self, [INFO] [stderr] 162 | | qx: TNumber, [INFO] [stderr] 163 | | qy: TNumber, [INFO] [stderr] 164 | | r: TNumber, [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kdbush.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | for i in left..right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdbush.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | if self.points[left][axis] == t { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.points[left][axis] - t).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdbush.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | if self.points[left][axis] == t { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kdbush`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/kdbush.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / fn range_idx(&self, [INFO] [stderr] 114 | | minx: TNumber, [INFO] [stderr] 115 | | miny: TNumber, [INFO] [stderr] 116 | | maxx: TNumber, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kdbush.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for i in left..right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/kdbush.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / fn within_idx(&self, [INFO] [stderr] 162 | | qx: TNumber, [INFO] [stderr] 163 | | qy: TNumber, [INFO] [stderr] 164 | | r: TNumber, [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/kdbush.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | for i in left..right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdbush.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | if self.points[left][axis] == t { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.points[left][axis] - t).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdbush.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | if self.points[left][axis] == t { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kdbush`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9c055bef2f8a80dcb41cbf386da8a9bb9bbae025f9d5010e78c31cb869e23ce4"` [INFO] running `"docker" "rm" "-f" "9c055bef2f8a80dcb41cbf386da8a9bb9bbae025f9d5010e78c31cb869e23ce4"` [INFO] [stdout] 9c055bef2f8a80dcb41cbf386da8a9bb9bbae025f9d5010e78c31cb869e23ce4