[INFO] crate kcat 0.1.6 is already in cache [INFO] extracting crate kcat 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/kcat/0.1.6 [INFO] extracting crate kcat 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kcat/0.1.6 [INFO] validating manifest of kcat-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kcat-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kcat-0.1.6 [INFO] finished frobbing kcat-0.1.6 [INFO] frobbed toml for kcat-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/kcat/0.1.6/Cargo.toml [INFO] started frobbing kcat-0.1.6 [INFO] finished frobbing kcat-0.1.6 [INFO] frobbed toml for kcat-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kcat/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kcat-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kcat/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6c85d69dd35cd12c2ceb14203f3e0d4e047d96564dc018e2ec57e2b270fd33c [INFO] running `"docker" "start" "-a" "f6c85d69dd35cd12c2ceb14203f3e0d4e047d96564dc018e2ec57e2b270fd33c"` [INFO] [stderr] Checking plist v0.2.4 [INFO] [stderr] Checking syntect v2.1.0 [INFO] [stderr] Checking kcat v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn print_fallback(path: &Path) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn print_fallback(path: &Path) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/printers.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/printers.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(_) = file.read_to_string(&mut s) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 15 | | println!("ERROR: {}", KcatError::InvalidFile); [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_string(&mut s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/printers.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / if let Some(string) = serde_json::to_string_pretty(final_value).ok() { [INFO] [stderr] 71 | | for line in string.as_str().lines() { [INFO] [stderr] 72 | | let ranges: Vec<(Style, &str)> = h.highlight(line); [INFO] [stderr] 73 | | let escaped = as_24_bit_terminal_escaped(&ranges[..], true); [INFO] [stderr] 74 | | println!("{}", escaped); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(string)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/printers.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/printers.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | if let Err(_) = file.read_to_string(&mut s) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 15 | | println!("ERROR: {}", KcatError::InvalidFile); [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_string(&mut s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/printers.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / if let Some(string) = serde_json::to_string_pretty(final_value).ok() { [INFO] [stderr] 71 | | for line in string.as_str().lines() { [INFO] [stderr] 72 | | let ranges: Vec<(Style, &str)> = h.highlight(line); [INFO] [stderr] 73 | | let escaped = as_24_bit_terminal_escaped(&ranges[..], true); [INFO] [stderr] 74 | | println!("{}", escaped); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(string)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/printers.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.57s [INFO] running `"docker" "inspect" "f6c85d69dd35cd12c2ceb14203f3e0d4e047d96564dc018e2ec57e2b270fd33c"` [INFO] running `"docker" "rm" "-f" "f6c85d69dd35cd12c2ceb14203f3e0d4e047d96564dc018e2ec57e2b270fd33c"` [INFO] [stdout] f6c85d69dd35cd12c2ceb14203f3e0d4e047d96564dc018e2ec57e2b270fd33c