[INFO] crate kay_codegen 0.3.1 is already in cache [INFO] extracting crate kay_codegen 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/kay_codegen/0.3.1 [INFO] extracting crate kay_codegen 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kay_codegen/0.3.1 [INFO] validating manifest of kay_codegen-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kay_codegen-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kay_codegen-0.3.1 [INFO] finished frobbing kay_codegen-0.3.1 [INFO] frobbed toml for kay_codegen-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/kay_codegen/0.3.1/Cargo.toml [INFO] started frobbing kay_codegen-0.3.1 [INFO] finished frobbing kay_codegen-0.3.1 [INFO] frobbed toml for kay_codegen-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kay_codegen/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kay_codegen-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kay_codegen/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86e8983de99815726615b2f557142ea2c05961260a48002b3ef1fcdbdcbb3c2a [INFO] running `"docker" "start" "-a" "86e8983de99815726615b2f557142ea2c05961260a48002b3ef1fcdbdcbb3c2a"` [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking kay_codegen v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generators.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 410 | | if let Type::Reference(TypeReference{elem: ref refd_type, ..}) = ty { [INFO] [stderr] 411 | | Some(refd_type.into_token_stream().to_string()) [INFO] [stderr] 412 | | } else { [INFO] [stderr] 413 | | Some(ty.into_token_stream().to_string()) [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | } else if let Type::Reference(TypeReference{elem: ref refd_type, ..}) = ty { [INFO] [stderr] 410 | Some(refd_type.into_token_stream().to_string()) [INFO] [stderr] 411 | } else { [INFO] [stderr] 412 | Some(ty.into_token_stream().to_string()) [INFO] [stderr] 413 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/parsers.rs:142:41 [INFO] [stderr] | [INFO] [stderr] 142 | Type::Path(TypePath{qself: _, path: ::syn::Path { ref segments, .. }}) => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TypePath { path: ::syn::Path { ref segments, .. }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generators.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 410 | | if let Type::Reference(TypeReference{elem: ref refd_type, ..}) = ty { [INFO] [stderr] 411 | | Some(refd_type.into_token_stream().to_string()) [INFO] [stderr] 412 | | } else { [INFO] [stderr] 413 | | Some(ty.into_token_stream().to_string()) [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | } else if let Type::Reference(TypeReference{elem: ref refd_type, ..}) = ty { [INFO] [stderr] 410 | Some(refd_type.into_token_stream().to_string()) [INFO] [stderr] 411 | } else { [INFO] [stderr] 412 | Some(ty.into_token_stream().to_string()) [INFO] [stderr] 413 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/parsers.rs:142:41 [INFO] [stderr] | [INFO] [stderr] 142 | Type::Path(TypePath{qself: _, path: ::syn::Path { ref segments, .. }}) => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TypePath { path: ::syn::Path { ref segments, .. }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generators.rs:334:84 [INFO] [stderr] | [INFO] [stderr] 334 | Pat::Ident(PatIdent{ref ident, ..}) => ident.to_string().trim_left_matches("_").to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:143:52 [INFO] [stderr] | [INFO] [stderr] 143 | if segments.iter().any(|s| s.ident.to_string() == "Fate") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `*s.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parsers.rs:175:161 [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| pair.value().clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| &(*pair.value()).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| &syn::FnArg::clone(pair.value())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | if path.segments.last().unwrap().value().ident.to_string() == "World" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*path.segments.last().unwrap().value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parsers.rs:179:58 [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| pair.value().clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| &(*pair.value()).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| &syn::FnArg::clone(pair.value())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:189:88 [INFO] [stderr] | [INFO] [stderr] 189 | Type::Path(TypePath{path: ref ret_ty_path, ..}) if ret_ty_path.segments.last().unwrap().value().ident.to_string() == "Self" || *ret_ty_path == *parent_path => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ret_ty_path.segments.last().unwrap().value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kay_codegen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generators.rs:334:84 [INFO] [stderr] | [INFO] [stderr] 334 | Pat::Ident(PatIdent{ref ident, ..}) => ident.to_string().trim_left_matches("_").to_owned(), [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:143:52 [INFO] [stderr] | [INFO] [stderr] 143 | if segments.iter().any(|s| s.ident.to_string() == "Fate") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `*s.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parsers.rs:175:161 [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| pair.value().clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| &(*pair.value()).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(FnArg::Captured(ArgCaptured{ty: Type::Reference(TypeReference{elem: ref ty_box, ref mutability, ..}), ..})) = sig.decl.inputs.last().map(|pair| &syn::FnArg::clone(pair.value())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:178:16 [INFO] [stderr] | [INFO] [stderr] 178 | if path.segments.last().unwrap().value().ident.to_string() == "World" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*path.segments.last().unwrap().value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parsers.rs:179:58 [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| pair.value().clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| &(*pair.value()).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 179 | match sig.decl.inputs.first().map(|pair| &syn::FnArg::clone(pair.value())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/parsers.rs:189:88 [INFO] [stderr] | [INFO] [stderr] 189 | Type::Path(TypePath{path: ref ret_ty_path, ..}) if ret_ty_path.segments.last().unwrap().value().ident.to_string() == "Self" || *ret_ty_path == *parent_path => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ret_ty_path.segments.last().unwrap().value().ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kay_codegen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "86e8983de99815726615b2f557142ea2c05961260a48002b3ef1fcdbdcbb3c2a"` [INFO] running `"docker" "rm" "-f" "86e8983de99815726615b2f557142ea2c05961260a48002b3ef1fcdbdcbb3c2a"` [INFO] [stdout] 86e8983de99815726615b2f557142ea2c05961260a48002b3ef1fcdbdcbb3c2a