[INFO] crate karma 0.1.0 is already in cache [INFO] extracting crate karma 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/karma/0.1.0 [INFO] extracting crate karma 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/karma/0.1.0 [INFO] validating manifest of karma-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of karma-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing karma-0.1.0 [INFO] finished frobbing karma-0.1.0 [INFO] frobbed toml for karma-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/karma/0.1.0/Cargo.toml [INFO] started frobbing karma-0.1.0 [INFO] finished frobbing karma-0.1.0 [INFO] frobbed toml for karma-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/karma/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting karma-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/karma/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c426e2a993bd491cb5e373107836361dec65b632e972fca05181637d576d110a [INFO] running `"docker" "start" "-a" "c426e2a993bd491cb5e373107836361dec65b632e972fca05181637d576d110a"` [INFO] [stderr] Checking libc v0.2.48 [INFO] [stderr] Checking karma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | assert!(out == 0.00010895785403664846f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0.000_108_957_854_036_648_46f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `l` is never read [INFO] [stderr] --> src/lib.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | let mut l = 0i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `N` should have a snake case name such as `n` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | N: i64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `O` should have a snake case name such as `o` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | O: i64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/lib.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | next_probs: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/lib.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | out_probs: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/lib.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | init_probs: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/lib.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | _tmp: Box>, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:81:41 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn evaluate(&mut self, outputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | if outputs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `outputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | j = j + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | sum = sum + (self._tmp[i as usize] * self.next_probs[l as usize]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += (self._tmp[i as usize] * self.next_probs[l as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | l = l + states; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `l += states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | t = t + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `t += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | sum = sum + (self._tmp[(states + i) as usize] * self.next_probs[l as usize]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += (self._tmp[(states + i) as usize] * self.next_probs[l as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | l = l + states; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `l += states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | t = t + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `t += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | sum = sum + (self._tmp[offset as usize]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += (self._tmp[offset as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:165:38 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn train(&mut self, outputs: &Vec, rate: Option) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `S` should have a snake case name such as `s` [INFO] [stderr] --> src/lib.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let S = outputs.len() as i64; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | / sum = sum [INFO] [stderr] 207 | | + (( [INFO] [stderr] 208 | | self._tmp[((i - 1) * states + k) as usize] [INFO] [stderr] 209 | | * self.next_probs[(k * states + j) as usize] [INFO] [stderr] 210 | | ) as f64); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 206 | sum += (( [INFO] [stderr] 207 | self._tmp[((i - 1) * states + k) as usize] [INFO] [stderr] 208 | * self.next_probs[(k * states + j) as usize] [INFO] [stderr] 209 | ) as f64); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | l = l + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | l = l + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:236:21 [INFO] [stderr] | [INFO] [stderr] 236 | / self._tmp[(beta + l) as usize] = [INFO] [stderr] 237 | | self._tmp[(beta + l) as usize] [INFO] [stderr] 238 | | + ( [INFO] [stderr] 239 | | self.next_probs[(j * states + k) as usize] [INFO] [stderr] 240 | | * self.out_probs[(k + outputs_states[(i + 1) as usize]) as usize] [INFO] [stderr] 241 | | * self._tmp[(beta + (i + 1) * states + k) as usize] [INFO] [stderr] 242 | | ); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 236 | self._tmp[(beta + l) as usize] += ( [INFO] [stderr] 237 | self.next_probs[(j * states + k) as usize] [INFO] [stderr] 238 | * self.out_probs[(k + outputs_states[(i + 1) as usize]) as usize] [INFO] [stderr] 239 | * self._tmp[(beta + (i + 1) * states + k) as usize] [INFO] [stderr] 240 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | l = l + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | / sum = sum [INFO] [stderr] 256 | | + ( [INFO] [stderr] 257 | | self._tmp[(i * states + k) as usize] [INFO] [stderr] 258 | | * self._tmp[(beta + i * states + k) as usize] [INFO] [stderr] 259 | | ); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 255 | sum += ( [INFO] [stderr] 256 | self._tmp[(i * states + k) as usize] [INFO] [stderr] 257 | * self._tmp[(beta + i * states + k) as usize] [INFO] [stderr] 258 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | / sum = sum [INFO] [stderr] 278 | | + ( [INFO] [stderr] 279 | | self._tmp[(i * states + j) as usize] [INFO] [stderr] 280 | | * self.next_probs[(j * states + k) as usize] [INFO] [stderr] 281 | | * self.out_probs[(k + outputs_states[(i + 1) as usize]) as usize] [INFO] [stderr] 282 | | * self._tmp[(beta + (i + 1) * states + k) as usize] [INFO] [stderr] 283 | | ); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 277 | sum += ( [INFO] [stderr] 278 | self._tmp[(i * states + j) as usize] [INFO] [stderr] 279 | * self.next_probs[(j * states + k) as usize] [INFO] [stderr] 280 | * self.out_probs[(k + outputs_states[(i + 1) as usize]) as usize] [INFO] [stderr] 281 | * self._tmp[(beta + (i + 1) * states + k) as usize] [INFO] [stderr] 282 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | / self._tmp[index] = self._tmp[index] [INFO] [stderr] 294 | | + ( [INFO] [stderr] 295 | | self._tmp[(i * states + j) as usize] [INFO] [stderr] 296 | | * self.next_probs[l as usize] [INFO] [stderr] ... | [INFO] [stderr] 299 | | / sum [INFO] [stderr] 300 | | ); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 293 | self._tmp[index] += ( [INFO] [stderr] 294 | self._tmp[(i * states + j) as usize] [INFO] [stderr] 295 | * self.next_probs[l as usize] [INFO] [stderr] 296 | * self.out_probs[(k + outputs_states[(i + 1) as usize]) as usize] [INFO] [stderr] 297 | * self._tmp[(beta + (i + 1) * states + k) as usize] [INFO] [stderr] 298 | / sum [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | l = l + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `l += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:316:17 [INFO] [stderr] | [INFO] [stderr] 316 | sum = sum + self._tmp[(gamma + k * states + i) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += self._tmp[(gamma + k * states + i) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | self.next_probs[index] = self.next_probs[index] + (del * rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next_probs[index] += (del * rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | l = l + 1i64; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `l += 1i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | sum = sum + self._tmp[(gamma + (S - 1) * states + i) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += self._tmp[(gamma + (S - 1) * states + i) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:339:25 [INFO] [stderr] | [INFO] [stderr] 339 | x = x + self._tmp[(gamma + k * states + i) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x += self._tmp[(gamma + k * states + i) as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:347:17 [INFO] [stderr] | [INFO] [stderr] 347 | self.out_probs[index] = self.out_probs[index] + (del * rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.out_probs[index] += (del * rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | self.init_probs[i as usize] = self.init_probs[i as usize] + (del * rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.init_probs[i as usize] += (del * rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | assert!(out == 0.00010895785403664846f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(out - 0.00010895785403664846f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | assert!(out == 0.00010895785403664846f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `karma`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c426e2a993bd491cb5e373107836361dec65b632e972fca05181637d576d110a"` [INFO] running `"docker" "rm" "-f" "c426e2a993bd491cb5e373107836361dec65b632e972fca05181637d576d110a"` [INFO] [stdout] c426e2a993bd491cb5e373107836361dec65b632e972fca05181637d576d110a