[INFO] crate kanshi 0.2.1 is already in cache [INFO] extracting crate kanshi 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/kanshi/0.2.1 [INFO] extracting crate kanshi 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kanshi/0.2.1 [INFO] validating manifest of kanshi-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kanshi-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kanshi-0.2.1 [INFO] finished frobbing kanshi-0.2.1 [INFO] frobbed toml for kanshi-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/kanshi/0.2.1/Cargo.toml [INFO] started frobbing kanshi-0.2.1 [INFO] finished frobbing kanshi-0.2.1 [INFO] frobbed toml for kanshi-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kanshi/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kanshi-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kanshi/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a3b18b3e48010c0f4d6b2c86541f54d5bb1885bc1f6239045cb82226d635eb4 [INFO] running `"docker" "start" "-a" "5a3b18b3e48010c0f4d6b2c86541f54d5bb1885bc1f6239045cb82226d635eb4"` [INFO] [stderr] Checking edid v0.2.0 [INFO] [stderr] Checking kanshi v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | if other.vendor != "" { [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | if self.vendor() != other.vendor { [INFO] [stderr] 46 | | return false; [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if other.vendor != "" && self.vendor() != other.vendor { [INFO] [stderr] 45 | return false; [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | } else if other.product != "" { [INFO] [stderr] | ________________^ [INFO] [stderr] 55 | | if self.product() != other.product { [INFO] [stderr] 56 | | return false; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if other.product != "" && self.product() != other.product { [INFO] [stderr] 55 | return false; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | } else if other.serial != "" { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | if self.serial() != other.serial { [INFO] [stderr] 66 | | return false; [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if other.serial != "" && self.serial() != other.serial { [INFO] [stderr] 65 | return false; [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/store.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(env::home_dir().unwrap().join(".config")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | if other.vendor != "" { [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | if self.vendor() != other.vendor { [INFO] [stderr] 46 | | return false; [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if other.vendor != "" && self.vendor() != other.vendor { [INFO] [stderr] 45 | return false; [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | } else if other.product != "" { [INFO] [stderr] | ________________^ [INFO] [stderr] 55 | | if self.product() != other.product { [INFO] [stderr] 56 | | return false; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if other.product != "" && self.product() != other.product { [INFO] [stderr] 55 | return false; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | } else if other.serial != "" { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | if self.serial() != other.serial { [INFO] [stderr] 66 | | return false; [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if other.serial != "" && self.serial() != other.serial { [INFO] [stderr] 65 | return false; [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/store.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(env::home_dir().unwrap().join(".config")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/backend.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | .unwrap_or(format!("0x{:X}", self.edid.header.product)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("0x{:X}", self.edid.header.product))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | .filter_map(|d| match d { [INFO] [stderr] | _________________________^ [INFO] [stderr] 22 | | &edid::Descriptor::ProductName(ref s) => Some(s.to_string()), [INFO] [stderr] 23 | | _ => None, [INFO] [stderr] 24 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | .filter_map(|d| match *d { [INFO] [stderr] 22 | edid::Descriptor::ProductName(ref s) => Some(s.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/backend.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(format!("0x{:X}", self.edid.header.serial)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("0x{:X}", self.edid.header.serial))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | .filter_map(|d| match d { [INFO] [stderr] | _________________________^ [INFO] [stderr] 32 | | &edid::Descriptor::SerialNumber(ref s) => Some(s.to_string()), [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | .filter_map(|d| match *d { [INFO] [stderr] 32 | edid::Descriptor::SerialNumber(ref s) => Some(s.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/store.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(env::home_dir().unwrap().join(".config")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| env::home_dir().unwrap().join(".config"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/store.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | name: e.attributes.get("name").unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&e.attributes["name"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/frontend.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | w.write(l.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | let matched = config.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kanshi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/backend.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | .unwrap_or(format!("0x{:X}", self.edid.header.product)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("0x{:X}", self.edid.header.product))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | .filter_map(|d| match d { [INFO] [stderr] | _________________________^ [INFO] [stderr] 22 | | &edid::Descriptor::ProductName(ref s) => Some(s.to_string()), [INFO] [stderr] 23 | | _ => None, [INFO] [stderr] 24 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | .filter_map(|d| match *d { [INFO] [stderr] 22 | edid::Descriptor::ProductName(ref s) => Some(s.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/backend.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(format!("0x{:X}", self.edid.header.serial)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("0x{:X}", self.edid.header.serial))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | .filter_map(|d| match d { [INFO] [stderr] | _________________________^ [INFO] [stderr] 32 | | &edid::Descriptor::SerialNumber(ref s) => Some(s.to_string()), [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | .filter_map(|d| match *d { [INFO] [stderr] 32 | edid::Descriptor::SerialNumber(ref s) => Some(s.to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/store.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | .unwrap_or(env::home_dir().unwrap().join(".config")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| env::home_dir().unwrap().join(".config"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/store.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | name: e.attributes.get("name").unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&e.attributes["name"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/frontend.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | w.write(l.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | let matched = config.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `kanshi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5a3b18b3e48010c0f4d6b2c86541f54d5bb1885bc1f6239045cb82226d635eb4"` [INFO] running `"docker" "rm" "-f" "5a3b18b3e48010c0f4d6b2c86541f54d5bb1885bc1f6239045cb82226d635eb4"` [INFO] [stdout] 5a3b18b3e48010c0f4d6b2c86541f54d5bb1885bc1f6239045cb82226d635eb4