[INFO] crate kailua_test 1.0.4 is already in cache [INFO] extracting crate kailua_test 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/kailua_test/1.0.4 [INFO] extracting crate kailua_test 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kailua_test/1.0.4 [INFO] validating manifest of kailua_test-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kailua_test-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kailua_test-1.0.4 [INFO] removed path dependency kailua_diag from kailua_test-1.0.4 [INFO] removed path dependency kailua_env from kailua_test-1.0.4 [INFO] finished frobbing kailua_test-1.0.4 [INFO] frobbed toml for kailua_test-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/kailua_test/1.0.4/Cargo.toml [INFO] started frobbing kailua_test-1.0.4 [INFO] removed path dependency kailua_diag from kailua_test-1.0.4 [INFO] removed path dependency kailua_env from kailua_test-1.0.4 [INFO] finished frobbing kailua_test-1.0.4 [INFO] frobbed toml for kailua_test-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kailua_test/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kailua_test-1.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kailua_test/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56fbf6a4d2920ea64ffab04d3a7ceea7ef29df4b9ea2c56788d79ed156931dd3 [INFO] running `"docker" "start" "-a" "56fbf6a4d2920ea64ffab04d3a7ceea7ef29df4b9ea2c56788d79ed156931dd3"` [INFO] [stderr] Checking kailua_env v1.0.4 [INFO] [stderr] Checking parse-generics-shim v0.1.1 [INFO] [stderr] Checking kailua_diag v1.0.4 [INFO] [stderr] Checking kailua_test v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | TestError { desc: desc, cause: None } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | TestError { desc: desc, cause: Some(cause as Box) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:35 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((line, Some(Expected { pos: pos, kind: kind, msg: msg.into() }))) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:45 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((line, Some(Expected { pos: pos, kind: kind, msg: msg.into() }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:474:21 [INFO] [stderr] | [INFO] [stderr] 474 | ignored: ignored, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ignored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | TestError { desc: desc, cause: None } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | TestError { desc: desc, cause: Some(cause as Box) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:35 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((line, Some(Expected { pos: pos, kind: kind, msg: msg.into() }))) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `testing` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:310:45 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((line, Some(Expected { pos: pos, kind: kind, msg: msg.into() }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:57 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:474:21 [INFO] [stderr] | [INFO] [stderr] 474 | ignored: ignored, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ignored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `testing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:57 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:73 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:651:73 [INFO] [stderr] | [INFO] [stderr] 651 | testing: testing, features: HashSet::new(), filter: filter, term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:652:31 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exact_diags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:652:57 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `highlight_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | message_locale: message_locale, stop_on_panic: stop_on_panic > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:712:17 [INFO] [stderr] | [INFO] [stderr] 712 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:718:17 [INFO] [stderr] | [INFO] [stderr] 718 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:21 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:33 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:49 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_only` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:849:46 [INFO] [stderr] | [INFO] [stderr] 849 | output: output.unwrap(), output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:850:43 [INFO] [stderr] | [INFO] [stderr] 850 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reports_aux` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:17 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:29 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:64 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `panicked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:871:17 [INFO] [stderr] | [INFO] [stderr] 871 | output: output, output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:871:33 [INFO] [stderr] | [INFO] [stderr] 871 | output: output, output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:872:17 [INFO] [stderr] | [INFO] [stderr] 872 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:872:39 [INFO] [stderr] | [INFO] [stderr] 872 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reports_aux` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:878:17 [INFO] [stderr] | [INFO] [stderr] 878 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:882:17 [INFO] [stderr] | [INFO] [stderr] 882 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:911:17 [INFO] [stderr] | [INFO] [stderr] 911 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:921:17 [INFO] [stderr] | [INFO] [stderr] 921 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:938:29 [INFO] [stderr] | [INFO] [stderr] 938 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:943:21 [INFO] [stderr] | [INFO] [stderr] 943 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:652:31 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exact_diags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:945:25 [INFO] [stderr] | [INFO] [stderr] 945 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] --> src/lib.rs:652:57 [INFO] [stderr] | [INFO] [stderr] 652 | verbose: verbose, exact_diags: exact_diags, highlight_mismatch: highlight_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `highlight_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | message_locale: message_locale, stop_on_panic: stop_on_panic > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:969:29 [INFO] [stderr] | [INFO] [stderr] 969 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:712:17 [INFO] [stderr] | [INFO] [stderr] 712 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:989:21 [INFO] [stderr] | [INFO] [stderr] 989 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:718:17 [INFO] [stderr] | [INFO] [stderr] 718 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:997:25 [INFO] [stderr] | [INFO] [stderr] 997 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:21 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:33 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:848:49 [INFO] [stderr] | [INFO] [stderr] 848 | test: test, source: source, delta_only: delta_only, panicked: false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_only` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:849:46 [INFO] [stderr] | [INFO] [stderr] 849 | output: output.unwrap(), output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:850:43 [INFO] [stderr] | [INFO] [stderr] 850 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reports_aux` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:17 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:29 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:870:64 [INFO] [stderr] | [INFO] [stderr] 870 | test: test, source: source, delta_only: false, panicked: panicked, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `panicked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:871:17 [INFO] [stderr] | [INFO] [stderr] 871 | output: output, output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:871:33 [INFO] [stderr] | [INFO] [stderr] 871 | output: output, output_mismatch: output_mismatch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_mismatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:872:17 [INFO] [stderr] | [INFO] [stderr] 872 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:872:39 [INFO] [stderr] | [INFO] [stderr] 872 | collected: collected, reports_aux: reports_aux, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reports_aux` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:878:17 [INFO] [stderr] | [INFO] [stderr] 878 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:882:17 [INFO] [stderr] | [INFO] [stderr] 882 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:911:17 [INFO] [stderr] | [INFO] [stderr] 911 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:921:17 [INFO] [stderr] | [INFO] [stderr] 921 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:938:29 [INFO] [stderr] | [INFO] [stderr] 938 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:943:21 [INFO] [stderr] | [INFO] [stderr] 943 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:945:25 [INFO] [stderr] | [INFO] [stderr] 945 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:969:29 [INFO] [stderr] | [INFO] [stderr] 969 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:989:21 [INFO] [stderr] | [INFO] [stderr] 989 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.term, "")` [INFO] [stderr] --> src/lib.rs:997:25 [INFO] [stderr] | [INFO] [stderr] 997 | let _ = writeln!(self.term, ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:589:19 [INFO] [stderr] | [INFO] [stderr] 589 | const MAIN_PATH: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:589:19 [INFO] [stderr] | [INFO] [stderr] 589 | const MAIN_PATH: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | if s.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | } else if s.starts_with("^") { [INFO] [stderr] | ^^^ help: try using a char instead: `'^'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:285:69 [INFO] [stderr] | [INFO] [stderr] 285 | let lineno = lineno.checked_sub(s.len()).ok_or_else(|| err())?; [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | } else if s.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:289:56 [INFO] [stderr] | [INFO] [stderr] 289 | lineno.checked_add(s.len()).ok_or_else(|| err()) [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:291:35 [INFO] [stderr] | [INFO] [stderr] 291 | s.parse().map_err(|e| erre(e)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `erre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:308:79 [INFO] [stderr] | [INFO] [stderr] 308 | let kind = kind_from_str(m.name("kind").unwrap().as_str()).ok_or_else(|| err())?; [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | / let mut next_cont = false; [INFO] [stderr] 493 | | if next.ends_with("\\") { [INFO] [stderr] 494 | | next = &next[..next.len()-1]; [INFO] [stderr] 495 | | next_cont = true; [INFO] [stderr] 496 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let next_cont = if next.ends_with("\\") { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:489:49 [INFO] [stderr] | [INFO] [stderr] 489 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:493:31 [INFO] [stderr] | [INFO] [stderr] 493 | if next.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:515:49 [INFO] [stderr] | [INFO] [stderr] 515 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:549:49 [INFO] [stderr] | [INFO] [stderr] 549 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:674:46 [INFO] [stderr] | [INFO] [stderr] 674 | let tests = extract_tests(&path).expect(&format!("failed to parse the test \ [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 675 | | specification file {}", [INFO] [stderr] 676 | | path.display())); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 674 | let tests = extract_tests(&path).unwrap_or_else(|_| panic!("failed to parse the test \ [INFO] [stderr] 675 | specification file {}", path.display())); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:690:45 [INFO] [stderr] | [INFO] [stderr] 690 | if feat.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:731:13 [INFO] [stderr] | [INFO] [stderr] 731 | format!("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:763:13 [INFO] [stderr] | [INFO] [stderr] 763 | Err(_) => panic!("Testing::run should not own Source"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:767:13 [INFO] [stderr] | [INFO] [stderr] 767 | Err(_) => panic!("Testing::run should not own Report"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:828:26 [INFO] [stderr] | [INFO] [stderr] 828 | let count = *reportset.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reportset[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | if s.starts_with("<") { [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | } else if s.starts_with("^") { [INFO] [stderr] | ^^^ help: try using a char instead: `'^'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:285:69 [INFO] [stderr] | [INFO] [stderr] 285 | let lineno = lineno.checked_sub(s.len()).ok_or_else(|| err())?; [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | } else if s.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:289:56 [INFO] [stderr] | [INFO] [stderr] 289 | lineno.checked_add(s.len()).ok_or_else(|| err()) [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:291:35 [INFO] [stderr] | [INFO] [stderr] 291 | s.parse().map_err(|e| erre(e)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `erre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:308:79 [INFO] [stderr] | [INFO] [stderr] 308 | let kind = kind_from_str(m.name("kind").unwrap().as_str()).ok_or_else(|| err())?; [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lib.rs:319:1 [INFO] [stderr] | [INFO] [stderr] 319 | / fn test_split_line() { [INFO] [stderr] 320 | | let path = "foo.lua"; [INFO] [stderr] 321 | | let split_line = |line, lineno| split_line(line, Some(path), lineno).map_err(|_| ()); [INFO] [stderr] 322 | | let make_pos = |s, e| Some((Some(path.into()), s, e)); [INFO] [stderr] ... | [INFO] [stderr] 393 | | msg: "whatever".into() })))); [INFO] [stderr] 394 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | / let mut next_cont = false; [INFO] [stderr] 493 | | if next.ends_with("\\") { [INFO] [stderr] 494 | | next = &next[..next.len()-1]; [INFO] [stderr] 495 | | next_cont = true; [INFO] [stderr] 496 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let next_cont = if next.ends_with("\\") { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:489:49 [INFO] [stderr] | [INFO] [stderr] 489 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:493:31 [INFO] [stderr] | [INFO] [stderr] 493 | if next.ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:515:49 [INFO] [stderr] | [INFO] [stderr] 515 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:549:49 [INFO] [stderr] | [INFO] [stderr] 549 | let test = test.as_mut().ok_or_else(|| premature_err())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `premature_err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:674:46 [INFO] [stderr] | [INFO] [stderr] 674 | let tests = extract_tests(&path).expect(&format!("failed to parse the test \ [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 675 | | specification file {}", [INFO] [stderr] 676 | | path.display())); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 674 | let tests = extract_tests(&path).unwrap_or_else(|_| panic!("failed to parse the test \ [INFO] [stderr] 675 | specification file {}", path.display())); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:690:45 [INFO] [stderr] | [INFO] [stderr] 690 | if feat.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:731:13 [INFO] [stderr] | [INFO] [stderr] 731 | format!("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:763:13 [INFO] [stderr] | [INFO] [stderr] 763 | Err(_) => panic!("Testing::run should not own Source"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:767:13 [INFO] [stderr] | [INFO] [stderr] 767 | Err(_) => panic!("Testing::run should not own Report"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:828:26 [INFO] [stderr] | [INFO] [stderr] 828 | let count = *reportset.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reportset[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.68s [INFO] running `"docker" "inspect" "56fbf6a4d2920ea64ffab04d3a7ceea7ef29df4b9ea2c56788d79ed156931dd3"` [INFO] running `"docker" "rm" "-f" "56fbf6a4d2920ea64ffab04d3a7ceea7ef29df4b9ea2c56788d79ed156931dd3"` [INFO] [stdout] 56fbf6a4d2920ea64ffab04d3a7ceea7ef29df4b9ea2c56788d79ed156931dd3