[INFO] crate kailua_diag 1.0.4 is already in cache
[INFO] extracting crate kailua_diag 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/kailua_diag/1.0.4
[INFO] extracting crate kailua_diag 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kailua_diag/1.0.4
[INFO] validating manifest of kailua_diag-1.0.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kailua_diag-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kailua_diag-1.0.4
[INFO] removed path dependency kailua_env from kailua_diag-1.0.4
[INFO] finished frobbing kailua_diag-1.0.4
[INFO] frobbed toml for kailua_diag-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/kailua_diag/1.0.4/Cargo.toml
[INFO] started frobbing kailua_diag-1.0.4
[INFO] removed path dependency kailua_env from kailua_diag-1.0.4
[INFO] finished frobbing kailua_diag-1.0.4
[INFO] frobbed toml for kailua_diag-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kailua_diag/1.0.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kailua_diag-1.0.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kailua_diag/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8ac2632a67ce45fbd7571f23d2f58b2c85588de8ea807d4359ab44e99fa2d7c8
[INFO] running `"docker" "start" "-a" "8ac2632a67ce45fbd7571f23d2f58b2c85588de8ea807d4359ab44e99fa2d7c8"`
[INFO] [stderr]     Checking parse-generics-shim v0.1.1
[INFO] [stderr]     Checking kailua_env v1.0.4
[INFO] [stderr]     Checking kailua_diag v1.0.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Some(Locale { lang: lang })
[INFO] [stderr]    |                       ^^^^^^^^^^ help: replace it with: `lang`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message.rs:135:21
[INFO] [stderr]     |
[INFO] [stderr] 135 |         Localized { base: base, locale: locale }
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message.rs:135:33
[INFO] [stderr]     |
[INFO] [stderr] 135 |         Localized { base: base, locale: locale }
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:162:22
[INFO] [stderr]     |
[INFO] [stderr] 162 |         ReportMore { report: report, result: result }
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^ help: replace it with: `report`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:162:38
[INFO] [stderr]     |
[INFO] [stderr] 162 |         ReportMore { report: report, result: result }
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^ help: replace it with: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             source: source,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `source`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:234:13
[INFO] [stderr]     |
[INFO] [stderr] 234 |             locale: locale,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(term, "")`
[INFO] [stderr]    --> src/report.rs:387:17
[INFO] [stderr]     |
[INFO] [stderr] 387 |         let _ = writeln!(term, "");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(term, "")`
[INFO] [stderr]    --> src/report.rs:400:25
[INFO] [stderr]     |
[INFO] [stderr] 400 |                 let _ = writeln!(term, "");
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:534:64
[INFO] [stderr]     |
[INFO] [stderr] 534 |         CollectedReport { collected: RefCell::new(Vec::new()), locale: locale }
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:576:13
[INFO] [stderr]     |
[INFO] [stderr] 576 |             report: report,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `report`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dummy_term.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 |         DummyTerminal { writer: writer }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Some(Locale { lang: lang })
[INFO] [stderr]    |                       ^^^^^^^^^^ help: replace it with: `lang`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message.rs:135:21
[INFO] [stderr]     |
[INFO] [stderr] 135 |         Localized { base: base, locale: locale }
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message.rs:135:33
[INFO] [stderr]     |
[INFO] [stderr] 135 |         Localized { base: base, locale: locale }
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:162:22
[INFO] [stderr]     |
[INFO] [stderr] 162 |         ReportMore { report: report, result: result }
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^ help: replace it with: `report`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:162:38
[INFO] [stderr]     |
[INFO] [stderr] 162 |         ReportMore { report: report, result: result }
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^ help: replace it with: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             source: source,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `source`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:234:13
[INFO] [stderr]     |
[INFO] [stderr] 234 |             locale: locale,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(term, "")`
[INFO] [stderr]    --> src/report.rs:387:17
[INFO] [stderr]     |
[INFO] [stderr] 387 |         let _ = writeln!(term, "");
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(term, "")`
[INFO] [stderr]    --> src/report.rs:400:25
[INFO] [stderr]     |
[INFO] [stderr] 400 |                 let _ = writeln!(term, "");
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:534:64
[INFO] [stderr]     |
[INFO] [stderr] 534 |         CollectedReport { collected: RefCell::new(Vec::new()), locale: locale }
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^ help: replace it with: `locale`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/report.rs:576:13
[INFO] [stderr]     |
[INFO] [stderr] 576 |             report: report,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `report`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dummy_term.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 |         DummyTerminal { writer: writer }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/report.rs:61:19
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn colors(&self) -> (/*dim*/ color::Color, /*bright*/ color::Color) {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/report.rs:187:56
[INFO] [stderr]     |
[INFO] [stderr] 187 |             let ret = self.report.add_span(Kind::Note, loc.into(), &msg);
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: consider removing `.into()`: `loc`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/report.rs:226:58
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let locale = get_message_locale().unwrap_or_else(|| Locale::dummy());
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Locale::dummy`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/report.rs:61:19
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn colors(&self) -> (/*dim*/ color::Color, /*bright*/ color::Color) {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/report.rs:187:56
[INFO] [stderr]     |
[INFO] [stderr] 187 |             let ret = self.report.add_span(Kind::Note, loc.into(), &msg);
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: consider removing `.into()`: `loc`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/report.rs:226:58
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let locale = get_message_locale().unwrap_or_else(|| Locale::dummy());
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Locale::dummy`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.48s
[INFO] running `"docker" "inspect" "8ac2632a67ce45fbd7571f23d2f58b2c85588de8ea807d4359ab44e99fa2d7c8"`
[INFO] running `"docker" "rm" "-f" "8ac2632a67ce45fbd7571f23d2f58b2c85588de8ea807d4359ab44e99fa2d7c8"`
[INFO] [stdout] 8ac2632a67ce45fbd7571f23d2f58b2c85588de8ea807d4359ab44e99fa2d7c8