[INFO] crate kafi 0.1.0 is already in cache [INFO] extracting crate kafi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/kafi/0.1.0 [INFO] extracting crate kafi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kafi/0.1.0 [INFO] validating manifest of kafi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kafi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kafi-0.1.0 [INFO] finished frobbing kafi-0.1.0 [INFO] frobbed toml for kafi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/kafi/0.1.0/Cargo.toml [INFO] started frobbing kafi-0.1.0 [INFO] finished frobbing kafi-0.1.0 [INFO] frobbed toml for kafi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kafi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kafi-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/kafi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bad0d3410a9019b248b4606e3aa18044e6f5db546cdf3d26060ec523160f7a86 [INFO] running `"docker" "start" "-a" "bad0d3410a9019b248b4606e3aa18044e6f5db546cdf3d26060ec523160f7a86"` [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking kafi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / let mut _data:StdHashMap = StdHashMap::new(); [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | if read > 0 { [INFO] [stderr] 50 | | _data = deserialize(&buf) [INFO] [stderr] 51 | | .map_err(|e| e.description().to_string())?; [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 47 | let _data = if read > 0 { deserialize(&buf) [INFO] [stderr] 48 | .map_err(|e| e.description().to_string())? } else { StdHashMap::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / let mut _data:StdHashMap = StdHashMap::new(); [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | if read > 0 { [INFO] [stderr] 50 | | _data = deserialize(&buf) [INFO] [stderr] 51 | | .map_err(|e| e.description().to_string())?; [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 47 | let _data = if read > 0 { deserialize(&buf) [INFO] [stderr] 48 | .map_err(|e| e.description().to_string())? } else { StdHashMap::new() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.94s [INFO] running `"docker" "inspect" "bad0d3410a9019b248b4606e3aa18044e6f5db546cdf3d26060ec523160f7a86"` [INFO] running `"docker" "rm" "-f" "bad0d3410a9019b248b4606e3aa18044e6f5db546cdf3d26060ec523160f7a86"` [INFO] [stdout] bad0d3410a9019b248b4606e3aa18044e6f5db546cdf3d26060ec523160f7a86