[INFO] crate jvm-assembler 0.0.1 is already in cache [INFO] extracting crate jvm-assembler 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/jvm-assembler/0.0.1 [INFO] extracting crate jvm-assembler 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jvm-assembler/0.0.1 [INFO] validating manifest of jvm-assembler-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jvm-assembler-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jvm-assembler-0.0.1 [INFO] finished frobbing jvm-assembler-0.0.1 [INFO] frobbed toml for jvm-assembler-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/jvm-assembler/0.0.1/Cargo.toml [INFO] started frobbing jvm-assembler-0.0.1 [INFO] finished frobbing jvm-assembler-0.0.1 [INFO] frobbed toml for jvm-assembler-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jvm-assembler/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jvm-assembler-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/jvm-assembler/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9df82e9b97c79dad803c2dfb12e2b94fc4725916826dfb5689ac54d870da0101 [INFO] running `"docker" "start" "-a" "9df82e9b97c79dad803c2dfb12e2b94fc4725916826dfb5689ac54d870da0101"` [INFO] [stderr] Checking jvm-assembler v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | this_class: this_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | super_class: super_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | this_class: this_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | super_class: super_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | Deserializer { stream: stream, bytes_taken: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/classfile.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | Deserializer { stream: stream, bytes_taken: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/classfile.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/classfile.rs:551:9 [INFO] [stderr] | [INFO] [stderr] 551 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/classfile.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | classfile: classfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/classfile.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | classfile: classfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile_builder.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const CAFEBABE: u32 = 0xCAFEBABE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const CAFEBABE: u32 = 0xCAFEBABE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:393:24 [INFO] [stderr] | [INFO] [stderr] 393 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:397:20 [INFO] [stderr] | [INFO] [stderr] 397 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Interface { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:397:44 [INFO] [stderr] | [INFO] [stderr] 397 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Interface { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:403:24 [INFO] [stderr] | [INFO] [stderr] 403 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:407:20 [INFO] [stderr] | [INFO] [stderr] 407 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Field { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:407:44 [INFO] [stderr] | [INFO] [stderr] 407 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Field { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:472:24 [INFO] [stderr] | [INFO] [stderr] 472 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> ExceptionTableEntry { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:476:44 [INFO] [stderr] | [INFO] [stderr] 476 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> ExceptionTableEntry { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut buf = &mut Deserializer::new(Box::new(stream.bytes().map(|r| r.unwrap()))); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | let mut code_buf = &mut Deserializer::new(Box::new(code.into_iter())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:454:13 [INFO] [stderr] | [INFO] [stderr] 454 | let mut buf2 = &mut Deserializer::new(Box::new(attribute_body.into_iter())); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PUBLIC` [INFO] [stderr] --> src/classfile_builder.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const ACC_PUBLIC: u16 = 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_STATIC` [INFO] [stderr] --> src/classfile_builder.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const ACC_STATIC: u16 = 0x8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ClassfileBuilder` [INFO] [stderr] --> src/classfile_builder.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct ClassfileBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/classfile_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(access_flags: u16, this_class: &str, super_class: &str) -> ClassfileBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_method` [INFO] [stderr] --> src/classfile_builder.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn define_method(&mut self, access_flags: u16, name: &str, descriptor: &str) -> MethodBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_constant` [INFO] [stderr] --> src/classfile_builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | fn push_constant(&mut self, constant: Constant) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_utf8` [INFO] [stderr] --> src/classfile_builder.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn define_utf8(&mut self, string: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_class` [INFO] [stderr] --> src/classfile_builder.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn define_class(&mut self, class: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_name_and_type` [INFO] [stderr] --> src/classfile_builder.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | fn define_name_and_type(&mut self, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_fieldref` [INFO] [stderr] --> src/classfile_builder.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | fn define_fieldref(&mut self, class: &str, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_methodref` [INFO] [stderr] --> src/classfile_builder.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | fn define_methodref(&mut self, class: &str, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `done` [INFO] [stderr] --> src/classfile_builder.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn done(self) -> Classfile { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MethodBuilder` [INFO] [stderr] --> src/classfile_builder.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | pub struct MethodBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/classfile_builder.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | fn new(classfile: &'a mut ClassfileBuilder, access_flags: u16, name: &str, descriptor: &str) -> MethodBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_static` [INFO] [stderr] --> src/classfile_builder.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_static(&mut self, class: &str, name: &str, descriptor: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `invoke_virtual` [INFO] [stderr] --> src/classfile_builder.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn invoke_virtual(&mut self, class: &str, name: &str, descriptor: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bipush` [INFO] [stderr] --> src/classfile_builder.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn bipush(&mut self, value: i8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iadd` [INFO] [stderr] --> src/classfile_builder.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn iadd(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `do_return` [INFO] [stderr] --> src/classfile_builder.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn do_return(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `increase_stack_depth` [INFO] [stderr] --> src/classfile_builder.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | fn increase_stack_depth(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decrease_stack_depth` [INFO] [stderr] --> src/classfile_builder.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | fn decrease_stack_depth(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `done` [INFO] [stderr] --> src/classfile_builder.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn done(self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:193:10 [INFO] [stderr] | [INFO] [stderr] 193 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:58 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:80 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:221:32 [INFO] [stderr] | [INFO] [stderr] 221 | let v = buf.take_bytes(len as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | (0..len).into_iter().map(|_| Constant::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | (0..len).into_iter().map(|_| Interface::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | (0..len).into_iter().map(|_| Field::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | (0..len).into_iter().map(|_| Method::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | (0..len).into_iter().map(|_| Attribute::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | (0..len).into_iter().map(|_| ExceptionTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.enumerate()` or similar iterators [INFO] [stderr] --> src/classfile.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | for item in self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/classfile.rs:575:12 [INFO] [stderr] | [INFO] [stderr] 575 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/classfile.rs:585:12 [INFO] [stderr] | [INFO] [stderr] 585 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/classfile.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | write!(f, ": "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:393:24 [INFO] [stderr] | [INFO] [stderr] 393 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:397:20 [INFO] [stderr] | [INFO] [stderr] 397 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Interface { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:397:44 [INFO] [stderr] | [INFO] [stderr] 397 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Interface { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:403:24 [INFO] [stderr] | [INFO] [stderr] 403 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:407:20 [INFO] [stderr] | [INFO] [stderr] 407 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Field { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:407:44 [INFO] [stderr] | [INFO] [stderr] 407 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> Field { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:472:24 [INFO] [stderr] | [INFO] [stderr] 472 | fn serialize(self, buf: &mut Vec) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/classfile.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> ExceptionTableEntry { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classfile` [INFO] [stderr] --> src/classfile.rs:476:44 [INFO] [stderr] | [INFO] [stderr] 476 | fn deserialize(buf: &mut Deserializer, classfile: &Classfile) -> ExceptionTableEntry { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classfile` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut buf = &mut Deserializer::new(Box::new(stream.bytes().map(|r| r.unwrap()))); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | let mut code_buf = &mut Deserializer::new(Box::new(code.into_iter())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/classfile.rs:454:13 [INFO] [stderr] | [INFO] [stderr] 454 | let mut buf2 = &mut Deserializer::new(Box::new(attribute_body.into_iter())); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PUBLIC` [INFO] [stderr] --> src/classfile_builder.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const ACC_PUBLIC: u16 = 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_STATIC` [INFO] [stderr] --> src/classfile_builder.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const ACC_STATIC: u16 = 0x8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ClassfileBuilder` [INFO] [stderr] --> src/classfile_builder.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct ClassfileBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/classfile_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(access_flags: u16, this_class: &str, super_class: &str) -> ClassfileBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_method` [INFO] [stderr] --> src/classfile_builder.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn define_method(&mut self, access_flags: u16, name: &str, descriptor: &str) -> MethodBuilder { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_constant` [INFO] [stderr] --> src/classfile_builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | fn push_constant(&mut self, constant: Constant) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_utf8` [INFO] [stderr] --> src/classfile_builder.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn define_utf8(&mut self, string: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_class` [INFO] [stderr] --> src/classfile_builder.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn define_class(&mut self, class: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_name_and_type` [INFO] [stderr] --> src/classfile_builder.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | fn define_name_and_type(&mut self, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_fieldref` [INFO] [stderr] --> src/classfile_builder.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | fn define_fieldref(&mut self, class: &str, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `define_methodref` [INFO] [stderr] --> src/classfile_builder.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | fn define_methodref(&mut self, class: &str, name: &str, descriptor: &str) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `done` [INFO] [stderr] --> src/classfile_builder.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn done(self) -> Classfile { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MethodBuilder` [INFO] [stderr] --> src/classfile_builder.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | pub struct MethodBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/classfile_builder.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | fn new(classfile: &'a mut ClassfileBuilder, access_flags: u16, name: &str, descriptor: &str) -> MethodBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_static` [INFO] [stderr] --> src/classfile_builder.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_static(&mut self, class: &str, name: &str, descriptor: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `invoke_virtual` [INFO] [stderr] --> src/classfile_builder.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn invoke_virtual(&mut self, class: &str, name: &str, descriptor: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bipush` [INFO] [stderr] --> src/classfile_builder.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn bipush(&mut self, value: i8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iadd` [INFO] [stderr] --> src/classfile_builder.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn iadd(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `do_return` [INFO] [stderr] --> src/classfile_builder.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn do_return(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `increase_stack_depth` [INFO] [stderr] --> src/classfile_builder.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | fn increase_stack_depth(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decrease_stack_depth` [INFO] [stderr] --> src/classfile_builder.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | fn decrease_stack_depth(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `done` [INFO] [stderr] --> src/classfile_builder.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn done(self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:193:10 [INFO] [stderr] | [INFO] [stderr] 193 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:58 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:207:80 [INFO] [stderr] | [INFO] [stderr] 207 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/classfile.rs:221:32 [INFO] [stderr] | [INFO] [stderr] 221 | let v = buf.take_bytes(len as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | (0..len).into_iter().map(|_| Constant::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | (0..len).into_iter().map(|_| Interface::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | (0..len).into_iter().map(|_| Field::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | (0..len).into_iter().map(|_| Method::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | (0..len).into_iter().map(|_| Attribute::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classfile.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | (0..len).into_iter().map(|_| ExceptionTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.enumerate()` or similar iterators [INFO] [stderr] --> src/classfile.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | for item in self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/classfile.rs:575:12 [INFO] [stderr] | [INFO] [stderr] 575 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/classfile.rs:585:12 [INFO] [stderr] | [INFO] [stderr] 585 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/classfile.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | write!(f, ": "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "9df82e9b97c79dad803c2dfb12e2b94fc4725916826dfb5689ac54d870da0101"` [INFO] running `"docker" "rm" "-f" "9df82e9b97c79dad803c2dfb12e2b94fc4725916826dfb5689ac54d870da0101"` [INFO] [stdout] 9df82e9b97c79dad803c2dfb12e2b94fc4725916826dfb5689ac54d870da0101