[INFO] crate juniper_iron 0.2.0 is already in cache [INFO] extracting crate juniper_iron 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/juniper_iron/0.2.0 [INFO] extracting crate juniper_iron 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_iron/0.2.0 [INFO] validating manifest of juniper_iron-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of juniper_iron-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing juniper_iron-0.2.0 [INFO] finished frobbing juniper_iron-0.2.0 [INFO] frobbed toml for juniper_iron-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/juniper_iron/0.2.0/Cargo.toml [INFO] started frobbing juniper_iron-0.2.0 [INFO] finished frobbing juniper_iron-0.2.0 [INFO] frobbed toml for juniper_iron-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/juniper_iron/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting juniper_iron-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/juniper_iron/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0dca2df926cf8eae5bc9163b30af0fa7d56ea725afa41cfb020c609ea4a59a0c [INFO] running `"docker" "start" "-a" "0dca2df926cf8eae5bc9163b30af0fa7d56ea725afa41cfb020c609ea4a59a0c"` [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Compiling juniper_codegen v0.10.0 [INFO] [stderr] Checking logger v0.4.0 [INFO] [stderr] Checking juniper v0.10.0 [INFO] [stderr] Checking juniper_iron v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | context_factory: context_factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_factory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | status_code: status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | context_factory: context_factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_factory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | status_code: status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match self { [INFO] [stderr] 157 | | &GraphQLBatchRequest::Single(ref request) => { [INFO] [stderr] 158 | | GraphQLBatchResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 159 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | ), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *self { [INFO] [stderr] 157 | GraphQLBatchRequest::Single(ref request) => { [INFO] [stderr] 158 | GraphQLBatchResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 159 | } [INFO] [stderr] 160 | GraphQLBatchRequest::Batch(ref requests) => GraphQLBatchResponse::Batch( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match self { [INFO] [stderr] 173 | | &GraphQLBatchResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 174 | | &GraphQLBatchResponse::Batch(ref responses) => responses [INFO] [stderr] 175 | | .iter() [INFO] [stderr] 176 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 172 | match *self { [INFO] [stderr] 173 | GraphQLBatchResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 174 | GraphQLBatchResponse::Batch(ref responses) => responses [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | .iter() [INFO] [stderr] | ________________________^ [INFO] [stderr] 176 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] | |__________________________________________________________________^ help: try: `.all(|response| response.is_ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match self { [INFO] [stderr] 157 | | &GraphQLBatchRequest::Single(ref request) => { [INFO] [stderr] 158 | | GraphQLBatchResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 159 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | ), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *self { [INFO] [stderr] 157 | GraphQLBatchRequest::Single(ref request) => { [INFO] [stderr] 158 | GraphQLBatchResponse::Single(request.execute(root_node, context)) [INFO] [stderr] 159 | } [INFO] [stderr] 160 | GraphQLBatchRequest::Batch(ref requests) => GraphQLBatchResponse::Batch( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | / match self { [INFO] [stderr] 173 | | &GraphQLBatchResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 174 | | &GraphQLBatchResponse::Batch(ref responses) => responses [INFO] [stderr] 175 | | .iter() [INFO] [stderr] 176 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 172 | match *self { [INFO] [stderr] 173 | GraphQLBatchResponse::Single(ref response) => response.is_ok(), [INFO] [stderr] 174 | GraphQLBatchResponse::Batch(ref responses) => responses [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | .iter() [INFO] [stderr] | ________________________^ [INFO] [stderr] 176 | | .fold(true, |ok, response| ok && response.is_ok()), [INFO] [stderr] | |__________________________________________________________________^ help: try: `.all(|response| response.is_ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:454:27 [INFO] [stderr] | [INFO] [stderr] 454 | let status_code = response [INFO] [stderr] | ___________________________^ [INFO] [stderr] 455 | | .status [INFO] [stderr] 456 | | .expect("No status code returned from handler") [INFO] [stderr] 457 | | .to_u16() as i32; [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 454 | let status_code = i32::from(response [INFO] [stderr] 455 | .status [INFO] [stderr] 456 | .expect("No status code returned from handler") [INFO] [stderr] 457 | .to_u16()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.74s [INFO] running `"docker" "inspect" "0dca2df926cf8eae5bc9163b30af0fa7d56ea725afa41cfb020c609ea4a59a0c"` [INFO] running `"docker" "rm" "-f" "0dca2df926cf8eae5bc9163b30af0fa7d56ea725afa41cfb020c609ea4a59a0c"` [INFO] [stdout] 0dca2df926cf8eae5bc9163b30af0fa7d56ea725afa41cfb020c609ea4a59a0c